Taylor Brandstetter
d0acbd8645
Revert "Do all BaseChannel operations within a single Thread::Invoke."
...
This reverts commit c1ad1ff178f0d0dfcde42843c51ae703005aaca1.
Reason for revert: This blocks the worker thread for a longer
contiguous period of time which can lead to delays in processing
packets. And due to other recent changes, the need to speed up
SetLocalDescription/SetRemoteDescription is reduced.
Still plan to reland some of the changes from the CL, just not the
part that groups the Invokes.
Original change's description:
> Do all BaseChannel operations within a single Thread::Invoke.
>
> Instead of doing a separate Invoke for each channel, this CL first
> gathers a list of operations to be performed on the signaling thread,
> then does a single Invoke on the worker thread (and nested Invoke
> on the network thread) to update all channels at once.
>
> This includes the methods:
> * Enable
> * SetLocalContent/SetRemoteContent
> * RegisterRtpDemuxerSink
> * UpdateRtpHeaderExtensionMap
>
> Also, removed the need for a network thread Invoke in
> IsReadyToSendMedia_w by moving ownership of was_ever_writable_ to the
> worker thread.
>
> Bug: webrtc:12266
> Change-Id: I31e61fe0758aeb053b09db84f234deb58dfb3d05
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194181
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32817}
TBR=deadbeef@webrtc.org ,hta@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:12266
Change-Id: I40ec519a614dc740133219f775b5638a488529b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203860
Reviewed-by: Taylor <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33111}
2021-01-29 21:56:38 +00:00
..
2020-09-29 10:19:20 +00:00
2021-01-28 18:17:03 +00:00
2021-01-15 17:00:05 +00:00
2019-11-27 12:52:48 +00:00
2021-01-15 17:00:05 +00:00
2020-06-08 12:59:40 +00:00
2020-11-09 10:47:55 +00:00
2020-05-26 20:27:34 +00:00
2021-01-29 15:45:19 +00:00
2021-01-23 14:07:28 +00:00
2021-01-29 08:24:43 +00:00
2020-01-21 12:13:11 +00:00
2020-11-04 14:53:13 +00:00
2020-04-02 09:54:27 +00:00
2021-01-27 19:16:46 +00:00
2018-06-19 14:00:39 +00:00
2021-01-29 08:24:43 +00:00
2021-01-29 08:24:43 +00:00
2021-01-29 08:24:43 +00:00
2020-03-02 11:36:58 +00:00
2020-01-28 19:16:18 +00:00
2019-02-20 16:02:59 +00:00
2019-10-15 09:07:44 +00:00
2021-01-15 17:00:05 +00:00
2021-01-15 17:00:05 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-02-03 21:19:57 +00:00
2020-02-03 21:19:57 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:05:20 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 11:41:20 +00:00
2020-07-08 11:41:20 +00:00
2019-07-03 13:30:01 +00:00
2021-01-29 21:56:38 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-03-02 20:55:28 +00:00
2020-03-02 20:55:28 +00:00
2020-03-02 20:55:28 +00:00
2019-01-11 17:11:39 +00:00
2020-09-29 12:57:20 +00:00
2020-11-23 11:29:36 +00:00
2020-05-26 20:27:34 +00:00
2020-05-29 11:42:06 +00:00
2021-01-29 15:45:19 +00:00
2019-11-15 11:48:42 +00:00
2019-11-15 11:48:42 +00:00
2019-11-15 11:48:42 +00:00
2019-07-08 13:45:15 +00:00
2019-03-31 11:55:09 +00:00
2021-01-29 08:24:43 +00:00
2020-11-26 08:41:36 +00:00
2020-11-26 08:41:36 +00:00
2021-01-29 08:24:43 +00:00
2019-01-25 20:29:58 +00:00
2019-01-25 20:29:58 +00:00
2020-11-18 20:49:08 +00:00
2020-11-09 10:47:55 +00:00
2020-11-18 20:49:08 +00:00
2018-06-19 14:00:39 +00:00
2020-09-29 10:19:20 +00:00
2021-01-21 18:14:14 +00:00
2021-01-22 16:20:22 +00:00
2021-01-22 16:20:22 +00:00
2020-01-15 13:36:58 +00:00
2019-01-11 17:11:39 +00:00
2018-11-28 18:25:07 +00:00
2019-05-15 23:54:07 +00:00
2018-05-21 19:35:08 +00:00
2019-05-10 07:07:19 +00:00
2019-05-10 07:07:19 +00:00
2018-11-28 18:25:07 +00:00
2018-02-28 19:58:24 +00:00
2019-10-15 09:07:44 +00:00
2018-06-19 14:00:39 +00:00
2020-06-04 09:55:12 +00:00
2018-06-19 14:00:39 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2018-06-19 14:00:39 +00:00
2018-11-28 18:25:07 +00:00
2019-04-11 16:35:18 +00:00
2019-04-11 16:35:18 +00:00
2020-02-10 12:21:17 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-03-02 10:18:01 +00:00
2020-11-23 14:58:39 +00:00
2020-04-16 14:21:41 +00:00
2020-04-16 14:21:41 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-08-08 08:29:18 +00:00
2018-06-19 14:00:39 +00:00
2018-12-17 17:33:06 +00:00
2020-02-10 12:21:17 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-10-15 09:07:44 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:05:20 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-04-24 20:57:20 +00:00
2021-01-15 17:00:05 +00:00
2020-12-10 11:04:58 +00:00
2021-01-12 12:35:38 +00:00
2019-12-03 19:43:12 +00:00
2020-09-30 13:58:29 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-09-21 20:42:59 +00:00
2020-09-21 20:42:59 +00:00
2020-09-22 12:08:38 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-10-25 12:07:32 +00:00
2019-10-25 12:07:32 +00:00
2018-11-28 18:25:07 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2021-01-11 07:53:03 +00:00
2020-09-25 11:44:02 +00:00
2020-09-25 11:44:02 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2020-11-26 01:00:22 +00:00
2020-01-10 19:03:12 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-09-17 15:47:29 +00:00
2020-03-02 11:36:58 +00:00
2020-03-02 11:36:58 +00:00
2021-01-15 17:00:05 +00:00
2021-01-15 17:00:05 +00:00
2020-04-02 07:48:36 +00:00
2020-04-02 07:48:36 +00:00
2020-08-13 20:50:23 +00:00
2020-08-13 20:50:23 +00:00
2020-11-09 10:47:55 +00:00
2020-09-11 18:22:14 +00:00
2020-03-24 11:48:42 +00:00
2020-03-24 11:48:42 +00:00
2020-03-30 13:02:46 +00:00
2020-12-06 21:28:59 +00:00
2020-12-06 21:28:59 +00:00
2020-12-06 21:28:59 +00:00
2020-09-07 12:57:15 +00:00
2019-07-08 13:45:15 +00:00
2020-05-06 20:19:49 +00:00
2019-01-11 17:11:39 +00:00
2020-07-08 20:38:54 +00:00
2020-05-14 19:33:26 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-11-09 10:47:55 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2018-04-06 01:01:48 +00:00
2021-01-29 08:24:43 +00:00
2020-10-06 14:10:36 +00:00
2020-11-23 11:29:36 +00:00
2020-12-15 13:59:32 +00:00
2021-01-15 17:00:05 +00:00
2021-01-15 17:00:05 +00:00
2021-01-15 17:00:05 +00:00
2020-05-17 17:22:01 +00:00
2019-03-04 12:42:10 +00:00
2020-10-26 09:55:26 +00:00
2019-07-08 13:45:15 +00:00
2019-05-06 07:34:09 +00:00
2019-02-16 11:11:45 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-09-17 15:47:29 +00:00
2019-03-28 13:33:30 +00:00
2019-07-08 13:45:15 +00:00
2018-10-23 11:32:56 +00:00
2020-09-18 17:42:53 +00:00
2017-11-22 11:21:47 +00:00
2021-01-07 16:40:50 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 20:38:54 +00:00
2020-09-29 10:19:20 +00:00
2020-01-15 13:46:38 +00:00
2020-05-25 12:14:44 +00:00
2020-05-25 12:14:44 +00:00
2020-01-15 13:46:38 +00:00
2020-12-15 12:17:12 +00:00
2020-12-15 12:17:12 +00:00
2019-01-11 17:11:39 +00:00
2021-01-22 16:20:22 +00:00
2021-01-22 16:20:22 +00:00
2019-11-26 14:05:20 +00:00
2019-07-08 13:45:15 +00:00
2020-09-18 17:42:53 +00:00
2020-04-15 09:30:07 +00:00
2020-12-11 09:58:40 +00:00
2019-10-15 09:07:44 +00:00
2020-03-21 18:53:46 +00:00
2020-03-21 18:53:46 +00:00
2019-10-15 09:07:44 +00:00
2018-11-28 18:25:07 +00:00
2018-11-26 19:20:27 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2020-05-28 07:52:53 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-04-09 17:18:20 +00:00
2019-01-11 17:11:39 +00:00
2019-12-10 08:32:10 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-01-03 18:42:32 +00:00
2020-12-10 11:04:58 +00:00
2019-01-11 17:11:39 +00:00
2020-01-10 19:03:12 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-09-07 12:57:15 +00:00
2020-08-31 20:26:37 +00:00
2019-07-08 13:45:15 +00:00
2020-01-07 09:54:44 +00:00
2020-05-14 19:33:26 +00:00
2019-01-11 17:11:39 +00:00
2020-04-14 11:00:49 +00:00
2020-12-11 09:58:40 +00:00
2019-10-15 09:07:44 +00:00
2019-09-17 15:47:29 +00:00
2019-10-15 09:07:44 +00:00
2020-12-11 09:58:40 +00:00
2020-12-11 09:58:40 +00:00
2020-04-16 20:56:25 +00:00
2020-10-29 21:08:10 +00:00
2020-12-11 09:58:40 +00:00
2020-03-21 18:53:46 +00:00
2020-10-26 10:45:06 +00:00
2020-10-05 13:46:03 +00:00
2020-10-05 13:46:03 +00:00
2019-07-08 13:45:15 +00:00
2019-08-29 14:16:23 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2018-10-23 11:32:56 +00:00
2019-07-30 19:35:37 +00:00
2020-09-17 13:18:25 +00:00
2020-09-17 13:18:25 +00:00
2020-05-26 20:27:34 +00:00
2021-01-15 17:59:05 +00:00
2019-03-19 18:11:52 +00:00
2020-05-04 13:47:35 +00:00
2020-03-18 16:06:09 +00:00
2019-02-20 17:08:53 +00:00
2020-07-08 20:38:54 +00:00
2019-02-12 10:58:36 +00:00
2020-07-08 20:38:54 +00:00
2019-02-21 14:36:07 +00:00
2021-01-29 08:24:43 +00:00
2020-07-08 20:38:54 +00:00
2019-02-21 09:33:42 +00:00
2019-04-10 10:27:07 +00:00
2019-09-17 15:47:29 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-09-17 15:47:29 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2017-11-01 13:23:26 +00:00
2019-07-08 13:45:15 +00:00
2019-04-08 16:58:07 +00:00
2020-01-20 14:07:16 +00:00
2021-01-29 08:24:43 +00:00
2021-01-15 17:00:05 +00:00
2020-10-01 16:38:09 +00:00
2020-02-10 12:21:17 +00:00
2020-07-01 17:21:02 +00:00
2020-01-28 19:16:18 +00:00
2020-03-10 17:22:54 +00:00
2020-03-10 17:22:54 +00:00
2020-03-10 17:22:54 +00:00
2019-11-28 15:58:24 +00:00
2018-06-19 14:00:39 +00:00
2019-07-08 13:45:15 +00:00
2019-02-09 00:55:14 +00:00
2019-02-09 00:55:14 +00:00
2020-10-07 01:26:06 +00:00
2020-10-07 01:26:06 +00:00
2020-11-22 11:34:04 +00:00
2020-11-22 11:34:04 +00:00
2020-09-07 12:57:15 +00:00
2019-10-15 09:17:36 +00:00
2019-04-09 12:28:04 +00:00
2020-11-23 11:29:36 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-10-22 16:15:56 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-05-22 10:32:25 +00:00
2018-11-28 18:25:07 +00:00
2018-03-07 22:06:20 +00:00
2019-07-08 13:45:15 +00:00