admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix MemoryLogWriter so that it always writes the full data.

Browse Source 
Also remove some unused and unnecessary constructors from MemoryStream.

Bug: webrtc:11053
Change-Id: I840820d5c8e9dd987e35db8abce9c51d55c450a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158280
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29614}
This commit is contained in:
Björn Terelius 2019-10-24 18:19:12 +02:00 committed by Commit Bot
parent 53a31f7db8
commit 1a61739122
3 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rtc_base/memory_stream.cc
View File

@ -111,14 +111,6 @@ bool MemoryStream::ReserveSize(size_t size) {
MemoryStream::MemoryStream() {}
MemoryStream::MemoryStream(const char* data) {
SetData(data, strlen(data));
}
MemoryStream::MemoryStream(const void* data, size_t length) {
SetData(data, length);
}
MemoryStream::~MemoryStream() {
delete[] buffer_;
}

2
rtc_base/memory_stream.h
View File

@ -22,8 +22,6 @@ namespace rtc {
class MemoryStream final : public StreamInterface {
public:
MemoryStream();
explicit MemoryStream(const char* data); // Calls SetData(data, strlen(data))
MemoryStream(const void* data, size_t length); // Calls SetData(data, length)
~MemoryStream() override;
StreamState GetState() const override;

3
test/logging/memory_log_writer.cc
View File

@ -30,8 +30,9 @@ class MemoryLogWriter final : public RtcEventLogOutput {
bool Write(const std::string& value) override {
size_t written;
int error;
return buffer_.Write(value.data(), value.size(), &written, &error) ==
return buffer_.WriteAll(value.data(), value.size(), &written, &error) ==
rtc::SR_SUCCESS;
RTC_DCHECK_EQ(value.size(), written);
}
void Flush() override {}