admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Inclusive language: Remove a couple of occurences of "whitelist"

Browse Source 
No-Try: True
Bug: webrtc:11680
Change-Id: I50e2d313be962551a8a1f530f430fbd551a8d3e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/200701
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32933}
This commit is contained in:
Harald Alvestrand 2021-01-05 15:55:20 +00:00 committed by Commit Bot
parent 8cf47fb7ac
commit cffaf0aea4
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc
View File

@ -289,7 +289,7 @@ rtclog2::IceCandidatePairEvent::IceCandidatePairEventType ConvertToProtoFormat(
// Copies all RTCP blocks except APP, SDES and unknown from |packet| to
// |buffer|. |buffer| must have space for at least |packet.size()| bytes.
size_t RemoveNonWhitelistedRtcpBlocks(const rtc::Buffer& packet,
size_t RemoveNonAllowlistedRtcpBlocks(const rtc::Buffer& packet,
uint8_t* buffer) {
RTC_DCHECK(buffer != nullptr);
rtcp::CommonHeader header;
@ -316,7 +316,7 @@ size_t RemoveNonWhitelistedRtcpBlocks(const rtc::Buffer& packet,
// inter-arrival jitter, third-party loss reports, payload-specific
// feedback and extended reports.
// TODO(terelius): As an optimization, don't copy anything if all blocks
// in the packet are whitelisted types.
// in the packet are allowlisted types.
memcpy(buffer + buffer_length, block_begin, block_size);
buffer_length += block_size;
break;
@ -346,7 +346,7 @@ void EncodeRtcpPacket(rtc::ArrayView<const EventType*> batch,
{
std::vector<uint8_t> buffer(base_event->packet().size());
size_t buffer_length =
RemoveNonWhitelistedRtcpBlocks(base_event->packet(), buffer.data());
RemoveNonAllowlistedRtcpBlocks(base_event->packet(), buffer.data());
proto_batch->set_raw_packet(buffer.data(), buffer_length);
}
@ -375,7 +375,7 @@ void EncodeRtcpPacket(rtc::ArrayView<const EventType*> batch,
const EventType* event = batch[i + 1];
scrubed_packets[i].resize(event->packet().size());
static_assert(sizeof(std::string::value_type) == sizeof(uint8_t), "");
const size_t buffer_length = RemoveNonWhitelistedRtcpBlocks(
const size_t buffer_length = RemoveNonAllowlistedRtcpBlocks(
event->packet(), reinterpret_cast<uint8_t*>(&scrubed_packets[i][0]));
if (buffer_length < event->packet().size()) {
scrubed_packets[i].resize(buffer_length);

3
rtc_base/message_digest.h
View File

@ -45,7 +45,8 @@ class MessageDigestFactory {
static MessageDigest* Create(const std::string& alg);
};
// A whitelist of approved digest algorithms from RFC 4572 (FIPS 180).
// A check that an algorithm is in a list of approved digest algorithms
// from RFC 4572 (FIPS 180).
bool IsFips180DigestAlgorithm(const std::string& alg);
// Functions to create hashes.