Henrik Boström
4b51217ef6
Make purple bots happy: Shorten TEST_P names.
...
The recently added tests resulted in some .log file on some bots being
too long:
video_engine_tests_exe-VideoStreamEncoderStandardOrLegacyRequestedResolutionTest_VideoStreamEncoderStandardOrLegacyRequestedResolutionTest_RequestedResolutionInWrongAspectRatioAndSourceIsAdapting_0-1.log
This CL makes the test names significantly shorter.
# Trivial and believed to fix purple bots, let's land ASAP
NOTRY=True
Bug: webrtc:367066321
Change-Id: I831911947af9d5639d1edb559470f1c9ae702d6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362721
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43030}
2024-09-17 11:15:18 +00:00
Dor Hen
59d592ebac
Replace list usage with set for files accumulation in PRESUBMIT to
...
prevent duplication
Wherever we don't include any extra information about the issue (e.g
file *and line number*), there's no need to return a presubmit result
with the file duplicated (it spams the console for no reason...)
bug: none
Change-Id: I11968f97f7c927b01f5cda6e56ea03e3ff47dfca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362621
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43029}
2024-09-17 08:46:56 +00:00
Dor Hen
f3a33c0162
Prepend all RTCMacros.h includes/imports with the relative path from repo
...
root
Bug: webrtc:365299881
Change-Id: Id3adf3b4913da1e04534da232d03455a46c30e4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362582
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43028}
2024-09-17 08:45:53 +00:00
Raman Budny
de6225b2e2
Don't crash on failed EGL makeCurrent attempts
...
EglRenderer.renderFrameOnRenderThread:
suppress GLException thrown by failed EglBase14Impl::makeCurrent invocation.
Bug: webrtc:365957543
Change-Id: I947ad7d39ce01e3bbe9bc767d6427e4271f0c0cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361020
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43027}
2024-09-17 08:21:38 +00:00
Mirko Bonadei
ce69c73ef4
Clobber caches on Windows
...
Bug: webrtc:367066321
Change-Id: Ied4f004255b46921d6c62a73930edb28fd5a5ced
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362700
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43026}
2024-09-17 08:19:07 +00:00
Harald Alvestrand
18486c5574
Make GetSourcesVideo test wait for two frames
...
When it waits for only one frame, the test is flaky.
When it waits for two frames, it is not.
# Relying on triviality for confidence due to purple bots atm,
# see b/367211396
NOTRY=True
NOPRESUBMIT=True
Bug: webrtc:367205682, webrtc:42220900
Change-Id: I14963b7a86961f438fd511aba8f29525e1f19750
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362583
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43025}
2024-09-16 13:22:38 +00:00
Henrik Boström
cbf5122333
Avoid signaling requested_resolution back to the adapting source.
...
When requested_resolution uses a different aspect ratio than the source
the encoder will restrict the frame without changing its aspect ratio,
e.g. a 60x30 input frame that is restricted to 30x30 results in 30x15,
not 30x30.
While this logic works correctly in isolation, if the source also adapts
the frame size based on the sink_wants.requested_resolution that is
signaled back to the source, then the source will produce stretched
30x30 prior to the encoder which happily sends 30x30 not knowing any
wiser.
This is incompatible with the spec[1] and makes this WPT[2] fail. The
correct behavior is to NOT signal the requested_resolution back to the
source, the encoder already configures the correct resolution so this
isn't actually needed and the source shouldn't need to know this API.
In order not to break downstream projects, the new behavior is landed
behind a flag and both behaviors are tested with TEST_P.
This unblocks launching scaleResolutionDownTo API on Web. Migrating
from old to new code path and deleting the flag is a follow-up AI:
webrtc:366284861.
[1] https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-scaleresolutiondownto
[2] https://chromium-review.googlesource.com/c/chromium/src/+/5853944
# Relying on previous green runs for confidence due to purple bots atm,
# see b/367211396
NOTRY=True
NOPRESUBMIT=True
Bug: webrtc:366067962, webrtc:366284861
Change-Id: I7fd1016e9cc6f0b0b9b8c23b0708e521f8e12642
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362541
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43024}
2024-09-16 11:00:13 +00:00
Henrik Lundin
8487d3248b
Remove all use of AcmReceiver from WebRTC
...
The class itself and its unit test remains, for now, but will be removed
later.
Bug: webrtc:14867
Change-Id: I36cec8fca7913663f63c53622ed2760e5e048c2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362580
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43023}
2024-09-16 08:49:25 +00:00
Philipp Hancke
6e312e51d7
install libsrtp log handler
...
which may show useful debug logging.
Also document that we need to forward-declare the internal srtp_ctx_
struct instead of srtp_t.
BUG=webrtc:361372443
Change-Id: I76b1a4fb385af0fc1532f0ce6d0692b804f003dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360182
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#43022}
2024-09-13 16:11:40 +00:00
Philipp Hancke
1320982f5e
Remove SrtpTransport MaybeSetKeyParams and ParseKeyParams
...
which seem unused.
BUG=webrtc:357776213
Change-Id: I346dfecd291474b29a26d20e5bc88a910a38343a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362361
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43021}
2024-09-13 15:07:33 +00:00
Henrik Boström
2b5f7cb4b3
Adjust requested_resolution to match frame's aspect ratio.
...
This API should not modify the aspect ratio of the frame, e.g. if the
frame is 1280x720 and requested_resolution is 1280x360, the result
should be 640x360, not a streched out 1280x360 frame. The spec version
of this API calls this "maxWidth" and "maxHeight" which is the right
way to think about it rather than a forced width and height.
VideoAdapter continues to be used to apply adaptation restrictions, but
we now make sure to calculate the correct frame size BEFORE applying
restrictions. Prior to this CL, the VideoAdapter was also used to apply
requested_resolution restrictions. This is actually wrong and would
cause strange scaling factors in some cases, e.g. f=1280x720 + r=720x405
would result in 640x360 instead of 720x405. Now we make f=720x405 first
and only adjust further if restrictions or alignments require us to.
Since this is a change in behavior a WebRtcVideoChannelTest is updated.
Encodings integration test is also added, both for aspect ratio (new
behavior) and orientation agnosticism (old behavior still passing).
Bug: webrtc:366067962
Change-Id: I4e8dc27da5a84d73238b8ab74ef197eb5ee8072a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362101
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43020}
2024-09-13 10:26:34 +00:00
webrtc-version-updater
13e377b804
Update WebRTC code version (2024-09-13T04:07:27).
...
Bug: None
Change-Id: I85fcbe41881f3f6076a08b5120135538b64f025b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362484
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43019}
2024-09-13 06:00:55 +00:00
chromium-webrtc-autoroll
08ec4447bc
Roll chromium_revision 3b552b31ee..3b70d6f26c (1354345:1354985)
...
Change log: 3b552b31ee..3b70d6f26c3b552b31ee..3b70d6f26c99dc460971..7f2a56694b154f06e2b2..8e0612cd2c34a8595e75..e4f992c066774e1938da..8e01efd2a943f298a862..3f4138fcb1b434c2e410..27c9b4efc2https://chromium.googlesource.com/catapult.git/+log/c46e0e5bd6..296226a4a0
* src/third_party/depot_tools: 17226d7965..d43a3eb7486711fb8465..91903c28af6ae6f38d10..887f732df011b62edaf2..29b2e9a0f440477ffb51..97a5d7ed4d31966b2a47..453f7ad0013b552b31ee..3b70d6f26chttps://webrtc-review.googlesource.com/c/src/+/362485
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43018}
2024-09-13 05:34:54 +00:00
Lionel Koenig
ec38238af7
Ensure the AudioCodingModule is reset when sending is stopped.
...
Bug: webrtc:42226041
Change-Id: Ife3548bda3042a7447b7c50f48f023a2bc0bc443
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362103
Commit-Queue: Lionel Koenig <lionelk@webrtc.org>
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43017}
2024-09-12 22:47:11 +00:00
Harald Alvestrand
6aab4ccf42
Change cricket::Codec default id from 0 to -1
...
This allows detecting if it has been set reliably.
0 is a valid payload type.
Bug: webrtc:360058654
Change-Id: Ic3646abe20d0247592145ad27549fa46ddb7ec90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362261
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43016}
2024-09-12 21:26:48 +00:00
henrika
dfd8f570cd
Adds a WebRTC.DesktopCapture.Win.WgcDirtyRegionSupport UMA for diagnostic purposes.
...
Checks if the DirtyRegionMode property is present in GraphicsCaptureSession and logs a boolean histogram with the result.
Detecting support for this property means that the WGC API supports
dirty regions and it can be utilized to improve the capture
performance and the existing zero-herz support.
See also https://issues.chromium.org/issues/347991512 for more details
on how to detect support for dirty regions in WGC.
Bug: chromium:40259177
Change-Id: Ia316c4ece54bd93cfef1fa23c199675c64143f76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362240
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43015}
2024-09-12 19:41:44 +00:00
Harald Alvestrand
97c594fafe
Add field trial for late PT allocation
...
Note: Does not include code for the actual late allocation
of PTs.
Bug: webrtc:360058654
Change-Id: Iaa6bd2db2f974aad84fe1ae9c1aca5aea5d1d25e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362320
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43014}
2024-09-12 14:42:27 +00:00
Emil Vardar
185910953a
Specify in which RTP packet corruption score will be sent on.
...
See e.g. this: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc;l=304;bpv=1;bpt=0?q=webrtc%2Fmodules%2Frtp_rtcp%2Fsource%2Frtp_sender_video.cc&ss=chromium%2Fchromium%2Fsrc:third_party%2Fwebrtc%2F . One needs to know if the extension will be added to the first or last packet. Furthermore, one can see that other extensions add it as a note at the bottom, which I follow here. See e.g. http://www.webrtc.org/experiments/rtp-hdrext/video-content-type
Bug: webrtc:358039777
Change-Id: I7523f5e6b267528a1389bcbde6ee6fa22fb3233a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362060
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org>
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Cr-Commit-Position: refs/heads/main@{#43013}
2024-09-12 13:31:04 +00:00
Jonas Oreland
fb0da3a2aa
Increase test coverage of InitialFrameDropper vs. ScaleResolutionDownBy
...
Bug: b/364252657
Change-Id: I40f3acac7b6473c98a8d1a71c2b68f69cd9d78d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362420
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43012}
2024-09-12 09:52:38 +00:00
Jonas Oreland
0d31d7b8dd
Increase test coverage of InitialFrameDropper vs. RequestedResolution
...
Bug: b/364252657
Change-Id: I4924428c3f002a168eea12f111cb13890cad19f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362220
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43011}
2024-09-12 08:15:26 +00:00
webrtc-version-updater
ad4d3e9ae5
Update WebRTC code version (2024-09-12T04:08:20).
...
Bug: None
Change-Id: I29412a956b0a7333e52a4db8672bf7fe2737d85f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362135
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43010}
2024-09-12 06:11:31 +00:00
chromium-webrtc-autoroll
ca368dd976
Roll chromium_revision 5c2bd4f9ef..3b552b31ee (1353980:1354345)
...
Change log: 5c2bd4f9ef..3b552b31ee5c2bd4f9ef..3b552b31eed8066bf67e..99dc4609718da4111241..154f06e2b2ffe22f74f9..774e1938dace25820b96..43f298a86246762f4ba9..b434c2e410https://boringssl.googlesource.com/boringssl.git/+log/40ec347196..e724ef0208
* src/third_party/depot_tools: 1ad5b6c0df..17226d796576c9a3333b..40477ffb51c523a3ce5f..31966b2a475c2bd4f9ef..3b552b31eehttps://webrtc-review.googlesource.com/c/src/+/362382
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43009}
2024-09-12 04:49:35 +00:00
chromium-webrtc-autoroll
9e0f2feb00
Roll chromium_revision 6c19d4f358..5c2bd4f9ef (1353847:1353980)
...
Change log: 6c19d4f358..5c2bd4f9ef6c19d4f358..5c2bd4f9effc8f6117cb..d8066bf67ec08e101374..8da411124109c7886347..ffe22f74f952156e171b..ce25820b96ba5dcddcad..46762f4ba94426a8da65..927aabfcd22e577c61f3..76c9a3333b153d0bffba..c523a3ce5f6c19d4f358..5c2bd4f9efhttps://webrtc-review.googlesource.com/c/src/+/362153
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43008}
2024-09-11 17:00:23 +00:00
Fanny Linderborg
97d0427080
Add converters for corruption detection structs
...
Bug: webrtc:358039777
Change-Id: I05b99fe05023e83236f37fd53d96993696989ca6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361823
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43007}
2024-09-11 13:44:04 +00:00
Jeremy Leconte
e25b15e22b
Update ownership of PCLF documentation.
...
Change-Id: I87fe1b4c0f72cc164e94ae63e7f544c0d15f39ab
Bug: b/362910201, b/362909489
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362340
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#43006}
2024-09-11 13:03:08 +00:00
Danil Chapovalov
51a2bd130d
Allow sdk/objc owners to approve sdk/BUILD.gn
...
historically build rules for objc wrappers are kept outside of the objc folder
This rule allows objc owners to modify/approve build rules in addition to code changes
Bug: None
Change-Id: Ic5cf4afc4a710912124823bd797f43b39c72425f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361040
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43005}
2024-09-11 10:57:31 +00:00
chromium-webrtc-autoroll
e88a9614f2
Roll chromium_revision 91acefc7c4..6c19d4f358 (1353678:1353847)
...
Change log: 91acefc7c4..6c19d4f35891acefc7c4..6c19d4f358b5bf9a2c33..fc8f6117cb181b8ea805..c08e101374fd72509318..09c7886347bc0b7c07c9..52156e171bb1d88d66a4..ba5dcddcadhttps://boringssl.googlesource.com/boringssl.git/+log/604868d748..40ec347196
* src/third_party/depot_tools: c36eb432d9..1ad5b6c0df4c4c4f36f4..153d0bffba91acefc7c4..6c19d4f358https://webrtc-review.googlesource.com/c/src/+/362152
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43004}
2024-09-11 10:37:54 +00:00
Harald Alvestrand
2fb369aec4
Refresh g3doc/implementation_basics.md
...
Bug: b/364206289
Change-Id: Ic082160123ee28fc423ffa151573ce0e85c5624a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362200
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43003}
2024-09-11 10:27:18 +00:00
Henrik Boström
254bd32188
Update when/how requested_resolution throws for invalid parameters.
...
This CL makes `requested_resolution`, which is the C++ name for what
the spec calls scaleResolutionDownTo, align with the latest PR[1].
The PR says to ignore scaleResolutionDownBy when scaleResolutionDownTo
is specified as to be backwards compatible with scaleResolutionDownBy's
default scaling factors (e.g. 4:2:1). Ignoring is different than what
the code does today which is to throw an InvalidModificationError.
We don't want to throw or else get+setParameters() would throw by
default due to 4:2:1 defaults so the app would have to remember to
delete these attributes every time even though it never specified them
(Chrome has a bug here but fixing that would expose this problem, see
https://crbug.com/344943229 ).
[1] https://github.com/w3c/webrtc-extensions/pull/221
Bug: none
Change-Id: I21165c9b9f9ee7259d88b89f9ae58b862ea4521e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362260
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43002}
2024-09-11 09:45:08 +00:00
Jeremy Leconte
1bd331f102
Ensure <netinet/in.h> is included by using rtc_base/ip_address.h.
...
Change-Id: I1b48275ef458bcd579d027b879240c702975ab56
Bug: b/236227627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362280
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#43001}
2024-09-11 08:11:44 +00:00
webrtc-version-updater
47d48a2089
Update WebRTC code version (2024-09-11T04:05:44).
...
Bug: None
Change-Id: I10f2c0e9123eb3e600e5db34ddd6cb4b01a8966a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362150
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43000}
2024-09-11 07:09:55 +00:00
chromium-webrtc-autoroll
6e8cff47e6
Roll chromium_revision 817ee7871b..91acefc7c4 (1353554:1353678)
...
Change log: 817ee7871b..91acefc7c4817ee7871b..91acefc7c45113471744..b5bf9a2c336a71c9b405..34a8595e75fbb64c1ca9..fd7250931845e570240d..bc0b7c07c9ec278cb93b..b1d88d66a4https://boringssl.googlesource.com/boringssl.git/+log/f10c1dc371..604868d748
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a16df6024b..c46e0e5bd6
* src/third_party/depot_tools: 46f5de67e1..c36eb432d99be1056e88..6ae6f38d104eb5915c04..2e577c61f3856c472ca7..4c4c4f36f4817ee7871b..91acefc7c4https://webrtc-review.googlesource.com/c/src/+/362127
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42999}
2024-09-11 01:05:24 +00:00
chromium-webrtc-autoroll
3accb4c9bb
Roll chromium_revision 56088b275c..817ee7871b (1353390:1353554)
...
Change log: 56088b275c..817ee7871b56088b275c..817ee7871b0f8ad045f2..181b8ea80555b529a2ae..fbb64c1ca9040715ab52..45e570240dcd99df7ac8..ec278cb93bhttps://chromium.googlesource.com/catapult.git/+log/39de890708..a16df6024b
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/dee70e618b..d5265b1736
* src/third_party/perfetto: 7eb1a22d05..4eb5915c04f50a99713c..856c472ca756088b275c..817ee7871bhttps://webrtc-review.googlesource.com/c/src/+/362300
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42998}
2024-09-10 20:45:10 +00:00
chromium-webrtc-autoroll
e184c56bef
Roll chromium_revision 5dc6c1eec4..56088b275c (1353232:1353390)
...
Change log: 5dc6c1eec4..56088b275c5dc6c1eec4..56088b275c9eba86d7c1..51134717441c773de893..0f8ad045f2bcd2c3877b..55b529a2ae33cf49385c..040715ab52766a5b8906..cd99df7ac8bea7f2f92c..7eb1a22d057e778777ca..f50a99713c5dc6c1eec4..56088b275chttps://webrtc-review.googlesource.com/c/src/+/362148
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42997}
2024-09-10 16:49:27 +00:00
Jeremy Leconte
83d1f9abd0
Ensure <sys/socket.h> is included by using "rtc_base/net_helpers.h".
...
* IWYU export <sys/socket.h> from rtc_base/net_helpers.h.
* Add a presubmit check to ensures that <sys/socket.h> is included through net_helpers.h (expect if there is a IWYU pragma or a no-presubmit-check).
* Clean up existing includes of <sys/socket.h>
Change-Id: I4bc6cce045c046287f8f74f89edfc9321293b274
Bug: b/236227627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362082
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42996}
2024-09-10 14:23:24 +00:00
Sergey Silkin
84273f56d9
Specify max number of consecutive drops using time units
...
AV1E_SET_MAX_CONSEC_FRAME_DROP_MS_CBR was added in https://aomedia-review.googlesource.com/c/aom/+/192402 . It allows to configure max number of consecutive frame drops using time units. Use it instead of AV1E_SET_MAX_CONSEC_FRAME_DROP_CBR.
Bug: webrtc:351644568
Change-Id: I73265d5258d681926eb5b65e32c2a61b26c310ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360842
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Marco Paniconi <marpan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42995}
2024-09-10 13:16:34 +00:00
chromium-webrtc-autoroll
a9865142cd
Roll chromium_revision 4a8f19d868..5dc6c1eec4 (1353126:1353232)
...
Change log: 4a8f19d868..5dc6c1eec44a8f19d868..5dc6c1eec4e49947324b..9eba86d7c1d205365c8f..bcd2c3877b862b3acbfc..33cf49385c8f38918c74..766a5b8906https://chromium.googlesource.com/catapult.git/+log/51cd0db6db..39de890708
* src/third_party/depot_tools: 8258c1340a..46f5de67e12f5bca30f5..7e778777ca4a8f19d868..5dc6c1eec4https://webrtc-review.googlesource.com/c/src/+/362124
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42994}
2024-09-10 10:53:00 +00:00
Dor Hen
28ce65c6f9
Apply include-cleaner to api direct files
...
Bug: webrtc:42226242
Change-Id: Ia1e6021fc18a30b6da9b4a43118167b6ae173717
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360680
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42993}
2024-09-10 08:29:26 +00:00
webrtc-version-updater
21c456e388
Update WebRTC code version (2024-09-10T04:06:53).
...
Bug: None
Change-Id: I9e7e7c2705e6638741682e0d10bcaf2e2da369fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362142
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42992}
2024-09-10 05:59:25 +00:00
chromium-webrtc-autoroll
4ea6534ec6
Roll chromium_revision c339b49443..4a8f19d868 (1353018:1353126)
...
Change log: c339b49443..4a8f19d868c339b49443..4a8f19d8684ceec41f7a..e49947324bcd40eb5d6c..1c773de893c50379e934..6a71c9b405f05e910396..d205365c8f0c24c20569..862b3acbfc18f3377aca..8f38918c74https://chromium.googlesource.com/catapult.git/+log/753e45cfb9..51cd0db6db
* src/third_party/depot_tools: 653e86a6f0..8258c1340a05411385be..2f5bca30f5c339b49443..4a8f19d868https://webrtc-review.googlesource.com/c/src/+/362143
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42991}
2024-09-10 05:23:19 +00:00
chromium-webrtc-autoroll
110f7db15c
Roll chromium_revision 33ef804c4e..c339b49443 (1352775:1353018)
...
Change log: 33ef804c4e..c339b4944333ef804c4e..c339b49443c91c18b88f..4ceec41f7ac50323369f..cd40eb5d6ce483cf2f61..f05e910396c37c475588..0c24c205691c8a388020..18f3377acahttps://boringssl.googlesource.com/boringssl.git/+log/01e1ae3687..f10c1dc371
* src/third_party/crc32c/src: fa5ade41ee..d3d60ac6e0ae3745656b..653e86a6f03008032062..83af801b557ef1f0a187..9be1056e886a4a99c3a7..bea7f2f92cf5c9abc053..05411385be33ef804c4e..c339b49443https://webrtc-review.googlesource.com/c/src/+/362180
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42990}
2024-09-09 23:28:33 +00:00
Harald Alvestrand
dc56a36ff8
Use PayloadTypePicker in WebRtcVoiceEngine
...
This entails passing in a PayloadTypeSuggester as a dependency. PT suggesting is still done according to the old method, but with new code.
Bug: webrtc:360058654
Change-Id: I12a7d2aa6aa482fb62ff3dfb34b9761ebb7dddef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361200
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42989}
2024-09-09 18:44:21 +00:00
Harald Alvestrand
927244db7e
Set MID in AudioReceiveChannel
...
This variable was present but unset.
Bug: webrtc:360058654
Change-Id: I492069a1e87208c6fbb5ad5f0a00fcc2ccc0bc25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361824
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42988}
2024-09-09 17:58:33 +00:00
chromium-webrtc-autoroll
27db338658
Roll chromium_revision c03ff62a28..33ef804c4e (1351560:1352775)
...
Change log: c03ff62a28..33ef804c4ec03ff62a28..33ef804c4ee9e5cfb550..c91c18b88f136f79a9af..c50323369f012c060b76..c50379e9345afb02692a..e483cf2f613dde5eea0e..c37c475588aa75790dea..1c8a388020https://boringssl.googlesource.com/boringssl.git/+log/97322b29e8..01e1ae3687
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ee4a947642..753e45cfb9
* src/third_party/depot_tools: 9bbf9b0541..ae3745656b468b9c8a52..6711fb8465d2612e1c3f..3008032062https://aomedia.googlesource.com/aom.git/+log/5fac32ad87..dee70e618b
* src/third_party/libc++/src: a4812f9f72..7ef1f0a187a834cb2539..11b62edaf203d8b3e17c..6a4a99c3a75a4e9143e8..f5c9abc053c03ff62a28..33ef804c4ehttps://webrtc-review.googlesource.com/c/src/+/362121
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42987}
2024-09-09 17:26:57 +00:00
Björn Terelius
0f61f60e46
Mock call to os.path.isdir in roll_deps_test.
...
Bug: b/365524353
Change-Id: I9494a022b18b6c9c240f86a77ec0430cb27149b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362085
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42986}
2024-09-09 15:10:07 +00:00
Danil Chapovalov
76aa330c24
Implement ObjCVideoEncoderFactory::QueryCodecSupport
...
To allow objc video encoders to support scalability modes
Bug: b/299588022
Change-Id: Id58f996b8c48c6688cccdc32caff6adb00370d5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358580
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42985}
2024-09-09 13:56:04 +00:00
Danil Chapovalov
0acbb7745f
Pass Environment into RtcpSender
...
To remove usage of RtcpConfiguration fields that are passed through Environment
Bug: webrtc:362762208
Change-Id: I1a0f218efe6a893c31ef2272cf2379c66fb7b205
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361746
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42984}
2024-09-09 13:44:21 +00:00
Ilya Nikolaevskiy
363dc19f9d
SimulcastToSvcConverter: Allow not setting scalability mode on frame
...
Bug: webrtc:347737882
Change-Id: I61e5a7a538bf43a9377fc9e3b8d399754232a2f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362081
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42983}
2024-09-09 13:33:52 +00:00
Danil Chapovalov
02113a2169
Pass Environment into RtcpReceiver
...
to avoid relying on the global field trials.
Bug: webrtc:362762208
Change-Id: I94e96f0a3f16cfd64f7deb4deb4aaa924ac1bba8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361865
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42982}
2024-09-09 11:36:29 +00:00
Artem Titov
3652dd30db
Review documentation and update review date
...
Bug: b/362492031, b/362492070, b/362492356, b/364207037, b/364831690
Change-Id: Ic889c731b98f8876c0ee31c0bda91a5a18b3add1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42981}
2024-09-09 11:21:55 +00:00
