254bd32188
This CL makes `requested_resolution`, which is the C++ name for what the spec calls scaleResolutionDownTo, align with the latest PR[1]. The PR says to ignore scaleResolutionDownBy when scaleResolutionDownTo is specified as to be backwards compatible with scaleResolutionDownBy's default scaling factors (e.g. 4:2:1). Ignoring is different than what the code does today which is to throw an InvalidModificationError. We don't want to throw or else get+setParameters() would throw by default due to 4:2:1 defaults so the app would have to remember to delete these attributes every time even though it never specified them (Chrome has a bug here but fixing that would expose this problem, see https://crbug.com/344943229). [1] https://github.com/w3c/webrtc-extensions/pull/221 Bug: none Change-Id: I21165c9b9f9ee7259d88b89f9ae58b862ea4521e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362260 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43002}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation