admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set MID in AudioReceiveChannel

Browse Source 
This variable was present but unset.

Bug: webrtc:360058654
Change-Id: I492069a1e87208c6fbb5ad5f0a00fcc2ccc0bc25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361824
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42988}
This commit is contained in:
Harald Alvestrand 2024-09-07 16:04:14 +00:00 committed by WebRTC LUCI CQ
parent 27db338658
commit 927244db7e
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
media/base/media_channel.h
View File

@ -828,6 +828,10 @@ struct RtcpParameters {
struct MediaChannelParameters {
virtual ~MediaChannelParameters() = default;
// This is the value to be sent in the MID RTP header extension (if the header
// extension in included in the list of extensions).
// It is also used as a key to map the channnel to its transport.
std::string mid;
std::vector<Codec> codecs;
std::vector<webrtc::RtpExtension> extensions;
@ -862,9 +866,6 @@ struct MediaChannelParameters {
struct SenderParameters : MediaChannelParameters {
int max_bandwidth_bps = -1;
// This is the value to be sent in the MID RTP header extension (if the header
// extension in included in the list of extensions).
std::string mid;
bool extmap_allow_mixed = false;
protected:

1
media/engine/webrtc_voice_engine.cc
View File

@ -2071,6 +2071,7 @@ bool WebRtcVoiceReceiveChannel::SetReceiverParameters(
<< params.ToString();
// TODO(pthatcher): Refactor this to be more clean now that we have
// all the information at once.
mid_ = params.mid;
if (!SetRecvCodecs(params.codecs)) {
return false;

1
pc/channel.cc
View File

@ -878,6 +878,7 @@ bool VoiceChannel::SetLocalContent_w(const MediaContentDescription* content,
content, header_extensions,
webrtc::RtpTransceiverDirectionHasRecv(content->direction()),
&recv_params);
recv_params.mid = mid();
if (!media_receive_channel()->SetReceiverParameters(recv_params)) {
error_desc = StringFormat(