c8c4a282a6
This CL introduces a new feature enabling video packet send batches. The feature is enabled via PeerConnectionInterface ::RTCConfiguration ::MediaConfig ::enable_send_packet_batching. PacketOptions have been augmented with attribute "batchable" (set for all video packets) and attribute "last_packet_in_batch" which gives injected AsyncPacketSockets a chance to understand when a batch begins and ends. When the feature is on, packets are collected in RtpSenderEgress. On reception of OnBatchComplete from PacingController, RtpSenderEgress sends the collected batch, setting "last_packet_in_batch" to true in the last packet. Bug: chromium:1439830 Change-Id: I1846b9d4a8a0efd227d617691213a2e048bdc8a2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303720 Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40012}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.