admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make PeerConnectionInterface::SetConfiguration pure virtual

Browse Source 
Bug: webrtc:10198
Change-Id: Ifc0dac72410b4f928e8e8aa2f2bc593005f39f87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267702
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37433}
This commit is contained in:
Niels Möller 2022-07-05 09:16:13 +02:00 committed by WebRTC LUCI CQ
parent b5b159d98c
commit 22a6253d43
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/peer_connection_interface.cc
View File

@ -41,11 +41,6 @@ PeerConnectionInterface::RTCConfiguration::RTCConfiguration(
PeerConnectionInterface::RTCConfiguration::~RTCConfiguration() = default;
RTCError PeerConnectionInterface::SetConfiguration(
const PeerConnectionInterface::RTCConfiguration& config) {
return RTCError();
}
PeerConnectionDependencies::PeerConnectionDependencies(
PeerConnectionObserver* observer_in)
: observer(observer_in) {}

5
api/peer_connection_interface.h
View File

@ -1106,11 +1106,8 @@ class RTC_EXPORT PeerConnectionInterface : public rtc::RefCountInterface {
// - SYNTAX_ERROR if parsing an ICE server URL failed.
// - INVALID_PARAMETER if a TURN server is missing `username` or `password`.
// - INTERNAL_ERROR if an unexpected error occurred.
//
// TODO(nisse): Make this pure virtual once all Chrome subclasses of
// PeerConnectionInterface implement it.
virtual RTCError SetConfiguration(
const PeerConnectionInterface::RTCConfiguration& config);
const PeerConnectionInterface::RTCConfiguration& config) = 0;
// Provides a remote candidate to the ICE Agent.
// A copy of the `candidate` will be created and added to the remote