From 22a6253d43a51b7eb057ddeb42ec9d7f7360988e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Tue, 5 Jul 2022 09:16:13 +0200 Subject: [PATCH] Make PeerConnectionInterface::SetConfiguration pure virtual MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10198 Change-Id: Ifc0dac72410b4f928e8e8aa2f2bc593005f39f87 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267702 Commit-Queue: Niels Moller Reviewed-by: Harald Alvestrand Reviewed-by: Henrik Boström Cr-Commit-Position: refs/heads/main@{#37433} --- api/peer_connection_interface.cc | 5 ----- api/peer_connection_interface.h | 5 +---- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/api/peer_connection_interface.cc b/api/peer_connection_interface.cc index 9f159ea731..d01d58d32b 100644 --- a/api/peer_connection_interface.cc +++ b/api/peer_connection_interface.cc @@ -41,11 +41,6 @@ PeerConnectionInterface::RTCConfiguration::RTCConfiguration( PeerConnectionInterface::RTCConfiguration::~RTCConfiguration() = default; -RTCError PeerConnectionInterface::SetConfiguration( - const PeerConnectionInterface::RTCConfiguration& config) { - return RTCError(); -} - PeerConnectionDependencies::PeerConnectionDependencies( PeerConnectionObserver* observer_in) : observer(observer_in) {} diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h index 54c4c46feb..373b7586de 100644 --- a/api/peer_connection_interface.h +++ b/api/peer_connection_interface.h @@ -1106,11 +1106,8 @@ class RTC_EXPORT PeerConnectionInterface : public rtc::RefCountInterface { // - SYNTAX_ERROR if parsing an ICE server URL failed. // - INVALID_PARAMETER if a TURN server is missing `username` or `password`. // - INTERNAL_ERROR if an unexpected error occurred. - // - // TODO(nisse): Make this pure virtual once all Chrome subclasses of - // PeerConnectionInterface implement it. virtual RTCError SetConfiguration( - const PeerConnectionInterface::RTCConfiguration& config); + const PeerConnectionInterface::RTCConfiguration& config) = 0; // Provides a remote candidate to the ICE Agent. // A copy of the `candidate` will be created and added to the remote