admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove obsolete header extension API names

Browse Source 
and update spec link.

BUG=chromium:1051821

Change-Id: I42dbe36b2299f01cb4eb8010c893623fde7472fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296702
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39548}
This commit is contained in:
Philipp Hancke 2023-03-08 16:45:02 +01:00 committed by WebRTC LUCI CQ
parent 54199f9b4b
commit 22005ab39b
2 changed files with 4 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
api/rtp_transceiver_interface.h
View File

@ -153,45 +153,20 @@ class RTC_EXPORT RtpTransceiverInterface : public rtc::RefCountInterface {
// with SetHeaderExtensionsToNegotiate, or a default set if it has not been
// called.
// https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface
// TODO(crbug.com/1051821): remove old name after Chromium roll, make pure
// virtual again.
virtual std::vector<RtpHeaderExtensionCapability>
GetHeaderExtensionsToNegotiate() const {
return {};
}
virtual std::vector<RtpHeaderExtensionCapability> HeaderExtensionsToOffer()
const {
return GetHeaderExtensionsToNegotiate();
}
GetHeaderExtensionsToNegotiate() const = 0;
// Returns either the empty set if negotation has not yet
// happened, or a vector of the negotiated header extensions.
// https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface
// TODO(crbug.com/1051821): remove old name after Chromium roll, make pure
// virtual again.
virtual std::vector<RtpHeaderExtensionCapability>
GetNegotiatedHeaderExtensions() const {
return {};
}
virtual std::vector<RtpHeaderExtensionCapability> HeaderExtensionsNegotiated()
const {
return GetNegotiatedHeaderExtensions();
}
GetNegotiatedHeaderExtensions() const = 0;
// The SetHeaderExtensionsToNegotiate method modifies the next SDP negotiation
// so that it negotiates use of header extensions which are not kStopped.
// https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface
// TODO(crbug.com/1051821): remove old name after Chromium roll, make pure
// virtual again.
virtual webrtc::RTCError SetHeaderExtensionsToNegotiate(
rtc::ArrayView<const RtpHeaderExtensionCapability> header_extensions) {
return RTCError::OK();
}
virtual webrtc::RTCError SetOfferedRtpHeaderExtensions(
rtc::ArrayView<const RtpHeaderExtensionCapability>
header_extensions_to_offer) {
return SetHeaderExtensionsToNegotiate(header_extensions_to_offer);
}
rtc::ArrayView<const RtpHeaderExtensionCapability> header_extensions) = 0;
protected:
~RtpTransceiverInterface() override = default;

2
pc/rtp_transceiver.cc
View File

@ -745,7 +745,7 @@ bool IsMandatoryHeaderExtension(const std::string& uri) {
RTCError RtpTransceiver::SetHeaderExtensionsToNegotiate(
rtc::ArrayView<const RtpHeaderExtensionCapability> header_extensions) {
// https://w3c.github.io/webrtc-extensions/#methods
// https://w3c.github.io/webrtc-extensions/#dom-rtcrtptransceiver-setheaderextensionstonegotiate
if (header_extensions.size() != header_extensions_to_negotiate_.size()) {
return RTCError(RTCErrorType::INVALID_MODIFICATION,
"Size of extensions to negotiate does not match.");