b140b9fd69
This is the same thing we're doing for usrsctp. Before this CL, the first SrtpSession to call SetKey would initialize libsrtp, and ChannelManager's destructor would deinitialize it. This works for an application that only uses one instance of ChannelManager simultaneously (or one instance of PeerConnectionFactory), but not one that uses multiple. Now, libsrtp is effectively reference-counted, with the first SrtpSession to take a reference initializing it, and the last to remove its reference deinitializing it. This issue was discovered recently due to a change that resulted in using srtp_update. Without using that method, the issue went unnoticed; maybe srtp_protect/srtp_unprotect don't require initialization? Bug: webrtc:8388 Change-Id: If1329360f0b469e454810e62e9b5acfbd4cba100 Reviewed-on: https://webrtc-review.googlesource.com/9000 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20262}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct