Taylor Brandstetter
b140b9fd69
Keep count of libsrtp clients, and only deinitialize when it goes to 0. ...
This is the same thing we're doing for usrsctp. Before this CL, the
first SrtpSession to call SetKey would initialize libsrtp, and
ChannelManager's destructor would deinitialize it. This works for an
application that only uses one instance of ChannelManager simultaneously
(or one instance of PeerConnectionFactory), but not one that uses
multiple.
Now, libsrtp is effectively reference-counted, with the first
SrtpSession to take a reference initializing it, and the last to remove
its reference deinitializing it.
This issue was discovered recently due to a change that resulted in
using srtp_update. Without using that method, the issue went unnoticed;
maybe srtp_protect/srtp_unprotect don't require initialization?
Bug: webrtc:8388
Change-Id: If1329360f0b469e454810e62e9b5acfbd4cba100
Reviewed-on: https://webrtc-review.googlesource.com/9000
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20262}
2017-10-13 05:11:27 +00:00
2017-10-10 17:06:00 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-06 13:00:14 +00:00
2017-09-15 05:02:56 +00:00
2017-10-11 11:48:54 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-26 18:12:45 +00:00
2017-10-05 04:41:55 +00:00
2017-10-06 18:50:24 +00:00
2017-09-29 18:20:07 +00:00
2017-10-13 05:11:27 +00:00
2017-09-29 12:39:09 +00:00
2017-09-27 14:41:46 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 12:51:00 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-05 13:51:21 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-04 02:32:06 +00:00
2017-10-04 02:13:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-06 13:00:14 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-06 18:50:24 +00:00
2017-10-11 07:45:29 +00:00
2017-10-10 17:06:00 +00:00
2017-10-11 07:45:29 +00:00
2017-10-11 07:45:29 +00:00
2017-10-11 11:48:54 +00:00
2017-09-15 12:51:00 +00:00
2017-10-11 07:45:29 +00:00
2017-10-06 15:18:24 +00:00
2017-10-11 17:34:17 +00:00
2017-10-06 17:42:24 +00:00
2017-10-06 17:42:24 +00:00
2017-09-15 12:51:00 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-02 10:47:00 +00:00
2017-10-02 17:16:09 +00:00
2017-10-05 13:51:21 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-29 18:20:07 +00:00
2017-09-15 05:02:56 +00:00
2017-09-26 18:12:45 +00:00
2017-09-26 18:12:45 +00:00
2017-09-26 18:12:45 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-06 17:42:24 +00:00
2017-10-06 17:42:24 +00:00
2017-09-26 18:12:45 +00:00
2017-10-13 05:11:27 +00:00
2017-10-13 05:11:27 +00:00
2017-09-15 05:02:56 +00:00
2017-10-13 05:11:27 +00:00
2017-10-13 05:11:27 +00:00
2017-09-15 05:02:56 +00:00
2017-09-26 18:12:45 +00:00
2017-09-26 18:12:45 +00:00
2017-09-26 18:12:45 +00:00
2017-10-02 17:16:09 +00:00
2017-10-02 17:16:09 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-29 18:20:07 +00:00
2017-09-29 18:20:07 +00:00
2017-10-05 13:51:21 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-10-06 13:00:14 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
2017-09-16 08:24:29 +00:00
2017-10-05 13:51:21 +00:00
2017-09-15 05:02:56 +00:00
2017-10-06 18:50:24 +00:00
2017-10-06 18:50:24 +00:00
2017-10-06 18:50:24 +00:00
2017-09-15 05:02:56 +00:00
2017-09-15 05:02:56 +00:00
b140b9fd69