admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss.

Browse Source 
It's been disabled on Linux and Mac already, but appears to be flaky
regardless of platform; flakes have been observed on Android and
Windows as well.

TBR=stefan@webrtc.org
NOTRY=True

Bug: webrtc:7919
Change-Id: I193f6836fa3ad3928ed7ac05ade4504fa5e37442
Reviewed-on: https://webrtc-review.googlesource.com/8240
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20230}
This commit is contained in:
Taylor Brandstetter 2017-10-10 12:12:53 -07:00 committed by Commit Bot
parent 03967cd7bf
commit 05d9822e55
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
call/rampup_tests.cc
View File

@ -584,15 +584,9 @@ TEST_F(RampUpTest, UpDownUpTransportSequenceNumberRtx) {
// TODO(holmer): Tests which don't report perf stats should be moved to a
// different executable since they per definition are not perf tests.
// Crashes on Linux only, see webrtc:7919.
#if defined(WEBRTC_LINUX) || defined(WEBRTC_MAC)
#define MAYBE_UpDownUpTransportSequenceNumberPacketLoss \
DISABLED_UpDownUpTransportSequenceNumberPacketLoss
#else
#define MAYBE_UpDownUpTransportSequenceNumberPacketLoss \
UpDownUpTransportSequenceNumberPacketLoss
#endif
TEST_F(RampUpTest, MAYBE_UpDownUpTransportSequenceNumberPacketLoss) {
// This test is disabled because it crashes on Linux, and is flaky on other
// platforms. See: crbug.com/webrtc/7919
TEST_F(RampUpTest, DISABLED_UpDownUpTransportSequenceNumberPacketLoss) {
std::vector<int> loss_rates = {20, 0, 0, 0};
RampUpDownUpTester test(1, 0, 1, kStartBitrateBps,
RtpExtension::kTransportSequenceNumberUri, true,