From 05d9822e55a10cda0d7c80aafb1cd1c671977316 Mon Sep 17 00:00:00 2001 From: Taylor Brandstetter Date: Tue, 10 Oct 2017 12:12:53 -0700 Subject: [PATCH] Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss. It's been disabled on Linux and Mac already, but appears to be flaky regardless of platform; flakes have been observed on Android and Windows as well. TBR=stefan@webrtc.org NOTRY=True Bug: webrtc:7919 Change-Id: I193f6836fa3ad3928ed7ac05ade4504fa5e37442 Reviewed-on: https://webrtc-review.googlesource.com/8240 Reviewed-by: Taylor Brandstetter Commit-Queue: Taylor Brandstetter Cr-Commit-Position: refs/heads/master@{#20230} --- call/rampup_tests.cc | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/call/rampup_tests.cc b/call/rampup_tests.cc index 0ade0008c1..85346b7479 100644 --- a/call/rampup_tests.cc +++ b/call/rampup_tests.cc @@ -584,15 +584,9 @@ TEST_F(RampUpTest, UpDownUpTransportSequenceNumberRtx) { // TODO(holmer): Tests which don't report perf stats should be moved to a // different executable since they per definition are not perf tests. -// Crashes on Linux only, see webrtc:7919. -#if defined(WEBRTC_LINUX) || defined(WEBRTC_MAC) -#define MAYBE_UpDownUpTransportSequenceNumberPacketLoss \ - DISABLED_UpDownUpTransportSequenceNumberPacketLoss -#else -#define MAYBE_UpDownUpTransportSequenceNumberPacketLoss \ - UpDownUpTransportSequenceNumberPacketLoss -#endif -TEST_F(RampUpTest, MAYBE_UpDownUpTransportSequenceNumberPacketLoss) { +// This test is disabled because it crashes on Linux, and is flaky on other +// platforms. See: crbug.com/webrtc/7919 +TEST_F(RampUpTest, DISABLED_UpDownUpTransportSequenceNumberPacketLoss) { std::vector loss_rates = {20, 0, 0, 0}; RampUpDownUpTester test(1, 0, 1, kStartBitrateBps, RtpExtension::kTransportSequenceNumberUri, true,