301e546a68
As pointed out in issue webrtc:15146 this Mac/iOS specific variable, makes the SequenceChecker behave incorrectly on those platforms. The variable was introduced in a CL that merged the previous checker classes, ThreadChecker and SequencedTaskChecker, but curiously neither one of them had such a variable. So I'm not exactly sure what problem was being solved. Hence I'm wondering if we actually need it. Reference: https://webrtc-review.googlesource.com/c/src/+/129721 Bug: webrtc:15146 Change-Id: Ia7a9eb17b993c4f8a1e8204c658bf0b3dbdaa1e0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304401 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40019}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.