9a5de95af9
The goal of the VP9 simulcast project is that when `scalability_mode` is set, multiple encodings are always interpreted as simulcast, even if VP9 or AV1 is used. This CL makes this so, but only if the flag "WebRTC-AllowDisablingLegacyScalability" is "/Enabled/". This allows us to make "SendingThreeEncodings_VP9_Simulcast" EXPECT VP9 simulcast. When we are ready to ship we will remove the need to use the field trial, but before we ship this we'll want to revisit if SvcRateAllocator can be updated to support simulcast. (Today if we use SvcRateAllocator when VP9 simulcast is used, all encodings except the first one get bitrate=0, causing the test to fail because media is not flowing on all layers.) For now, a TODO is added. Bug: webrtc:14884 Change-Id: Ie20ae748b0c0405162f3a1b015ab94956ef83dae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297340 Reviewed-by: Evan Shrubsole <eshr@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39552}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.