2057d71775
NonStandardGroupId is no longer wired up to Chrome, but if we did want to only expose certain metrics if a field trial was enabled then the right place to do that would be in blink, where WebIDL lives. This was only used prior to the WebRtcStatsReportIdl launch and experiments haven't been active in several years so its dead code. Blocked on: - https://chromium-review.googlesource.com/c/chromium/src/+/4514754 Bug: webrtc:15162 Change-Id: Ia41a4d21d7e5f029ddb121183fbd69ae7f98fac4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304720 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40132}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.