Tony Herre c381c33767 Make TransformableVideoFrameInterface::SetMetadata pure virtual
Bug: webrtc:14709
Change-Id: I9e131a041e80c1774b982f61197a0499b97c6ae7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301162
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Auto-Submit: Tony Herre <herre@google.com>
Reviewed-by: Stefan Holmer <holmer@google.com>
Cr-Commit-Position: refs/heads/main@{#39845}
2023-04-13 11:23:16 +00:00
..
2022-10-08 08:38:36 +00:00
2023-02-24 11:48:39 +00:00
2023-04-13 08:49:37 +00:00
2023-04-13 08:49:37 +00:00
2022-11-29 17:04:11 +00:00
2023-03-27 17:06:33 +00:00

How to write code in the api/ directory

Mostly, just follow the regular style guide, but:

  • Note that api/ code is not exempt from the “.h and .cc files come in pairs” rule, so if you declare something in api/path/to/foo.h, it should be defined in api/path/to/foo.cc.
  • Headers in api/ should, if possible, not #include headers outside api/. Its not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that were trying to shrink.
  • .cc files in api/, on the other hand, are free to #include headers outside api/.

That is, the preferred way for api/ code to access non-api/ code is to call it from a .cc file, so that users of our API headers wont transitively #include non-public headers.

For headers in api/ that need to refer to non-public types, forward declarations are often a lesser evil than including non-public header files. The usual rules still apply, though.

.cc files in api/ should preferably be kept reasonably small. If a substantial implementation is needed, consider putting it with our non-public code, and just call it from the api/ .cc file.