Florent Castelli
ccec7e2042
Fix OpenSSL builds
...
BoringSSL includes cannot be included in an OpenSSL build.
Links the SSL related target against the crypto and ssl libs
the proper way.
Bug: None
Change-Id: I4252e6207815d7d7e35bb8d4d966e3d1b83e659d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358941
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42754}
2024-08-09 14:58:10 +00:00
Philipp Hancke
486aa857b5
Add SHA224 and SHA256 HMAC tests to message digest
...
SHA384 and SHA512 are not yet tested since our (custom)
HMAC code does not support those algorithms and rejects a block size.
Note that this is only used for computing TURN MD5 and STUN SHA1 HMACs
BUG=None
Change-Id: Idabc651d988a5e5f3abd1fad0f36726bcc7a69a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358780
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42753}
2024-08-09 14:44:45 +00:00
Hanna Silen
cc5c549fac
Deprecate TransientSuppression
...
APM transient suppression config has no impact after
https://webrtc-review.googlesource.com/c/src/+/355880 .
Bug: webrtc:7494, webrtc:13663, webrtc:357281131
Change-Id: I5017995aad4f89108b7de46e58df1cd391f61734
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358865
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Hanna Silen <silen@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42752}
2024-08-09 14:03:24 +00:00
Mirko Bonadei
6cb7b3a424
Reland "Remove jni_zero type aliases in jni_generator_helper.h."
...
This is a reland of commit 9fcaa034bc032da9de5d6fcdd45528169f44d343
Original change's description:
> Remove jni_zero type aliases in jni_generator_helper.h.
>
> This CL removes some type alias from
> sdk/android/src/jni/jni_generator_helper.h and make sure all the
> jni_zero types are referred to using the jni_zero:: namespace.
>
> The goal is to remove sdk/android/src/jni/jni_generator_helper.h
> in future CLs.
>
> Bug: b/319078685, b/351773023
> Change-Id: Ief60fce3e8f301f09ac5392d143aa5a82a445bcb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/356882
> Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42618}
No-Presubmit: True
Bug: b/319078685, b/351773023
Change-Id: I605a726788ee84efdbdc9e75098b404cbd7c1f30
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358922
Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42751}
2024-08-09 11:35:32 +00:00
webrtc-version-updater
e854cb2af3
Update WebRTC code version (2024-08-09T04:07:32).
...
Bug: None
Change-Id: I28ead13e11366a785396bfe1e4de9a046367481f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358963
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42750}
2024-08-09 05:37:36 +00:00
chromium-webrtc-autoroll
dc3173da5f
Roll chromium_revision 6f9b3224db..af7f3f9345 (1338914:1339036)
...
Change log: 6f9b3224db..af7f3f93456f9b3224db..af7f3f9345f092508cc2..b8c2232900a0e5713502..f513056e19a603c11cfa..cd805e94ec7605e1a3e3..f8da9e037e49b13d9832..8759cb0df36db1ccfa71..116c20dae626643fc4e9..8c29d5e1fe1487e03fbb..2dc218958f6f9b3224db..af7f3f9345https://webrtc-review.googlesource.com/c/src/+/358901
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42749}
2024-08-08 15:28:25 +00:00
Danil Chapovalov
0c4c4e6070
Provide Environment to create NetEq in tests
...
Bug: webrtc:356878416
Change-Id: I1d01c61ad6822fb018873fed949154f72b90a11b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358920
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42748}
2024-08-08 13:45:59 +00:00
Abby Yeh
cae0aeb2b6
Implement MuteMicrophone to enable muted speech listener on iOS 15 and 16.
...
Bug: webrtc:15233
Change-Id: I73e553f0c0a2258941d75b35d2475168c99ceba2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358723
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Abby Yeh <abbyyeh@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42747}
2024-08-08 12:44:10 +00:00
Jakob Ivarsson
723ea45075
Cleanup NetEq decision logic field trial.
...
Bug: webrtc:42223518
Change-Id: I2e5064109b9f0358e8e590e4aae6ebeb9d16bc3e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358861
Reviewed-by: Tomas Lundqvist <tomasl@google.com>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42746}
2024-08-08 11:48:11 +00:00
Markus Handell
e864dec2e9
VSyncEncodeAdapterMode: avoid UAF.
...
This CL fixes a problem where VSEAM's `queue_` was dereferenced
post destruction. A sequence triggering it is:
0. FrameCadenceAdapter (FCA) is configured with Metronome with >= 34 ms tick delay.
1. A frame is queued for processing on worker queue.
2. The FCA is destroyed. The contained VSyncEncodeAdapterMode instance is scheduled for deletion on worker queue.
3. Encode queue is destroyed.
4. Worker queue is executed, which runs a task that dereferences `queue_`.
Bug: chromium:356423094
Change-Id: Iae8dc070304ef5ec0cfb0b4f27bbb7fe86e7def7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358660
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42745}
2024-08-08 11:02:50 +00:00
Mirko Bonadei
07e83f244b
Roll chromium_revision ba1ae79f58..6f9b3224db (1319128:1338914)
...
Change log: ba1ae79f58..6f9b3224dbba1ae79f58..6f9b3224dbaa6dbe6d6a..f092508cc25bce81deee..a0e571350294d7b86a83..19268125549e33110a5d..a603c11cfaa1b47952f3..7605e1a3e391945cadc2..49b13d983276788faa4e..1420017c7fhttps://chromium.googlesource.com/catapult.git/+log/022cd349fe..2feeb46c60
* src/third_party/dav1d/libdav1d: 92f592ed10..2355eeb8f2f1c7c96958..75932421dad941d9677b..67060f141b6ede1ccc9e..fb9afbafc773720c7c99..ec378cecaf1d17ea141d..ff233bdd4c163e29159e..9408c6fd4ahttps://aomedia.googlesource.com/aom.git/+log/afedaf9da5..d8ef6563e0
* src/third_party/libc++/src: 09b99fd8ab..7993b2fda2bac941ca44..eb6567388edcc1ffafb5..6db1ccfa71253d6365e3..428f3104fa09a4f3ec84..478e5ab3ecf9098afffa..26643fc4e96144b62bec..6dcd83d60fa8fe86b922..1487e03fbbba1ae79f58..6f9b3224dbba1ae79f58..6f9b3224dbhttps://webrtc-review.googlesource.com/c/src/+/358880
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42744}
2024-08-08 09:20:02 +00:00
webrtc-version-updater
c252093146
Update WebRTC code version (2024-08-08T04:02:48).
...
Bug: None
Change-Id: If2058efa35b674616894287a28700c3c32120976
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358840
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42743}
2024-08-08 06:16:44 +00:00
Dor Hen
ec5a968070
Apply include-cleaner to api/transport
...
Bug: webrtc:42226242
Change-Id: I41fe8dcb2f68b1f05c70058fee527f4cae67c51b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358502
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#42742}
2024-08-07 16:09:45 +00:00
Ranveer Aggarwal
c7e2568457
Optionally overwrite instead of queueing render updates.
...
Here, we overwrite the pending frames per renderer.
Bug: webrtc:351858995
Change-Id: I070219aec4e7be5f2b0c9f2371fe2c99af3e3920
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358760
Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Fabian Bergmark <fabianbergmark@google.com>
Commit-Queue: Zoé Lepaul <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42741}
2024-08-07 13:36:39 +00:00
Xinyu Ma
675986ec5f
Pass Environment into UlpfecGenerator
...
To make it available for FEC to use field trials in follow ups
Bug: webrtc:355577231
Change-Id: I4a6260a38e50a70dae27db28401b08bf0160aaec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358680
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42740}
2024-08-07 12:39:20 +00:00
Danil Chapovalov
e1dbddfbcf
Introduce NetEqFactory::Create taking Environment instead of the Clock
...
To propagate field trials into the NetEq and further towards Audio Decoders
Bug: webrtc:356878416
Change-Id: Ia7cf18451aef70441ca958bf652f492138c6051a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358620
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42739}
2024-08-07 10:54:38 +00:00
Yingying Ma
9847885240
Mark GenericFrameInfo as an exported symbol
...
Currently, webrtc can only simulate the GenericDescriptorInfo
based on codec specific info when uses HW encode acceleration.
To provide more accurate description, RTCVideoEncoder in the
chromium blink module needs to fill the generic frame info and
GenericFrameInfo should be marked as exported to chromium.
Bug: chromium:40275246
Change-Id: I34c2747ab32cfdb1be13ae3b1635242f18462de7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323063
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42738}
2024-08-07 10:21:30 +00:00
Mirko Bonadei
b1b6129944
Revert "Each spatial layer can only have 1 QP value."
...
This reverts commit 962b3935e44053641764beb0bd095540fe8cbd64.
Reason for revert: Breaks downstream tests.
Original change's description:
> Each spatial layer can only have 1 QP value.
>
> As the code is now, it looks like it accepts that a spatial layer can have more than 1 QP value. These QP values according to the code are summed. However, to my best knowledge this cannot be the case and makes the code hard to read. Therefore, updating it with a check such that it checks that each spatial layer only have 1 QP value and would be easier for a future code reader.
>
> Bug: webrtc:357636606
> Change-Id: I650cac724811a1ddc7ab8933c1e1ac5fe844b61c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358101
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
> Cr-Commit-Position: refs/heads/main@{#42736}
Bug: webrtc:357636606
Change-Id: I60a2d4e1285f961f2ed2ea4c1d2e5942ea68b365
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358721
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42737}
2024-08-07 08:42:20 +00:00
Emil Vardar
962b3935e4
Each spatial layer can only have 1 QP value.
...
As the code is now, it looks like it accepts that a spatial layer can have more than 1 QP value. These QP values according to the code are summed. However, to my best knowledge this cannot be the case and makes the code hard to read. Therefore, updating it with a check such that it checks that each spatial layer only have 1 QP value and would be easier for a future code reader.
Bug: webrtc:357636606
Change-Id: I650cac724811a1ddc7ab8933c1e1ac5fe844b61c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358101
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Cr-Commit-Position: refs/heads/main@{#42736}
2024-08-07 07:59:22 +00:00
Mirko Bonadei
a8dd3a36fa
Add missing dependency.
...
Bug: None
Change-Id: I864ee21709f1e7e4622c4f4717eab2de64cf64b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358640
Commit-Queue: Christoffer Dewerin <jansson@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42735}
2024-08-07 07:00:06 +00:00
webrtc-version-updater
f3ffcacbb0
Update WebRTC code version (2024-08-07T04:07:42).
...
Bug: None
Change-Id: Ib907038ce33bfd850e2377ae89bfb7b929df8e8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358700
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42734}
2024-08-07 06:17:05 +00:00
Dan Tan
2406aaf475
Add accounting of actual audio bit usage
...
Part of a set of CL to allow video to borrow underused audio bitrate.
Bug: webrtc:35055527
Change-Id: Idb504cbbc5794c06b28bdc21b3d860c9da9df175
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358202
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Dan Tan <dwtan@google.com>
Cr-Commit-Position: refs/heads/main@{#42733}
2024-08-06 18:04:46 +00:00
Xinyu Ma
075349f039
Pass Environment into FlexfecSender
...
To make it available for FEC to use field trials in follow ups
Bug: webrtc:355577231
Change-Id: Ie0b7761915696e6ee7453df3d0531b0f7ad30ee1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358240
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42732}
2024-08-06 17:10:12 +00:00
Danil Chapovalov
3b0424bc41
Delete deprecated AcmReceiver contstructor
...
Bug: webrtc:356878416
Change-Id: Ic7e444e7f35c6927722a61f2f9ba6042cf10002f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358600
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42731}
2024-08-06 15:41:13 +00:00
Mirko Bonadei
843e14b36a
Temporarily skip iOS simulator from CQ and LKGR.
...
Bug: b/357552398
Change-Id: I212dde3487d89961c4f923de9e11f5231b9ee8e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358601
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Dewerin <jansson@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42730}
2024-08-06 14:22:13 +00:00
Dor Hen
5ac2c74022
Apply include-cleaner to api/task_queue
...
Bug: webrtc:42226242
Change-Id: Ieee3dddf72eb8ecea699be87f05a59036670f3d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358500
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#42729}
2024-08-06 13:32:04 +00:00
Danil Chapovalov
33582ea42f
Pass Environment instead of just clock to AcmReceiver at construction
...
Passing Environment would allow to propage field trials with it further to NetEq and AudioDecoders
Bug: webrtc:356878416
Change-Id: Ic68420df3b157ed341146207a2c45cb49e59a931
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358501
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42728}
2024-08-06 08:28:23 +00:00
webrtc-version-updater
dc58bba2ed
Update WebRTC code version (2024-08-06T04:05:19).
...
Bug: None
Change-Id: I261134219ad691dd288e752a9d7d7817d4fd7339
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358560
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42727}
2024-08-06 06:13:16 +00:00
Sun Shin
303113a620
Enable rtc::Socket::OPT_RECV_ECN socket option
...
Enable rtc::Socket::OPT_RECV_ECN socket option by field trial
WebRTC-RFC8888CongestionControlFeedback.
Bug: webrtc:15368
Change-Id: I9befbbb59745c0fc9528bf948ad2cfc90efe226b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357920
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42726}
2024-08-06 01:10:42 +00:00
Florent Castelli
916bf2f260
Remove usage of old copy of rtp_packet_sender.h
...
Bug: chromium:345101934
Change-Id: I9123dbd39f5d1e34dd1874b840ab6f34f34849a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357863
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42725}
2024-08-05 13:09:18 +00:00
Hanna Silen
90c430cda4
AudioProcessingImpl: Remove the use of transient suppressor
...
Remove the use of transient suppression, i.e.:
- Transient suppressor submodule (ignore the config),
- WebRTC-TransientSuppressorForcedOff fieldtrial,
- Voice activity detection submodule (use AGC2/AGC VAD instead),
- Submodule overrides, and
- WEBRTC_EXCLUDE_TRANSIENT_SUPPRESSOR macro.
Bug: webrtc:7494, webrtc:13663, webrtc:357281131
Change-Id: I7edb46c7ff048992ac5a10473800405bad268895
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/355880
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Hanna Silen <silen@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42724}
2024-08-05 12:38:37 +00:00
Harald Alvestrand
53c424eba7
Apply include-cleaner to the SSL files
...
Bug: webrtc:42226242
Change-Id: I04acc5aa4c76af4e900d7a7b50129cee9c9c3137
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358180
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42723}
2024-08-03 08:47:17 +00:00
webrtc-version-updater
4da4b48a8e
Update WebRTC code version (2024-08-03T04:02:54).
...
Bug: None
Change-Id: If7ed4133639829699a6bb35c4b438e691c39b1d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358342
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42722}
2024-08-03 06:11:28 +00:00
Harald Alvestrand
4849eb8a3f
Fix OpenSSL build
...
Bug: None
Change-Id: I0577e0b32dc738da567e1d7a8b3e265a7c2bba89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358401
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42721}
2024-08-02 16:22:39 +00:00
Philipp Hancke
b2ce406053
Fix unit test build with OpenSSL and fix gn check failure
...
follow-up to
https://webrtc-review.googlesource.com/c/src/+/358300
which links the unit tests against OpenSSL when building with that by using
rtc_build_ssl = false
rtc_ssl_root = "/usr/include/openssl"
as gn args which showed an additional gn check failure
BUG=None
Change-Id: Id3356f3e211509141f2a05f096f19a7b1b8eee9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358340
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42720}
2024-08-02 12:16:53 +00:00
Danil Chapovalov
3732b84c17
Pass Clock and RtcEventLog as Environment into AudioReceiveStream
...
To make Environment available for creating AudioDecoders to use propagated field trials
Bug: webrtc:356878416
Change-Id: I5dc4a3514d1182db6a7a5aa770b87daba529a5c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357442
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42719}
2024-08-02 11:58:23 +00:00
Danil Chapovalov
943828b7ff
Pass Clock and TaskQueueFactory as Environment in voip audio channel
...
To make Environment available for creating AudioDecoders to use propagated field trials
Bug: webrtc:356878416
Change-Id: Ic2371f038b75402bbd007c948f43c60cc6cca8a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358400
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42718}
2024-08-02 10:16:09 +00:00
Lionel Koenig Gélas
b4462510c3
Pass receive_time through frame transformer
...
Bug: webrtc:344347965
Change-Id: Iee5ae13487f57f2b0c98dd6fb6a14286ff317fbb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358100
Reviewed-by: Tony Herre <herre@google.com>
Commit-Queue: Lionel Koenig <lionelk@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42717}
2024-08-02 07:01:33 +00:00
webrtc-version-updater
6f8c9afe34
Update WebRTC code version (2024-08-02T04:02:56).
...
Bug: None
Change-Id: Ifafe1aa4a1a83dec53459fb3e05e039a5be02e06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358341
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42716}
2024-08-02 06:00:49 +00:00
Florent Castelli
c427c1723d
Make PriorityValue constructor explicit
...
Bug: webrtc:42225365
Change-Id: I8d0e6cf0f2d6f5677cb10e4b5ea32121dab733bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358301
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42715}
2024-08-01 18:18:04 +00:00
Harald Alvestrand
7079843bc8
Fix some gratuitous compile failures under OpenSSL
...
To test:
- ensure openssl files live in /usr/include/openssl
- make a config with the following values:
```
rtc_build_ssl = false
rtc_ssl_root = "/usr/include/openssl
```
- compile rtc_unittests
There will be link errors, but no compile errors.
Bug: None
Change-Id: I3d28b1613e11a716b11c7def808100ef58ab75f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358300
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42714}
2024-08-01 17:27:09 +00:00
Philipp Hancke
5d6fa7d2fc
Split SSLAdapter/SSLStreamAdapter and deprecate SSL(Stream)Adapter::SetMode
...
since we do not need two adapters with TLS and DTLS modes.
SSLAdapter is the TLS adapter,
SSLStreamAdapter is the DTLS adapter.
BUG=webrtc:353750117
Change-Id: I223917c71c88437339380e1f196dcf3c0e2021c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/354940
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42713}
2024-08-01 17:00:02 +00:00
Florent Castelli
7c793a7dbe
Fix iOS builds
...
See error in: https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20ios-device/17610/overview
Bug: None
Change-Id: I95c918e788b23352467be2796d72594ae9354fa2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358302
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42712}
2024-08-01 16:17:09 +00:00
Jeremy Leconte
53291d49b2
Add 'SkipNextFrame' to the FrameGeneratorInterface.
...
Also fix PRESUBMIT.py following https://webrtc-review.googlesource.com/c/src/+/358160 .
Change-Id: I00682209607a184448255cf5ad8fd213fda7f4af
Bug: b/355120692
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358320
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42711}
2024-08-01 14:38:52 +00:00
Jeremy Leconte
d02a216026
Revert "Reland "Add a dependancy on //third_party/jni_zero:jni_zero_java""
...
This reverts commit e19a9b37ce477f867524dfb802cca556630a7fac.
Reason for revert: break downstream
Original change's description:
> Reland "Add a dependancy on //third_party/jni_zero:jni_zero_java"
>
> This is a reland of commit 5ccec98826adc84bdb4c8177580a6f23074d8058
>
> Original change's description:
> > Add a dependancy on //third_party/jni_zero:jni_zero_java
> >
> > JniZero's native side expects JniZero's java side to exist, add a
> > dependancy on //third_party/jni_zero:jni_zero_java from
> > sdk/android:base_java.
> >
> > Bug: webrtc:353174456
> > Change-Id: I9240eab3da78efd394e4ee581cf71fd41976eb48
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357200
> > Commit-Queue: Mohamed Heikal <mheikal@google.com>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Auto-Submit: Mohamed Heikal <mheikal@google.com>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#42639}
>
> Bug: webrtc:353174456, b/325408567
> Change-Id: Ib51939cc6494e867e8018c7d163c85f36b80199b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358260
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42709}
Bug: webrtc:353174456, b/325408567
Change-Id: I2eb497d8a308485142f6e197e8e41928e2ae6f25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358280
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Owners-Override: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42710}
2024-08-01 09:30:27 +00:00
Mohamed
e19a9b37ce
Reland "Add a dependancy on //third_party/jni_zero:jni_zero_java"
...
This is a reland of commit 5ccec98826adc84bdb4c8177580a6f23074d8058
Original change's description:
> Add a dependancy on //third_party/jni_zero:jni_zero_java
>
> JniZero's native side expects JniZero's java side to exist, add a
> dependancy on //third_party/jni_zero:jni_zero_java from
> sdk/android:base_java.
>
> Bug: webrtc:353174456
> Change-Id: I9240eab3da78efd394e4ee581cf71fd41976eb48
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357200
> Commit-Queue: Mohamed Heikal <mheikal@google.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Auto-Submit: Mohamed Heikal <mheikal@google.com>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42639}
Bug: webrtc:353174456, b/325408567
Change-Id: Ib51939cc6494e867e8018c7d163c85f36b80199b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358260
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42709}
2024-08-01 09:00:04 +00:00
Qiu Jianlin
fd98638726
Check empty slice in H.265 bitstream parser.
...
This is cherry-picked from WebKit's PR by youenn@apple.com . The original
PR: https://github.com/WebKit/WebKit/pull/31525
Bug: chromium:41480904
Change-Id: I69c7c8d5842a576fa18432fb9f85c6890b47f3ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358200
Commit-Queue: Jianlin Qiu <jianlin.qiu@intel.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42708}
2024-08-01 08:57:39 +00:00
webrtc-version-updater
c7eacf81f2
Update WebRTC code version (2024-08-01T04:03:51).
...
Bug: None
Change-Id: I3b5d56ddce83c51017bf59e5537056fcfea16058
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358201
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42707}
2024-08-01 06:22:01 +00:00
Jan Grulich
9e755f0e19
PipeWire camera: Annotate functions with PipeWire calls to avoid CFI
...
Similar to PipeWire implementation of desktop capture, we have to avoid
CFI check for calls of dlopened PipeWire library. This avoid crashing
PipeWire camera backend when "is_official_build=true" option is used as
this turns on "is_cfi=true" enabling control flow integrity.
Bug: chromium:354776214
Change-Id: I7a9fc1c2d77c4ee0e8fe0586369b7246e0bb9180
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358103
Commit-Queue: Jan Grulich <grulja@gmail.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#42706}
2024-07-31 18:11:40 +00:00
Xinyu Ma
954fdb0c31
Pass Environment into RtpVideoSender
...
To make it available for FEC to use field trials in follow ups
Bug: webrtc:355577231
Change-Id: Id176d1320ef1c8b9a7243ebafb6986bd436d32d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357842
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42705}
2024-07-31 17:36:08 +00:00
