admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
19,175 Commits 1 Branch 0 Tags
Commit Graph

19175 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Niels Möller
b0573bca16 Reorganize config of RTP header extensions for video receive streams. 
Bug: webrtc:6847
Change-Id: Iae2386e55520601883379fc7802a5c5246be935e
Reviewed-on: https://webrtc-review.googlesource.com/2001
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19943}
 2017-09-25 11:51:20 +00:00
Kári Tristan Helgason
0bf6071c04 Remove internal methods from global namespace. 
It's rude to clobber our consumers global namespace.

Bug: None
Change-Id: If8073820fcae6399def1717775fa64bc6e20051c
Reviewed-on: https://webrtc-review.googlesource.com/3165
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19942}
 2017-09-25 11:05:10 +00:00
Henrik Lundin
ac0a503828 NetEq/Stats: Don't let concealed_samples decrease 
When NetEq performs a merge operation, it will usually have to correct
the stats for number of concealment samples produced, sometimes with
decreasing it.

This does not make sense in the context of the stats spec, and
stats-consuming applications may not be prepared for it. With this
change, only positive corrections are allowed for the
concealed_samples value. This will sometimes lead to a small positive
bias, but it will be negligible over time.

Bug: webrtc:8253
Change-Id: Ie9de311ab16401f1a4b435f6269725901b8cf561
Reviewed-on: https://webrtc-review.googlesource.com/1583
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19941}
 2017-09-25 10:53:50 +00:00
Autoroller
b4aeb5bb9b Roll chromium_revision 300d540fe1..533744aa77 (503992:504014) 
Change log: 300d540fe1..533744aa77
Full diff: 300d540fe1..533744aa77

Changed dependencies:
* src/ios: 7d85e4e68a..a9b189f61d
* src/third_party: 71913f63d3..1a0d9f104b
* src/tools: 4206aaf7d2..d37af930bf
DEPS diff: 300d540fe1..533744aa77/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I4b7fa8c24a00294b9b56bd44a4759f66028606a3
Reviewed-on: https://webrtc-review.googlesource.com/3220
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19940}
 2017-09-25 10:18:10 +00:00
Oleh Prypin
5ab6854919 Revert "Remove remaining mentions of gflags" 
This reverts commit 90ce84e1d3201103823a6c615ccbed9e84b1c2c4.

Reason for revert: Compilation failure on webrtc.fyi
(error: no member named 'GetLogToDebug' in 'rtc::LogMessage')

Original change's description:
> Remove remaining mentions of gflags
> 
> Bug: webrtc:7644
> Change-Id: I1906419e597fe6f80247e8def78c958f3759ba00
> Reviewed-on: https://webrtc-review.googlesource.com/2687
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19938}

TBR=kjellander@webrtc.org,oprypin@webrtc.org

Change-Id: I0e4c7191a405e45c85d007bc385bee5de5b4d323
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7644
Reviewed-on: https://webrtc-review.googlesource.com/3200
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19939}
 2017-09-25 09:18:11 +00:00
Oleh Prypin
90ce84e1d3 Remove remaining mentions of gflags 
Bug: webrtc:7644
Change-Id: I1906419e597fe6f80247e8def78c958f3759ba00
Reviewed-on: https://webrtc-review.googlesource.com/2687
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19938}
 2017-09-25 09:08:23 +00:00
Autoroller
5c53641b51 Roll chromium_revision 7877db2873..300d540fe1 (503976:503992) 
Change log: 7877db2873..300d540fe1
Full diff: 7877db2873..300d540fe1

Changed dependencies:
* src/third_party: a80ea7a808..71913f63d3
* src/third_party/catapult: fdacc64db0..a8018a6284
* src/tools: f8a62e9f22..4206aaf7d2
DEPS diff: 7877db2873..300d540fe1/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ie0aee1e1fff54619c1313dedf2f9620015a3a88e
Reviewed-on: https://webrtc-review.googlesource.com/3140
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19937}
 2017-09-25 07:17:07 +00:00
Autoroller
d93ffb012b Roll chromium_revision c91bb42405..7877db2873 (503967:503976) 
Change log: c91bb42405..7877db2873
Full diff: c91bb42405..7877db2873

Changed dependencies:
* src/third_party: a256c4b031..a80ea7a808
DEPS diff: c91bb42405..7877db2873/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Idb91f33782098fc1f686aa36881e6c2ed462022c
Reviewed-on: https://webrtc-review.googlesource.com/3120
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19936}
 2017-09-25 04:17:27 +00:00
Autoroller
e9ad32272a Roll chromium_revision 569732c0a9..c91bb42405 (503964:503967) 
Change log: 569732c0a9..c91bb42405
Full diff: 569732c0a9..c91bb42405

Changed dependencies:
* src/third_party: 0154077ff0..a256c4b031
* src/tools: e46accd3c8..f8a62e9f22
DEPS diff: 569732c0a9..c91bb42405/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I49faf4c0da643ca92b59481e797d138e2531ba0e
Reviewed-on: https://webrtc-review.googlesource.com/3100
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19935}
 2017-09-25 01:13:56 +00:00
Autoroller
fc63a7f740 Roll chromium_revision fe71bbc1fb..569732c0a9 (503807:503964) 
Change log: fe71bbc1fb..569732c0a9
Full diff: fe71bbc1fb..569732c0a9

Changed dependencies:
* src/base: 9529eebc82..234faf4fdd
* src/build: 29038c884d..f404a070d4
* src/ios: 39c4b2fcf7..7d85e4e68a
* src/testing: cc96d3d66b..977a33acb7
* src/third_party: 302a45ca40..0154077ff0
* src/third_party/catapult: aa736cc76e..fdacc64db0
* src/third_party/libvpx/source/libvpx: 9a2dd7e67e..10bab1ec29
* src/tools: 46c94ba649..e46accd3c8
DEPS diff: fe71bbc1fb..569732c0a9/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,marpan@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I7c037c1a768199d9a9ce08011b1e8b44154add5a
Reviewed-on: https://webrtc-review.googlesource.com/3080
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19934}
 2017-09-24 22:12:34 +00:00
Oleh Prypin
86021d9548 Roll chromium_revision 008fb813c3..fe71bbc1fb (503673:503807) + Android fix 
Specify requires_android = true in Android dist_jar targets.
Not specifying it became an error since the commit
"Android: Add proguard and dex options to dist_jar"
https://chromium-review.googlesource.com/673094

Change log: 008fb813c3..fe71bbc1fb
Full diff: 008fb813c3..fe71bbc1fb

Changed dependencies:
* src/base: c18a0c6f24..9529eebc82
* src/build: 59ac1990b6..29038c884d
* src/ios: 17d0800b46..39c4b2fcf7
* src/testing: 1f35ec36f2..cc96d3d66b
* src/third_party: 7e981769b0..302a45ca40
* src/third_party/catapult: b233ea0e0e..aa736cc76e
* src/tools: 92042cc6a9..46c94ba649
DEPS diff: 008fb813c3..fe71bbc1fb/DEPS

No update to Clang.

TBR=kjellander@webrtc.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Icb025a8a8635bb14da08e2ef3c1ac10ce88cfe15
Reviewed-on: https://webrtc-review.googlesource.com/3060
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19933}
 2017-09-24 20:59:54 +00:00
Per Åhgren
b3547fa5de Revert "Added logging inside AEC3 for render API buffer under/overruns" 
This reverts commit 262d4ff882d62985426d4c31bae1411c7d5ed0e1.

Reason for revert: The logging in this CL is spamming the logs. Therefore I'll revert and reland this once that has been fixed.


Original change's description:
> Added logging inside AEC3 for render API buffer under/overruns
> 
> Bug: webrtc:8250
> Change-Id: Ib9ce26419b8961a33869d2f24cc4248fe10039b8
> Reviewed-on: https://webrtc-review.googlesource.com/1562
> Commit-Queue: Per Åhgren <peah@webrtc.org>
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19856}

TBR=gustaf@webrtc.org,peah@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:8250
Change-Id: Icbbb219772ca2e3644b9fcb7fa99545b147fd675
Reviewed-on: https://webrtc-review.googlesource.com/2720
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Noah Richards <noahric@chromium.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19932}
 2017-09-23 23:10:02 +00:00
Magnus Jedvert
835cc0c646 Remove unnecessary audio references in PeerConnectionFactory 
We currently pass in a lot of audio parameters to PeerConnectionFactory
which we never use. This CL removes them.

All these parameters are reference counted, so they are not needed for
lifetime management (unless we do something crazy). Even if we want to
switch from reference counting to std::unique_ptrs in the future, the
voice engine is a more suitable owner than PeerConnectionFactory. The
PeerConnectionFactory already owns a MediaEngine which in turn owns a
VoiceEngine.

Bug: webrtc:7613
Change-Id: I393cf0d29ffa762a3a13475f6fbe00b8565f4c07
Reviewed-on: https://webrtc-review.googlesource.com/1600
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19931}
 2017-09-23 14:36:14 +00:00
Edward Lemur
73c81759cb Fix autoroller script. 
http://crrev.com/9f8b8eb2 introduced deps conditional on a variable,
we don't need to support this, so we just continue when we encounter
a dict.

NOTRY=True

Bug: None
Change-Id: I9ce22cbfd1b3ae02b4a48c9c8312a08a904f9291
Reviewed-on: https://webrtc-review.googlesource.com/2688
Reviewed-by: Charu Jain <charujain@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19930}
 2017-09-22 16:50:01 +00:00
solenberg
2397b9a114 Remove voe::OutputMixer and AudioConferenceMixer. 
This code path is not used anymore.

BUG=webrtc:4690

Review-Url: https://codereview.webrtc.org/3015553002
Cr-Commit-Position: refs/heads/master@{#19929}
 2017-09-22 13:48:10 +00:00
solenberg
4652e86c0c Disable flaky AudioStats.NoLoss test. 
BUG=none

Review-Url: https://codereview.webrtc.org/3013783002
Cr-Commit-Position: refs/heads/master@{#19928}
 2017-09-22 13:07:56 +00:00
henrika
c3d0da097c Avoids crash in AudioTrack when audio starts in background mode 
TBR=noahric

Bug: NONE
Change-Id: Ie528b36cc03d53b15fbfd56a386309a8c3adce73
Reviewed-on: https://webrtc-review.googlesource.com/2681
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19927}
 2017-09-22 11:43:51 +00:00
brandtr
2c30120fac Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ ) 
Reason for revert:
Breaks KitKat/Lollipop perf bots.

Original issue's description:
> Add full stack tests for MediaCodec encoder.
>
> * Add audio_ prefix to CallTest::{en,de}coder_factory_.
> * Let VideoQualityTest only instantiate encoders using encoder factories.
> * Add HW encoder factories to VideoQualityTest.
> * Add full stack tests:
>   - sqcif7 at  30 kbps: MediaCodec and libvpx.
>   - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.
>
> BUG=webrtc:8219
>
> Review-Url: https://codereview.webrtc.org/3005253002
> Cr-Commit-Position: refs/heads/master@{#19923}
> Committed: https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa

TBR=sprang@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8219

Review-Url: https://codereview.webrtc.org/3016593002
Cr-Commit-Position: refs/heads/master@{#19926}
 2017-09-22 11:30:08 +00:00
asapersson
55c7eded94 VideoProcessorIntegrationTest: Group member variables into two structs containing target/actual rates. 
- Group member variables into two structs: target rates/actual rates.
- Split verify and print of rate control metrics into separate functions.
- Rename member variables.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/3009423002
Cr-Commit-Position: refs/heads/master@{#19925}
 2017-09-22 10:45:15 +00:00
Niels Möller
22d3da9235 Delete unused Atomic32 overloads of binary +/- operators. 
Bug: None
Change-Id: I731513aabb45f006112c150ea0e213761cb0716e
Reviewed-on: https://webrtc-review.googlesource.com/2680
Reviewed-by: Henrik Grunell <henrikg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19924}
 2017-09-22 08:54:23 +00:00
brandtr
2cefac6c16 Add full stack tests for MediaCodec encoder. 
* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: MediaCodec and libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219

Review-Url: https://codereview.webrtc.org/3005253002
Cr-Commit-Position: refs/heads/master@{#19923}
 2017-09-22 07:46:25 +00:00
Autoroller
433b11ede7 Roll chromium_revision d4c912f989..008fb813c3 (503644:503673) 
Change log: d4c912f989..008fb813c3
Full diff: d4c912f989..008fb813c3

Changed dependencies:
* src/base: c0b4f622bc..c18a0c6f24
* src/third_party: b1ead0d952..7e981769b0
* src/third_party/catapult: 703485470a..b233ea0e0e
DEPS diff: d4c912f989..008fb813c3/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I502f6d078092b865adc34999fd8e8f50768155ce
Reviewed-on: https://webrtc-review.googlesource.com/2660
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19922}
 2017-09-22 07:28:42 +00:00
brandtr
7cd28b9172 Set protected_by_flexfec flag properly in tests. 
BUG=none

Review-Url: https://codereview.webrtc.org/3010003002
Cr-Commit-Position: refs/heads/master@{#19921}
 2017-09-22 07:26:25 +00:00
Autoroller
44eb7a2d7c Roll chromium_revision cbba184f42..d4c912f989 (503620:503644) 
Change log: cbba184f42..d4c912f989
Full diff: cbba184f42..d4c912f989

Changed dependencies:
* src/third_party: fdd498a785..b1ead0d952
* src/third_party/catapult: 33d54da00a..703485470a
DEPS diff: cbba184f42..d4c912f989/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I5b21e62f497372eac7951b76d4ec55c05a49982e
Reviewed-on: https://webrtc-review.googlesource.com/2640
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19920}
 2017-09-22 04:15:45 +00:00
Autoroller
401a52bb5d Roll chromium_revision aa5131c67a..cbba184f42 (503572:503620) 
Change log: aa5131c67a..cbba184f42
Full diff: aa5131c67a..cbba184f42

Changed dependencies:
* src/base: 4fb0dbd297..c0b4f622bc
* src/ios: fab954cea5..17d0800b46
* src/testing: d0000d7125..1f35ec36f2
* src/third_party: a472b3dbd0..fdd498a785
* src/third_party/catapult: 68ce41b9bd..33d54da00a
* src/tools: 4132baabcc..92042cc6a9
DEPS diff: aa5131c67a..cbba184f42/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: If91f299317431882aab7bc042b0b535e6f06b687
Reviewed-on: https://webrtc-review.googlesource.com/2620
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19919}
 2017-09-22 01:16:25 +00:00
Autoroller
ec5493ea3a Roll chromium_revision 5aca6dd699..aa5131c67a (503520:503572) 
Change log: 5aca6dd699..aa5131c67a
Full diff: 5aca6dd699..aa5131c67a

Changed dependencies:
* src/base: 1ad0de3267..4fb0dbd297
* src/build: 880a78a5b9..59ac1990b6
* src/ios: b25923c953..fab954cea5
* src/third_party: cf92e446d0..a472b3dbd0
* src/third_party/catapult: e1aa3179fa..68ce41b9bd
* src/tools: 0d25071bbe..4132baabcc
DEPS diff: 5aca6dd699..aa5131c67a/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ied021143be8184f20fa0019258fcefe0be8b9cd7
Reviewed-on: https://webrtc-review.googlesource.com/2600
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19918}
 2017-09-21 22:25:46 +00:00
Karl Wiberg
73b60b82ee Remove the redundant method GetPayloadSpecifics 
It's in the way of a refactoring.

Also change PayloadTypeToPayload---the method all callers can use instead---to return Optional<Payload> instead of const Payload* (for thread safety reasons: an object that protects itself with a mutex shouldn't be handing out pointers to parts of itself). 

BUG=webrtc:8159

Change-Id: I7ef0d545077ffdea016b309f2165e3c4955a2928
Reviewed-on: https://webrtc-review.googlesource.com/2360
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19917}
 2017-09-21 20:19:55 +00:00
Autoroller
736a98ae5d Roll chromium_revision 0b04bb65d6..5aca6dd699 (503455:503520) 
Change log: 0b04bb65d6..5aca6dd699
Full diff: 0b04bb65d6..5aca6dd699

Changed dependencies:
* src/base: 8322a45b6e..1ad0de3267
* src/build: 68d3be9b11..880a78a5b9
* src/ios: a701b9fce2..b25923c953
* src/testing: 8fcd8f2775..d0000d7125
* src/third_party: 5a404050d5..cf92e446d0
* src/tools: f98ecab250..0d25071bbe
DEPS diff: 0b04bb65d6..5aca6dd699/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I15dce7be5ae26a9eb0e180a5e7b45d44b492609e
Reviewed-on: https://webrtc-review.googlesource.com/2580
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19916}
 2017-09-21 19:19:45 +00:00
Karl Wiberg
92d9dd069d rtp_rtcp_format: Separate public and private source files 
There was one .h file that didn't have to be public. :-)

BUG=webrtc:8159, webrtc:8255

Change-Id: I0998f0340384c57f52affdde30f6b4eb2eaa712b
Reviewed-on: https://webrtc-review.googlesource.com/2400
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19915}
 2017-09-21 17:45:25 +00:00
Autoroller
8e8da13eb1 Roll chromium_revision e242527ec0..0b04bb65d6 (503426:503455) 
Change log: e242527ec0..0b04bb65d6
Full diff: e242527ec0..0b04bb65d6

Changed dependencies:
* src/build: 555b75b182..68d3be9b11
* src/ios: 76b87738dd..a701b9fce2
* src/third_party: 3ef96a8e1f..5a404050d5
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/f51f273ee8..c03c218190
* src/tools: c8b855bc2f..f98ecab250
DEPS diff: e242527ec0..0b04bb65d6/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I8986ce14213e9a887b689a6bc5b8c7fd4e841609
Reviewed-on: https://webrtc-review.googlesource.com/2540
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19914}
 2017-09-21 16:28:35 +00:00
Autoroller
e10c01c0a6 Roll chromium_revision 6995ce043e..e242527ec0 (503371:503426) 
Change log: 6995ce043e..e242527ec0
Full diff: 6995ce043e..e242527ec0

Changed dependencies:
* src/base: 533dae7360..8322a45b6e
* src/buildtools: 26b7e66950..f6d165d9d8
* src/ios: ec55a185d9..76b87738dd
* src/testing: 12a0d395a0..8fcd8f2775
* src/third_party: 55d2f862b6..3ef96a8e1f
* src/third_party/catapult: 6be590cea2..e1aa3179fa
* src/tools: 5f0140b10b..c8b855bc2f
DEPS diff: 6995ce043e..e242527ec0/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I176844ea9fb5b37938541877ac3f0e5b2b9fa596
Reviewed-on: https://webrtc-review.googlesource.com/2501
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19913}
 2017-09-21 13:17:15 +00:00
solenberg
946d886187 Remove VoENetwork 
BUG=webrtc:4690

Review-Url: https://codereview.webrtc.org/3016543002
Cr-Commit-Position: refs/heads/master@{#19912}
 2017-09-21 11:02:53 +00:00
Elad Alon
99a81b613d Remove #include of rtc_stream_config.h from rtc_event_log.h 
StreamConfig is not integral to RTC-event logging in general, but rather to specific events. Therefore, the dependency on it should not be exported through rtc_event_log.h.

BUG=webrtc:8111
TBR=stefan@webrtc.org

Change-Id: I1ece0830cd05fd12220c8c717490e15942bacec9
Reviewed-on: https://webrtc-review.googlesource.com/1238
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19911}
 2017-09-21 09:05:54 +00:00
Autoroller
fc1793064f Roll chromium_revision 2d1b3e73b6..6995ce043e (503346:503371) 
Change log: 2d1b3e73b6..6995ce043e
Full diff: 2d1b3e73b6..6995ce043e

Changed dependencies:
* src/ios: 629ce83683..ec55a185d9
* src/third_party: e329a44e21..55d2f862b6
* src/tools: 92e8e4d093..5f0140b10b
DEPS diff: 2d1b3e73b6..6995ce043e/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I56721ca826484bf66341ccdee17f5ec480a97ee1
Reviewed-on: https://webrtc-review.googlesource.com/2480
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19910}
 2017-09-21 07:26:33 +00:00
Autoroller
7a2b37051e Roll chromium_revision d49a98a3ca..2d1b3e73b6 (503300:503346) 
Change log: d49a98a3ca..2d1b3e73b6
Full diff: d49a98a3ca..2d1b3e73b6

Changed dependencies:
* src/base: d749161688..533dae7360
* src/build: 583eac153b..555b75b182
* src/testing: 4c3bcef275..12a0d395a0
* src/third_party: 8213af59dc..e329a44e21
* src/tools: 725868c5e8..92e8e4d093
DEPS diff: d49a98a3ca..2d1b3e73b6/DEPS

Clang version changed 313222:313786
Details: d49a98a3ca..2d1b3e73b6/tools/clang/scripts/update.py

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ib5bd83d38998f067ed407ca2738ad1380b551ad1
Reviewed-on: https://webrtc-review.googlesource.com/2460
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19909}
 2017-09-21 04:30:53 +00:00
Autoroller
aa0fe1290e Roll chromium_revision f52ff80530..d49a98a3ca (501932:503300) 
Change log: f52ff80530..d49a98a3ca
Full diff: f52ff80530..d49a98a3ca

Changed dependencies:
* src/base: a3848e11ae..d749161688
* src/build: 0119b14e14..583eac153b
* src/buildtools: cbc33b9c0a..26b7e66950
* src/ios: 79eaa19c53..629ce83683
* src/testing: e9068583fe..4c3bcef275
* src/third_party: 3c251d88b3..8213af59dc
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/683ffbbe57..f51f273ee8
* src/third_party/catapult: dd30f4f383..6be590cea2
* src/third_party/gtest-parallel: 965cfdccf9..ee20273811
* src/third_party/libyuv: 27036e33e8..5b1af9a335
* src/tools: 02f1273b3b..725868c5e8
DEPS diff: f52ff80530..d49a98a3ca/DEPS

Clang version changed 312679:313222
Details: f52ff80530..d49a98a3ca/tools/clang/scripts/update.py

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I801b2242f57be609a1f018d1d320e2183e73448f
Reviewed-on: https://webrtc-review.googlesource.com/2440
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19908}
 2017-09-21 01:37:42 +00:00
deadbeef
4e2deab79c Only return stats for the most recent unsignaled audio stream. 
The track-level stats are currently implemented in terms of the stream-
level stats. Which is a problem if multiple unsignaled streams map to the
same track (see bug for more details). This CL fixes the problem
partially, but only returning stats for one of the unsignaled streams.
A better solution would be to return stats for both streams, but update
the track-level stats independently somehow. But that would require more
extensive changes, and it's not yet clear how we want to do it.

BUG=webrtc:8158

Review-Url: https://codereview.webrtc.org/3008373002
Cr-Commit-Position: refs/heads/master@{#19907}
 2017-09-20 20:56:21 +00:00
kwiberg
feeb9bfe03 Remove backwards compatibilty header for Optional 
BUG=webrtc:8205

Review-Url: https://codereview.webrtc.org/3011963002
Cr-Commit-Position: refs/heads/master@{#19906}
 2017-09-20 19:17:42 +00:00
Charu Jain
851481cfaa Revert "Roll chromium_revision f52ff80530..4bafa509ea (501932:502960)" 
This reverts commit e68293553d1bd2504bf3ebf7f6769c3b01e640e3.

Reason for revert: Breaks internal projects

Original change's description:
> Roll chromium_revision f52ff80530..4bafa509ea (501932:502960)
> 
> Change log: f52ff80530..4bafa509ea
> Full diff: f52ff80530..4bafa509ea
> 
> Changed dependencies:
> * src/base: a3848e11ae..6afcd86a32
> * src/build: 0119b14e14..67a664871e
> * src/buildtools: cbc33b9c0a..26b7e66950
> * src/ios: 79eaa19c53..2cd231262b
> * src/testing: e9068583fe..0c3fb670c3
> * src/third_party: 3c251d88b3..f56e199ae6
> * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/683ffbbe57..f51f273ee8
> * src/third_party/catapult: dd30f4f383..ab30bb20a8
> * src/third_party/gtest-parallel: 965cfdccf9..ee20273811
> * src/third_party/libyuv: 27036e33e8..5b1af9a335
> * src/tools: 02f1273b3b..4fa8837ea2
> DEPS diff: f52ff80530..4bafa509ea/DEPS
> 
> Clang version changed 312679:313222
> Details: f52ff80530..4bafa509ea/tools/clang/scripts/update.py
> 
> TBR=buildbot@webrtc.org,
> BUG=None
> CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal
> 
> Change-Id: Iade6f94aca4b9d61cf545e80147268bbab5ee3ed
> Reviewed-on: https://webrtc-review.googlesource.com/2280
> Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
> Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19904}

TBR=buildbot@webrtc.org

Change-Id: I358e1006a0f2708bb106eb8ee81118c3c8702fb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: master.internal.tryserver.corp.webrtc:linux_internal
Reviewed-on: https://webrtc-review.googlesource.com/2320
Reviewed-by: Charu Jain <charujain@webrtc.org>
Commit-Queue: Charu Jain <charujain@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19905}
 2017-09-20 09:36:51 +00:00
Autoroller
e68293553d Roll chromium_revision f52ff80530..4bafa509ea (501932:502960) 
Change log: f52ff80530..4bafa509ea
Full diff: f52ff80530..4bafa509ea

Changed dependencies:
* src/base: a3848e11ae..6afcd86a32
* src/build: 0119b14e14..67a664871e
* src/buildtools: cbc33b9c0a..26b7e66950
* src/ios: 79eaa19c53..2cd231262b
* src/testing: e9068583fe..0c3fb670c3
* src/third_party: 3c251d88b3..f56e199ae6
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/683ffbbe57..f51f273ee8
* src/third_party/catapult: dd30f4f383..ab30bb20a8
* src/third_party/gtest-parallel: 965cfdccf9..ee20273811
* src/third_party/libyuv: 27036e33e8..5b1af9a335
* src/tools: 02f1273b3b..4fa8837ea2
DEPS diff: f52ff80530..4bafa509ea/DEPS

Clang version changed 312679:313222
Details: f52ff80530..4bafa509ea/tools/clang/scripts/update.py

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Iade6f94aca4b9d61cf545e80147268bbab5ee3ed
Reviewed-on: https://webrtc-review.googlesource.com/2280
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19904}
 2017-09-19 22:17:59 +00:00
zhihuang
b19012e6cc Remove the support of fallback from DTLS to SDES. 
The support of fallback from DTLS to SDES is removed in this CL.
Setting an SDP with both DTLS fingerprint and SDES crypto would fail.

BUG=webrtc:8266

Review-Url: https://codereview.webrtc.org/3011133002
Cr-Commit-Position: refs/heads/master@{#19903}
 2017-09-19 20:47:59 +00:00
alexnarest
b335e31bcb This is a rollback of https://chromium-review.googlesource.com/c/external/webrtc/+/616724 
it degraded results of the ANA testing

BUG=webrtc:8105

Review-Url: https://codereview.webrtc.org/3011323002
Cr-Commit-Position: refs/heads/master@{#19902}
 2017-09-19 19:00:32 +00:00
nisse
75dd6d4b96 Drop reference to webrtc_overrides/.../task_queue.h 
Since cl
https://chromium-review.googlesource.com/c/chromium/src/+/664807,
chromium no longer uses it. We need to stop referring to it from
webrtc, before it can be deleted in chromium.

BUG=webrtc:8166

Review-Url: https://codereview.webrtc.org/3015513002
Cr-Commit-Position: refs/heads/master@{#19901}
 2017-09-19 15:28:00 +00:00
Mirko Bonadei
4dc4e259ce Reland "Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++."" 
This reverts commit 034a6b8a4cdf151ae7377c87c5b2b6156d658173.

Reason for revert: Trying to fix the issue of rtc_base:rtc_base which has 2 kind of source files but in exclusive if branches.

Original change's description:
> Revert "Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++."
> 
> This reverts commit 0c15c5332fea2bbf5fe29dd806f9f4e606eeb9b8.
> 
> Reason for revert: This causes problems in this moment. I have to fix a target in rtc_base before landing this presubmit check.
> 
> Original change's description:
> > Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++.
> > 
> > The error message will be something like:
> > 
> > GN targets cannot mix .c (or .cc) and .m (or .mm) source files.
> > Please create a separate target for each collection of sources.
> > Mixed sources:
> > {
> >   BUILD_GN_PATH: [
> >     [
> >       TARGET_NAME,
> >       [
> >         SOURCES
> >       ]
> >     ],
> >     ...
> >   ],
> >   ...
> > }
> > 
> > Bug: webrtc:7743
> > Change-Id: I45dd2c621b830e5aeb081fa8d17c9497a49c2554
> > Reviewed-on: https://webrtc-review.googlesource.com/1980
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#19897}
> 
> TBR=kjellander@webrtc.org,mbonadei@webrtc.org
> 
> Change-Id: I73ff609b0140719473afd36ead1632e5cc3b41f6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7743
> Reviewed-on: https://webrtc-review.googlesource.com/2180
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19898}

TBR=kjellander@webrtc.org,mbonadei@webrtc.org

Change-Id: I18dbb5a6a01ac2a184446542c29b25a3e33508ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7743
Reviewed-on: https://webrtc-review.googlesource.com/2181
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19900}
 2017-09-19 14:23:00 +00:00
Mirko Bonadei
080832eb37 Moving Obj-C++ code in desktop_capture_objc. 
The goal of this CL is to separate Obj-C/Obj-C++ code from targets
which have also C++ code (see 
https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more
information).

To achieve this we have created 2 targets (desktop_capture_objc and
desktop_capture_generic) and desktop_capture will act as a proxy
between these targets (this way we can avoid a circular dependency
between desktop_capture_generic and desktop_capture_objc).

NOTRY=True

Bug: webrtc:7743
Change-Id: I19f8bb8719cfc6af259819e2089cebea72b5d531
Reviewed-on: https://webrtc-review.googlesource.com/2220
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19899}
 2017-09-19 14:16:19 +00:00
Mirko Bonadei
034a6b8a4c Revert "Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++." 
This reverts commit 0c15c5332fea2bbf5fe29dd806f9f4e606eeb9b8.

Reason for revert: This causes problems in this moment. I have to fix a target in rtc_base before landing this presubmit check.

Original change's description:
> Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++.
> 
> The error message will be something like:
> 
> GN targets cannot mix .c (or .cc) and .m (or .mm) source files.
> Please create a separate target for each collection of sources.
> Mixed sources:
> {
>   BUILD_GN_PATH: [
>     [
>       TARGET_NAME,
>       [
>         SOURCES
>       ]
>     ],
>     ...
>   ],
>   ...
> }
> 
> Bug: webrtc:7743
> Change-Id: I45dd2c621b830e5aeb081fa8d17c9497a49c2554
> Reviewed-on: https://webrtc-review.googlesource.com/1980
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19897}

TBR=kjellander@webrtc.org,mbonadei@webrtc.org

Change-Id: I73ff609b0140719473afd36ead1632e5cc3b41f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7743
Reviewed-on: https://webrtc-review.googlesource.com/2180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19898}
 2017-09-19 10:54:40 +00:00
Mirko Bonadei
0c15c5332f Adding PRESUBMIT check to avoid mixing C, C++ and Objc-C/Obj-C++. 
The error message will be something like:

GN targets cannot mix .c (or .cc) and .m (or .mm) source files.
Please create a separate target for each collection of sources.
Mixed sources:
{
  BUILD_GN_PATH: [
    [
      TARGET_NAME,
      [
        SOURCES
      ]
    ],
    ...
  ],
  ...
}

Bug: webrtc:7743
Change-Id: I45dd2c621b830e5aeb081fa8d17c9497a49c2554
Reviewed-on: https://webrtc-review.googlesource.com/1980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19897}
 2017-09-19 09:41:18 +00:00
Mirko Bonadei
7de1eb7bdc Adding Test at the end of test classes. 
NOTRY= True

Bug: None
Change-Id: I73c09c41e7ce5f445b9e1b816a3fbba045627c8f
Reviewed-on: https://webrtc-review.googlesource.com/2141
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19896}
 2017-09-19 08:59:29 +00:00
zhihuang
eb23e17798 Revert of Completed the functionalities of SrtpTransport. (patchset 7 id:320001 of https://codereview.webrtc.org/2997983002/ ) 
Reason for revert:
This seems to be causing some video freezes. See https://bugs.chromium.org/p/webrtc/issues/detail?id=8251

Original issue's description:
> Completed the functionalities of SrtpTransport.
>
> The SrtpTransport takes the SRTP responsibilities from the BaseChannel
> and SrtpFilter. SrtpTransport is now responsible for setting the crypto
> keys, protecting and unprotecting the packets. SrtpTransport doesn't know
> if the keys are from SDES or DTLS handshake.
>
> BaseChannel is now only responsible setting the offer/answer for SDES
> or extracting the key from DtlsTransport and configuring the
> SrtpTransport.
>
> SrtpFilter is used by BaseChannel as a helper for SDES negotiation.
>
> BUG=webrtc:7013
>
> Review-Url: https://codereview.webrtc.org/2997983002
> Cr-Commit-Position: refs/heads/master@{#19636}
> Committed: e683c6871f

TBR=deadbeef@webrtc.org,pthatcher@google.com,zhihuang@webrtc.org
Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7013

Review-Url: https://codereview.webrtc.org/3018513002
Cr-Commit-Position: refs/heads/master@{#19895}
 2017-09-19 08:12:52 +00:00
Mirko Bonadei
2572404789 Removing useless include_dirs entry. 
After the migration from serc/webrtc to src/ this entry in the
include_dirs list is not needed anymore.

Bug: chromium:611808
Change-Id: I17c87509b73b8a44f758d59ada28d366da664649
Reviewed-on: https://webrtc-review.googlesource.com/1920
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19894}
 2017-09-18 19:55:55 +00:00