admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Added logging inside AEC3 for render API buffer under/overruns"

Browse Source 
This reverts commit 262d4ff882d62985426d4c31bae1411c7d5ed0e1.

Reason for revert: The logging in this CL is spamming the logs. Therefore I'll revert and reland this once that has been fixed.


Original change's description:
> Added logging inside AEC3 for render API buffer under/overruns
> 
> Bug: webrtc:8250
> Change-Id: Ib9ce26419b8961a33869d2f24cc4248fe10039b8
> Reviewed-on: https://webrtc-review.googlesource.com/1562
> Commit-Queue: Per Åhgren <peah@webrtc.org>
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#19856}

TBR=gustaf@webrtc.org,peah@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:8250
Change-Id: Icbbb219772ca2e3644b9fcb7fa99545b147fd675
Reviewed-on: https://webrtc-review.googlesource.com/2720
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Noah Richards <noahric@chromium.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19932}
This commit is contained in:
Per Åhgren 2017-09-22 19:12:56 +00:00 committed by Commit Bot
parent 835cc0c646
commit b3547fa5de
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/audio_processing/aec3/block_processor.cc
View File

@ -16,7 +16,6 @@
#include "modules/audio_processing/logging/apm_data_dumper.h"
#include "rtc_base/atomicops.h"
#include "rtc_base/constructormagic.h"
#include "rtc_base/logging.h"
namespace webrtc {
namespace {
@ -102,15 +101,11 @@ void BlockProcessorImpl::ProcessCapture(
// been a render buffer overrun as the buffer alignment may be noncausal.
delay_controller_->Reset();
render_buffer_->Reset();
LOG(LS_WARNING) << "Reset due to detected render buffer overrun.";
}
// Update the render buffers with new render data, filling the buffers with
// empty blocks when there is no render data available.
render_buffer_underrun = !render_buffer_->UpdateBuffers();
if (render_buffer_underrun) {
LOG(LS_WARNING) << "Render API jitter buffer underrun.";
}
// Compute and and apply the render delay required to achieve proper signal
// alignment.
@ -132,7 +127,6 @@ void BlockProcessorImpl::ProcessCapture(
delay_controller_->Reset();
render_buffer_->Reset();
delay_change = true;
LOG(LS_WARNING) << "Reset due to noncausal delay.";
}
// Remove the echo from the capture signal.
@ -170,9 +164,6 @@ void BlockProcessorImpl::BufferRender(
// Buffer the render data.
render_buffer_overrun_occurred_ = !render_buffer_->Insert(block);
if (render_buffer_overrun_occurred_) {
LOG(LS_WARNING) << "Render API jitter buffer overrun.";
}
// Update the metrics.
metrics_.UpdateRender(render_buffer_overrun_occurred_);