Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed: f33cee7534TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
NOTRY=True
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3012783002
Cr-Commit-Position: refs/heads/master@{#19712}
Reason for revert:
Now making sure the data attribute contents is not wiped for non-Android targets,
which caused every test relying on resources to break.
Original issue's description:
> Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )
>
> Reason for revert:
> Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554
>
> Edward: do you understand why? I'll run a full CQ set before relanding for sure.
>
> Original issue's description:
> > Add //build/android/pylib/results/ to Android isolate packaging
> >
> > This is needed before relanding
> > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> >
> > TESTED=
> > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> > is listed in the .isolated file:
> > OUT=out/android-Release
> > TEST=tools_unittests
> > tools_webrtc/mb/mb.py isolate //$OUT $TEST
> > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> >
> > BUG=chromium:717417
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/3006103002
> > Cr-Commit-Position: refs/heads/master@{#19695}
> > Committed: f8ff0282c6
>
> TBR=ehmaldonado@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:717417
>
> Review-Url: https://codereview.webrtc.org/3008083004
> Cr-Commit-Position: refs/heads/master@{#19696}
> Committed: e5abac443a
BUG=chromium:717417
Review-Url: https://codereview.webrtc.org/3011023002
Cr-Commit-Position: refs/heads/master@{#19707}
* Reorder and rename members of FrameStatistic.
* Rename corresponding temp variables used in the summary calculations.
* Make Stats class less structy.
* Try to enforce consistent frame numbers at all times.
* Remove VideoProcessor::FrameInfo struct and use the Stats class
for keeping track of encode/decode start times, etc.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3011923002
Cr-Commit-Position: refs/heads/master@{#19703}
other macros (e.g. GUARDED_BY) rename postpone to followup CL
since it touches codebase wider
BUG=webrtc:8198
Review-Url: https://codereview.webrtc.org/3004393002
Cr-Commit-Position: refs/heads/master@{#19701}
So in MouseCursorMonitorWin, we do not need to translate it again.
Bug: webrtc:7950
Change-Id: I39145e8031f7eea2c2f07c0ba666e1f327d8609b
Reviewed-on: https://chromium-review.googlesource.com/651667
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19698}
Reason for revert:
Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554
Edward: do you understand why? I'll run a full CQ set before relanding for sure.
Original issue's description:
> Add //build/android/pylib/results/ to Android isolate packaging
>
> This is needed before relanding
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
>
> TESTED=
> I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> is listed in the .isolated file:
> OUT=out/android-Release
> TEST=tools_unittests
> tools_webrtc/mb/mb.py isolate //$OUT $TEST
> tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
>
> BUG=chromium:717417
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/3006103002
> Cr-Commit-Position: refs/heads/master@{#19695}
> Committed: f8ff0282c6TBR=ehmaldonado@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:717417
Review-Url: https://codereview.webrtc.org/3008083004
Cr-Commit-Position: refs/heads/master@{#19696}
This is needed before relanding
https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
TESTED=
I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
is listed in the .isolated file:
OUT=out/android-Release
TEST=tools_unittests
tools_webrtc/mb/mb.py isolate //$OUT $TEST
tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
BUG=chromium:717417
NOTRY=True
Review-Url: https://codereview.webrtc.org/3006103002
Cr-Commit-Position: refs/heads/master@{#19695}
We use Optional in our public API, so its header should be in
webrtc/api/.
BUG=webrtc:8205
Review-Url: https://codereview.webrtc.org/3011943002
Cr-Commit-Position: refs/heads/master@{#19693}
One of these lint errors is blocking a CL that moves optional.h to
webrtc/api/. And while I made a CL to fix that one, I figured I might
as well fix them all.
BUG=webrtc:8205
Review-Url: https://codereview.webrtc.org/3008143002
Cr-Commit-Position: refs/heads/master@{#19692}
Reason for revert:
Landed without CQ, which was unintended.
Original issue's description:
> Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #1 id:1 of https://codereview.webrtc.org/3010143002/ )
>
> Reason for revert:
> I will fix and reland.
>
> Original issue's description:
> > Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
> >
> > Reason for revert:
> > Breaks google3 project.
> >
> > Original issue's description:
> > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> > >
> > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
> > >
> > > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> > >
> > > Review-Url: https://codereview.webrtc.org/3007473002
> > > Cr-Commit-Position: refs/heads/master@{#19666}
> > > Committed: f33cee7534
> >
> > TBR=terelius@webrtc.org,nisse@webrtc.org,eladalon@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3010143002
> > Cr-Commit-Position: refs/heads/master@{#19672}
> > Committed: 3eac8002db
>
> TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:8142, webrtc:8143, webrtc:8145
>
> Review-Url: https://codereview.webrtc.org/3005153002
> Cr-Commit-Position: refs/heads/master@{#19690}
> Committed: d67cefbbeaTBR=terelius@webrtc.org,nisse@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3007193002
Cr-Commit-Position: refs/heads/master@{#19691}
Reason for revert:
I will fix and reland.
Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed: f33cee7534
>
> TBR=terelius@webrtc.org,nisse@webrtc.org,eladalon@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:8142, webrtc:8143, webrtc:8145
>
> Review-Url: https://codereview.webrtc.org/3010143002
> Cr-Commit-Position: refs/heads/master@{#19672}
> Committed: 3eac8002dbTBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3005153002
Cr-Commit-Position: refs/heads/master@{#19690}
Reason for revert:
It breaks a chromium FYI trybot (the switch from rtc_static_library to rtc_source_set seems to be the problem).
Original issue's description:
> Reland of Decoupling rtc_base from Obj-C code (patchset #1 id:1 of https://codereview.webrtc.org/3008103002/ )
>
> Reason for revert:
> Trying to reland after fixing downstream project.
>
> Original issue's description:
> > Revert of Decoupling rtc_base from Obj-C code (patchset #8 id:140001 of https://codereview.webrtc.org/3001623003/ )
> >
> > Reason for revert:
> > It breaks a downstream project.
> >
> > Original issue's description:
> > > Decoupling rtc_base from Obj-C code
> > >
> > > The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
> > > also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
> > > for more information).
> > >
> > > To achieve this we have created 2 targets (rtc_base_objc and rtc_base_generic)
> > > and rtc_base will act as a proxy between these targets (this way we can avoid a
> > > circular dependency between rtc_base_generic and rtc_base_objc).
> > >
> > > BUG=webrtc:7743
> > >
> > > Review-Url: https://codereview.webrtc.org/3001623003
> > > Cr-Commit-Position: refs/heads/master@{#19661}
> > > Committed: a0a5b98937
> >
> > TBR=kjellander@webrtc.org,kwiberg@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7743
> >
> > Review-Url: https://codereview.webrtc.org/3008103002
> > Cr-Commit-Position: refs/heads/master@{#19664}
> > Committed: 791a8f611d
>
> TBR=kjellander@webrtc.org,kwiberg@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7743
>
> Review-Url: https://codereview.webrtc.org/3004373002
> Cr-Commit-Position: refs/heads/master@{#19681}
> Committed: a0c893f324TBR=kjellander@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/3007183002
Cr-Commit-Position: refs/heads/master@{#19688}
This CL addresses to nits:
1. When event_log_factory_ is not null, there's no need to create a RtcEventLogNullImpl object.
2. Use MakeUnique.
BUG=None
Review-Url: https://codereview.webrtc.org/3012763002
Cr-Commit-Position: refs/heads/master@{#19686}
Files under the tools directory were untracked by GN.
This cl creates a target for them. The target is testonly because it
depends on "webrtc/test:rtp_test_utils".
BUG=webrtc:7651
NOTRY=True
Review-Url: https://codereview.webrtc.org/2886713002
Cr-Commit-Position: refs/heads/master@{#19683}
This is done to make UBSan testing more convenient in integration with projects using WebRTC
Some blacklist entries were obsolete so don't need a replacement
Also fix one of the warnings (thanks, kwiberg@)
BUG=webrtc:8189, webrtc:5486, webrtc:5491
Review-Url: https://codereview.webrtc.org/3009123002
Cr-Commit-Position: refs/heads/master@{#19682}
Reason for revert:
Trying to reland after fixing downstream project.
Original issue's description:
> Revert of Decoupling rtc_base from Obj-C code (patchset #8 id:140001 of https://codereview.webrtc.org/3001623003/ )
>
> Reason for revert:
> It breaks a downstream project.
>
> Original issue's description:
> > Decoupling rtc_base from Obj-C code
> >
> > The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
> > also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
> > for more information).
> >
> > To achieve this we have created 2 targets (rtc_base_objc and rtc_base_generic)
> > and rtc_base will act as a proxy between these targets (this way we can avoid a
> > circular dependency between rtc_base_generic and rtc_base_objc).
> >
> > BUG=webrtc:7743
> >
> > Review-Url: https://codereview.webrtc.org/3001623003
> > Cr-Commit-Position: refs/heads/master@{#19661}
> > Committed: a0a5b98937
>
> TBR=kjellander@webrtc.org,kwiberg@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7743
>
> Review-Url: https://codereview.webrtc.org/3008103002
> Cr-Commit-Position: refs/heads/master@{#19664}
> Committed: 791a8f611dTBR=kjellander@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/3004373002
Cr-Commit-Position: refs/heads/master@{#19681}
Before this change it was impossible to use flag names that start with "no", e.g. --noise_file
BUG=webrtc:8202
Review-Url: https://codereview.webrtc.org/3004363002
Cr-Commit-Position: refs/heads/master@{#19678}
This should solve recent linking problems with frame_editor and also speed
up the Chromium build a little.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/3006093002
Cr-Commit-Position: refs/heads/master@{#19677}
This change adds several tests for WindowFinder implmenetations.
One of the tests uses ScreenDrawer to create a foreground window or console
window (on Windows) and ensures WindowFinder can return its window_id().
The other ensures WindowFinder always returns kNullWindowId if the |pos| is out
of the screens.
Bug: webrtc:7950
Change-Id: I0cc8794e201c2fa042ea8e693434f1b0fa05b47a
Reviewed-on: https://chromium-review.googlesource.com/639591
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19676}
This change attaches top-left to the DesktopFrames generated by DesktopCapturer
implementations. Some implementations won't need to attach the top-left because
of the platform specification, e.g. coordinates in X11 always starts from
(0, 0), and we support only one screen.
After this change, we can use the new MouseCursorMonitor::Create() function in
DesktopCaptureDevice.
Bug: webrtc:7950
Change-Id: I82c24f4dd9451e32afafb6474f82c32cadcb425c
Reviewed-on: https://chromium-review.googlesource.com/644787
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19675}
Reason for revert:
Fixed
Original issue's description:
> Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ )
>
> Reason for revert:
> It breaks a downstream project.
>
> Original issue's description:
> > Trace the stats report as JSON instead of each stat separately.
> >
> > Trace the whole report as a string instead of each field on it's own. And test that the traces collected are valid.
> >
> > R=tommi@webrtc.org, hbos@webrtc.org
> > BUG=chromium:653087
> >
> > Review-Url: https://codereview.webrtc.org/2986453002
> > Cr-Commit-Position: refs/heads/master@{#19341}
> > Committed: 80c65780e6
>
> TBR=hbos@webrtc.org,tommi@webrtc.org,ehmaldonado@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:653087
>
> Review-Url: https://codereview.webrtc.org/3001683002
> Cr-Commit-Position: refs/heads/master@{#19344}
> Committed: 3439c89358
BUG=chromium:653087
Review-Url: https://codereview.webrtc.org/3000943002
Cr-Commit-Position: refs/heads/master@{#19673}
Reason for revert:
Breaks google3 project.
Original issue's description:
> Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
>
> Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
>
> BUG=webrtc:8142, webrtc:8143, webrtc:8145
>
> Review-Url: https://codereview.webrtc.org/3007473002
> Cr-Commit-Position: refs/heads/master@{#19666}
> Committed: f33cee7534TBR=terelius@webrtc.org,nisse@webrtc.org,eladalon@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3010143002
Cr-Commit-Position: refs/heads/master@{#19672}
The division that follows the added DCHECK should not be div-by-0,
since when params_.calculated is true, params_.frequency_khz would
have been updated (with something non-zero).
BUG=none
Review-Url: https://codereview.webrtc.org/3006003002
Cr-Commit-Position: refs/heads/master@{#19671}
The warnings were (all signed integer overflow):
webrtc/common_audio/signal_processing/levinson_durbin.c:46:25
12 * 268435456 cannot be represented in type 'int'
webrtc/modules/audio_processing/aecm/aecm_core.cc:930:69
522240 * 6115 cannot be represented in type 'int'
webrtc/modules/audio_processing/aecm/aecm_core_c.cc:455:36
72293096 * 50 cannot be represented in type 'int'
webrtc/modules/pacing/alr_detector.cc:70:48
1000000000 * 65 cannot be represented in type 'int'
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:947:20
1929277286 + 321546521 cannot be represented in type 'int'
BUG=webrtc:8195
Review-Url: https://codereview.webrtc.org/3005003002
Cr-Commit-Position: refs/heads/master@{#19670}
Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3007473002
Cr-Commit-Position: refs/heads/master@{#19666}
If not indicated otherwise, allow adding a packet to the retransmission
history at least every 1/15s in order to reduce frame dropping.
BUG=webrtc:7694
Review-Url: https://codereview.webrtc.org/2999063002
Cr-Commit-Position: refs/heads/master@{#19665}
Reason for revert:
It breaks a downstream project.
Original issue's description:
> Decoupling rtc_base from Obj-C code
>
> The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
> also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
> for more information).
>
> To achieve this we have created 2 targets (rtc_base_objc and rtc_base_generic)
> and rtc_base will act as a proxy between these targets (this way we can avoid a
> circular dependency between rtc_base_generic and rtc_base_objc).
>
> BUG=webrtc:7743
>
> Review-Url: https://codereview.webrtc.org/3001623003
> Cr-Commit-Position: refs/heads/master@{#19661}
> Committed: a0a5b98937TBR=kjellander@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/3008103002
Cr-Commit-Position: refs/heads/master@{#19664}
