admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Style guide: Add text about C and non-compliant C++ code

Browse Source 
BUG=none
NOTRY=true

Change-Id: I64a64a4f138b6c8aa24ad2266284024d50163908
Reviewed-on: https://chromium-review.googlesource.com/648971
Reviewed-by: Niels Möller <nisse@chromium.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19680}
This commit is contained in:
Karl Wiberg 2017-09-04 11:27:33 +02:00 committed by Commit Bot
parent 67e414ce70
commit fb4e677da0
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
style-guide.md
View File

@ -10,7 +10,27 @@ the exceptions in this file trump them both.
[chr-style]: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md
[goog-style]: https://google.github.io/styleguide/cppguide.html
Some older parts of the code violate the style guide in various ways.
* If making small changes to such code, follow the style guide when
it’s reasonable to do so, but in matters of formatting etc., it is
often better to be consistent with the surrounding code.
* If making large changes to such code, consider first cleaning it up
in a separate CL.
### Exceptions
There are no exceptions yet. If and when exceptions are adopted,
they'll be listed here.
they’ll be listed here.
## C
There’s a substantial chunk of legacy C code in WebRTC, and a lot of
it is old enough that it violates the parts of the C++ style guide
that also applies to C (naming etc.) for the simple reason that it
pre-dates the use of the current C++ style guide for this code base.
* If making small changes to C code, mimic the style of the
surrounding code.
* If making large changes to C code, consider converting the whole
thing to C++ first.