The crash occurs if a slot causes the very next slot in iteration order
to be disconnected.
Relanding after fixing a race condition that this CL revealed. Previously
the race resulted in an invalidated iterator, but now it will result in the
iterator being modified, so TSan catches it.
BUG=webrtc:7527
Review-Url: https://codereview.webrtc.org/2846593005
Cr-Commit-Position: refs/heads/master@{#18124}
Since we now have a directory for this kind of checks, let's move this
to that location.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2870393006
Cr-Commit-Position: refs/heads/master@{#18122}
There were too many assumptions of the fact that the check was running
on Linux.
BUG=webrtc:7635
NOTRY=True
Review-Url: https://codereview.webrtc.org/2878733004
Cr-Commit-Position: refs/heads/master@{#18120}
VirtualSocketServer and Sha1Digest (from rtc_base)
md5.h and md5.cc (from rtc_base_approved, Md5Digest was moved earlier)
BUG=None
Review-Url: https://codereview.webrtc.org/2875933002
Cr-Commit-Position: refs/heads/master@{#18119}
The "ice_server_url" key is always present in AppRTC server's JSON response but may be empty if no ICE server is wanted.
BUG=webrtc:7636
Review-Url: https://codereview.webrtc.org/2878673002
Cr-Commit-Position: refs/heads/master@{#18118}
Reason for revert:
Re-land the original CL because the reverting it didn't fix the problem.
Original issue's description:
> Revert of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2873803002/ )
>
> Reason for revert:
> Reverted because it possibly breaks the internal project.
>
> Original issue's description:
> > Make AudioSinkInterface::Data hold a const pointer to the audio buffer.
> >
> > This is in preparation for https://codereview.webrtc.org/2750783004/, where
> > requiring a non-const pointer for AudioSinkInterface would force an unmuting
> > and zeroing of every frame.
> >
> > BUG=webrtc:7343
> >
> > Review-Url: https://codereview.webrtc.org/2873803002
> > Cr-Commit-Position: refs/heads/master@{#18107}
> > Committed: 38605965bd
>
> TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7343
>
> Review-Url: https://codereview.webrtc.org/2877013002
> Cr-Commit-Position: refs/heads/master@{#18112}
> Committed: c904634823TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7343
Review-Url: https://codereview.webrtc.org/2880663003
Cr-Commit-Position: refs/heads/master@{#18113}
Reason for revert:
Reverted because it possibly breaks the internal project.
Original issue's description:
> Make AudioSinkInterface::Data hold a const pointer to the audio buffer.
>
> This is in preparation for https://codereview.webrtc.org/2750783004/, where
> requiring a non-const pointer for AudioSinkInterface would force an unmuting
> and zeroing of every frame.
>
> BUG=webrtc:7343
>
> Review-Url: https://codereview.webrtc.org/2873803002
> Cr-Commit-Position: refs/heads/master@{#18107}
> Committed: 38605965bdTBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7343
Review-Url: https://codereview.webrtc.org/2877013002
Cr-Commit-Position: refs/heads/master@{#18112}
Unity native plugin has to use Pinvoke technology in its APIs
This plugin dll can also be used by Windows C# applications other than
Unity.
BUG=webrtc:7389
Review-Url: https://codereview.webrtc.org/2823783002
Cr-Commit-Position: refs/heads/master@{#18108}
To make the distinction for stats, add a |recovered| flag to
RtpPacketReceived.
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2693123002
Cr-Commit-Position: refs/heads/master@{#18103}
Add logging of some histogram stats at the end of a call.
BUG=none
Review-Url: https://codereview.webrtc.org/2873303002
Cr-Commit-Position: refs/heads/master@{#18099}
VideoFrameBuffer is currently hard coded to be either I420 or Native.
This CL makes VideoFrameBuffer more generic by moving the I420 specific
functions into their own class, and adds an enum tag that represents the
format and storage type of the buffer. Each buffer type is then
represented as a subclass. See webrtc/api/video/video_frame_buffer.h for
more info.
This CL also adds support for representing I444 in VideoFrameBuffer
using the new interface. Possible future buffer type candidates are
RGB and NV12.
BUG=webrtc:7632
TBR=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/2847383002
Cr-Commit-Position: refs/heads/master@{#18098}
This prevents user from accidentally specifying a directory that contains
files that the user wants to keep.
BUG=webrtc:7608
NOTRY=True
Review-Url: https://codereview.webrtc.org/2876803002
Cr-Commit-Position: refs/heads/master@{#18096}
We want to use stable gradle releases for testing.
BUG=webrtc:7608
NOTRY=True
Review-Url: https://codereview.webrtc.org/2877723002
Cr-Commit-Position: refs/heads/master@{#18094}
This CL sets some options for ObjC in the .clang-format file to closer
match our style guide.
NOTRY=True
BUG=webrtc:7406
Review-Url: https://codereview.webrtc.org/2869593002
Cr-Commit-Position: refs/heads/master@{#18092}
The audio mixer has a subcomponent called FrameCombiner, which uses an
AudioProcessing instance as a limiter. The limiter smoothly increases
the volume to avoid causing clipping.
The limiter was created in a default configuration causing the
ResidualEchoDetector submodule of AudioProcessing to be
activated. That submodule operates in the band-split domain (see
AudioProcessingImpl::ApmSubmoduleStates::RenderMultiBandSubModulesActive()).
There is a goal to remove the (expensive and unnecessary)
band-splitting from AudioMixer. This change helps accomplish that. (It
can't be done yet, because the actual limiter sub-component of APM
also operates in the band-split domain).
BUG=webrtc:6185
Review-Url: https://codereview.webrtc.org/2875623002
Cr-Commit-Position: refs/heads/master@{#18090}
In the windows audio device implementation, play block size should be
number of samples per 10ms times the number of channels. Meanwhile
RequestPlayoutData is expecting number of samples per channel in a
block, and we should pass in the per channel number here to avoid debug
check.
BUG=7627
Review-Url: https://codereview.webrtc.org/2876593003
Cr-Commit-Position: refs/heads/master@{#18088}
ios_framework_bundle does not have 'sources' but 'common_objc_headers'
and it was causins a couple of false positives.
BUG=webrtc:7514
NOTRY=True
Review-Url: https://codereview.webrtc.org/2872303003
Cr-Commit-Position: refs/heads/master@{#18084}
RTP packets can be padded with extra data at the end of the payload. The usable
payload length of the packet should then be reduced with the padding length,
since the padding must be discarded. This was not the case; instead, the entire
payload, including padding data, was forwarded to the audio channel and in the
end to the decoder.
A special case of padding is packets which are empty except for the padding.
That is, they carry no usable payload. These packets are sometimes used for
probing the network and were discarded in
RTPReceiverAudio::ParseAudioCodecSpecific. The result is that NetEq never sees
those empty packets, just the holes in the sequence number series; this can
throw off the target buffer calculations.
With this change, the empty (after removing the padding) packets are let through,
all the way down to NetEq, to a new method called NetEq::InsertEmptyPacket. This
method notifies the DelayManager that an empty packet was received.
BUG=webrtc:7610, webrtc:7625
Review-Url: https://codereview.webrtc.org/2870043003
Cr-Commit-Position: refs/heads/master@{#18083}
This CL makes the presubmit check less strict. We can modify untracked
headers but we cannot added them anymore.
In the meatime I am spawning a lot of bugs to fix the currently
untracked headers.
BUG=webrtc:7514
NOTRY=True
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2873223004
Cr-Commit-Position: refs/heads/master@{#18080}
