This flag enables support for Android Studio 3.0 which allows us to use
Java 8 features. Gradle is updated to version 4.1.0.
BUG=webrtc:8084
Review-Url: https://codereview.webrtc.org/2994123002
Cr-Commit-Position: refs/heads/master@{#19319}
This change implements GetWindowList() on X11. WindowCapturerLinux and
GetWindowUnderPoint() can share the logic of this function.
Bug: webrtc:7950
Change-Id: Ida746840d6f51d31e0470e5ae4955b6f5a4cfaf2
Reviewed-on: https://chromium-review.googlesource.com/606560
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19314}
Reason for revert:
The credentials for the linux_internal bot are fixed now.
Original issue's description:
> Reland of move linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2990233002/ )
>
> Reason for revert:
> linux_internal buildbucket is broken
>
> Original issue's description:
> > Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ )
> >
> > Reason for revert:
> > linux_internal now checks that the CL is authored by a googler before executing the tests
> >
> > Original issue's description:
> > > Remove linux_internal from the autoroller CQ.
> > >
> > > The CQ no longer has permission to schedule builds in linux_internal.
> > >
> > > NOTRY=True
> > > TBR=kjellander@webrtc.org
> > > BUG=None
> > >
> > > Review-Url: https://codereview.webrtc.org/2985933002
> > > Cr-Commit-Position: refs/heads/master@{#19178}
> > > Committed: 5ba9730265
> >
> > TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
> > BUG=None
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2990233002
> > Cr-Commit-Position: refs/heads/master@{#19240}
> > Committed: 367aaa7ca5
>
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2997523002
> Cr-Commit-Position: refs/heads/master@{#19260}
> Committed: 81cf5bbff9TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
Review-Url: https://codereview.webrtc.org/3001523002
Cr-Commit-Position: refs/heads/master@{#19312}
* EndToEndTest.InitialProbing had an uninitialized boolean.
* Both tests used RTC_DCHECK where one would normally expect an RTC_DCHECK.
BUG=webrtc:8085
Review-Url: https://codereview.webrtc.org/2998793002
Cr-Commit-Position: refs/heads/master@{#19309}
There exist a bug in the video_coding::PacketBuffer which triggers when a
frame is the same size as the buffer. A trivial workaround is to increase
the start size to something big so that this never happens in practice.
The bug has been fixed but we still want to test the workaround in ToT,
which is why this CL exist.
BUG=webrtc:8028, chromium:752886
R=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/2994093002 .
Cr-Commit-Position: refs/heads/master@{#19308}
This CL brings us one step closer to removing CodecDatabase and
GenericEncoder, by removing the static VCM::Codec(). Codec specific
methods are moved to video_encoder.cc (they already belonged to this
class) and getting default generic codec settings has been moved to a
test specific file.
This CL also makes video_encoder.h pass style guide and lint checks,
since these checks are triggered with the new video_encoder.cc file.
BUG=webrtc:8064
Review-Url: https://codereview.webrtc.org/2993923002
Cr-Commit-Position: refs/heads/master@{#19303}
That way, the debug printout will tell us which of x and y that was false.
BUG=none
Review-Url: https://codereview.webrtc.org/2988153003
Cr-Commit-Position: refs/heads/master@{#19297}
Reason for revert:
Broke downstream test that was waiting for 5 keyframes to be received within 10 seconds. Maybe the issue is that "stats_callback_->OnCompleteFrame(frame->num_references == 0, ..." was changed to "frame->is_keyframe()"?
Original issue's description:
> Request keyframes more frequently on stream start/decoding error.
>
> In this CL:
> - Added FrameObject::is_keyframe() convinience function.
> - Moved logic to request keyframes on decoding error from VideoReceived to
> VideoReceiveStream.
> - Added keyframe_required as a parameter to FrameBuffer::NextFrame.
>
> BUG=webrtc:8074
>
> Review-Url: https://codereview.webrtc.org/2993793002
> Cr-Commit-Position: refs/heads/master@{#19280}
> Committed: 26b4804358TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,philipel@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:8074
Review-Url: https://codereview.webrtc.org/2994043002
Cr-Commit-Position: refs/heads/master@{#19295}
When compiling webrtc's call.cc with VC++ 2017 (is_clang = false) the
following compile error occurs:
sequence_number_util.h(90): error C2672: 'rtc::SafeLt': no matching
overloaded function found
note: see reference to class template instantiation
'webrtc::SeqNumUnwrapper<T,M>' being compiled
This error is not associated with any particular instantiation of
SeqNumUnwrapper (there isn't one) and this undefined nature of 'T' seems
to be what confuses the compiler. When it tries to locate SafeLt for an
undefined type 'T' it gets confused.
SafeLt is unnecessary in this context and changing it to use the '<'
operator directly avoids the problem.
The bug has been reported to Microsoft.
BUG=chromium:753488
Review-Url: https://codereview.webrtc.org/2997623002
Cr-Commit-Position: refs/heads/master@{#19292}
This has been a frequent source of confusion, especially since the
method names don't match anything in the standard exactly.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2994733002
Cr-Commit-Position: refs/heads/master@{#19290}
The limit is based on the bandwidth delay product, but also adds some additional slack to compensate for the sawtooth-like BWE pattern and the slowness of the encoder rate control. The delay is estimated based on the time from sending a packet until an ack is received. Since acks are received in bursts (feedback is only sent periodically), a min filter is used to estimate the rtt.
Whenever the in flight bytes reaches the congestion window, the pacer is paused, which in turn will result in send-side queues growing. Eventually the encoders will be paused as the pacer queue grows large (currently 2 seconds).
BUG=webrtc:7926
Review-Url: https://codereview.webrtc.org/2918323002
Cr-Commit-Position: refs/heads/master@{#19289}
[This CL is work in progress.]
Wire up the rtp keep-alive in webrtc::Call::Config using new
SetRtpTransportParameters() method on RtpTransportInterface.
BUG=webrtc:7907
Review-Url: https://codereview.webrtc.org/2981513002
Cr-Commit-Position: refs/heads/master@{#19287}
In this CL:
- Added FrameObject::is_keyframe() convinience function.
- Moved logic to request keyframes on decoding error from VideoReceived to
VideoReceiveStream.
- Added keyframe_required as a parameter to FrameBuffer::NextFrame.
BUG=webrtc:8074
Review-Url: https://codereview.webrtc.org/2993793002
Cr-Commit-Position: refs/heads/master@{#19280}
The AsyncInvoker destructor waits for all invoked tasks to be complete
(in other words, all AsyncClosures to be destructed). They were using an
event to wake up the destructor, but a race made it possible for this
event to be dereferenced after it's destroyed.
This CL makes the event reference counted, such that if the destructor
runs right after AsyncClosure decrements "pending_invocations_",
setting the event will be a no-op, and the event will be destructed
in the AsyncClosure destructor.
This CL also fixes a deadlock that may occur for "re-entrant"
invocations. The deadlock occurs if the AsyncInvoker is destroyed on
thread A while a task on thread B is running, which AsyncInvokes a task
back on thread A.
This was causing pending_invocations_ to end up negative, because
an AsyncClosure that's never added to a thread's message queue (due to
the "destroying_" flag) caused the count to be decremented but not
incremented.
BUG=webrtc:7656
Review-Url: https://codereview.webrtc.org/2885143005
Cr-Commit-Position: refs/heads/master@{#19278}
The existing unity plugin (an example in webrtc codebase) does not support camera access on Android platform. This CL implements such functionality.
TBR=gyzhou@chromium.org
BUG=webrtc:8067
Review-Url: https://codereview.webrtc.org/2993273002
Cr-Commit-Position: refs/heads/master@{#19277}
During window capture on Windows 10, if the selected window is minimized,
ShouldUseScreenCapturer() still thinks it's on top and continue to do a
screencapture which is meaningless.
This cl will set |.is_top_window| with false to minimized window,then we
can skip doing any capture to it.
BUG=chromium:568835
Review-Url: https://codereview.webrtc.org/2997493002
Cr-Commit-Position: refs/heads/master@{#19276}
Found via supersize query:
size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')
This moves 90 symbols from .data -> .data.rel.ro (5.50kb)
BUG=chromium:747064
Review-Url: https://codereview.webrtc.org/2986163002
Cr-Commit-Position: refs/heads/master@{#19274}
A crash has been randomly detected across different versions. The NSImage
crashes the binary in its lockFocusFlipped() function. The suspicious issue is
that NSCursor::image() returns an invalid NSImage.
BUG=chromium:752036
Review-Url: https://codereview.webrtc.org/2993173003
Cr-Commit-Position: refs/heads/master@{#19273}
