Erik Språng
031ebc42e6
Increase RTP send buffer size from 64kb to 256kb.
...
Assuming 15Mbps video bitrate at 30fps, a single frame is 62500 bytes.
Add to that some fluctuations in encoder output rate and capture fps,
and frames can easily become larger than 64kb.
Given enough bandwidth and the bursty pacer, it will not be uncommon to
send the entire frame in one batch - and if the send buffer is at 64kb
then you will likely get packetloss already in the IPC packet socket,
even before the packet has reached the network card!
It's not entirely clear what the optimal size is, but given that the
receive buffer size was increased from 64kb to 256kb for high bandwidth
receive scenarios and had negligible negative effects I think it's
pretty safe to bump the send buffer to match.
There is a field trial available that can be used as circuit breaker
in case things turn south: WebRTC-SendBufferSizeBytes
Bug: webrtc:14780
Change-Id: I6c786d993181a882e6dce832ff56dc92d2a8a341
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290985
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39942}
2023-04-24 21:30:26 +00:00
chromium-webrtc-autoroll
6a34c75d5d
Roll chromium_revision 43b82356e4..fbcde4ef84 (1134651:1134788)
...
Change log: 43b82356e4..fbcde4ef8443b82356e4..fbcde4ef84e6be8e9377..304fd6d0cd71e9e15d4e..77af5d07d20742b59781..2482155040e43d55ad90..fae97ad6985676009b37..76af9e74bb8154d8e2be..9806414c155437caf87b..aa34142ee6cbcf55a40f..da5a1a8add43b82356e4..fbcde4ef84https://webrtc-review.googlesource.com/c/src/+/303180
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39941}
2023-04-24 20:44:43 +00:00
Andreas Pehrson
ba41b40461
webrtc_libyuv: Add support for more video types for consistency
...
Bug: webrtc:14830
Change-Id: I0998fb04a03745131f9f5cca878b0cdb46f3b62b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291529
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39940}
2023-04-24 19:06:25 +00:00
Jeremy Leconte
f9e3bdd2ce
Revert "Remove dependency of video_replay on TestADM."
...
This reverts commit 01716663a9837a26fa292fe70fdea353cbd01a67.
Reason for revert: breaking CallPerfTest
https://ci.chromium.org/ui/p/webrtc/builders/perf/Perf%20Android32%20(R%20Pixel5)/967/overview
Original change's description:
> Remove dependency of video_replay on TestADM.
>
> This should remove requirement to build TestADM in chromium build.
>
> Bug: b/272350185, webrtc:15081
> Change-Id: Iceb8862aa81099c22bd378ae692229f01ab3314c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302380
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#39934}
Bug: b/272350185, webrtc:15081
Change-Id: I73aa0fd3c3d8c244d20e5f29f5792a4c7d7e4165
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303160
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39939}
2023-04-24 19:02:23 +00:00
chromium-webrtc-autoroll
6c2f7602ca
Roll chromium_revision 0ed338af59..43b82356e4 (1134512:1134651)
...
Change log: 0ed338af59..43b82356e40ed338af59..43b82356e461c4b10212..71e9e15d4e8de181f514..0742b59781f882a7628e..e43d55ad90cb50f56348..5676009b37df2191d9ce..5437caf87b94fc7fddea..cbcf55a40f0ed338af59..43b82356e4https://webrtc-review.googlesource.com/c/src/+/303120
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39938}
2023-04-24 17:01:41 +00:00
Philipp Hancke
6a7bf10d60
Replace "rcvd" with "received" for readability
...
following guidance in
https://google.github.io/styleguide/cppguide.html#General_Naming_Rules
BUG=None
Change-Id: I105591a7f709d65a3d3320f7f44137d432cf7ce0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302282
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39937}
2023-04-24 15:30:07 +00:00
Artem Titov
eeae962997
Reland "Migrate TestAudioDeviceModule on AudioDeviceModuleImpl"
...
This reverts commit 69c8d3c843326aff9dee32cc639741c1cd7f8ae9.
Reason for revert: Reland with a fix
Original change's description:
> Revert "Migrate TestAudioDeviceModule on AudioDeviceModuleImpl"
>
> This reverts commit e42bf81486d2f08b6dcbf1442287202e937ce52b.
>
> Reason for revert: Breaks iOS simulator bots and thus blocks chromium roll, https://chromium-review.googlesource.com/c/chromium/src/+/4433814
>
> Original change's description:
> > Migrate TestAudioDeviceModule on AudioDeviceModuleImpl
> >
> > Bug: b/272350185
> > Change-Id: Ia3d85d6fa3b0d4809e987a39d60d3eb022687132
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300363
> > Commit-Queue: Artem Titov <titovartem@webrtc.org>
> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#39877}
>
> Bug: b/272350185
> Change-Id: I1e3b542fc1278797f283afedeae01cbb7412d353
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301701
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Auto-Submit: Christoffer Jansson <jansson@google.com>
> Owners-Override: Christoffer Jansson <jansson@google.com>
> Cr-Commit-Position: refs/heads/main@{#39881}
Bug: b/272350185
Change-Id: I809466306b2e1fd54c44b90311059c98a53ef8ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301704
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39936}
2023-04-24 14:42:08 +00:00
chromium-webrtc-autoroll
39e859901b
Roll chromium_revision 1cc6fa230c..0ed338af59 (1133778:1134512)
...
Change log: 1cc6fa230c..0ed338af591cc6fa230c..0ed338af59a7ef445859..e6be8e93778e40aaeb1b..61c4b102128d06fc2ffa..539a6f687364d1adcc57..307bd16360665c2e5429..2795322d5749f40887aa..8de181f51475567f4546..f882a7628e6b423834d7..cb50f56348https://chromium.googlesource.com/catapult.git/+log/f7a8b55f34..1aa5adbafb
* src/third_party/depot_tools: dec6fddc86..b5cec8c86726b0877163..df2191d9ce2a1c696af9..94fc7fddea1cc6fa230c..0ed338af59https://webrtc-review.googlesource.com/c/src/+/303040
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39935}
2023-04-24 13:50:49 +00:00
Artem Titov
01716663a9
Remove dependency of video_replay on TestADM.
...
This should remove requirement to build TestADM in chromium build.
Bug: b/272350185, webrtc:15081
Change-Id: Iceb8862aa81099c22bd378ae692229f01ab3314c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302380
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39934}
2023-04-24 13:17:45 +00:00
Jeremy Leconte
47701c8c9b
Chromium LocalRobolectricTestRunner has been removed.
...
This is a follow up on https://chromium-review.googlesource.com/c/chromium/src/+/44503 .
Change-Id: I28a0789a0af43cfac27081c9b5bcf695e9798910
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/303020
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39933}
2023-04-24 11:26:11 +00:00
Tommi
94774d475b
Call PrepareShutdown in the dtor just in case Close() hasn't been called
...
Bug: b/277912909
Change-Id: I0074de59f5d16d500795589a0c94ff4840ffe57a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302384
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39932}
2023-04-24 11:06:42 +00:00
Philipp Hancke
70fc5a2e41
stats: unify optional handling to use operator*
...
following https://abseil.io/tips/181#solution
BUG=None
Change-Id: I865572e42dff172fcf722383f3dde31dcc747220
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302341
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39931}
2023-04-24 10:58:04 +00:00
philipel
c22893b3f6
Add AV1 perf tests.
...
Bug: b/273502945
Change-Id: I3b1379c8757f4e1ea38d9575eb2a32d955f0643f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302401
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39930}
2023-04-24 10:45:15 +00:00
philipel
d1e5dedffe
Use DD encoder/decoder in RTC event log encoder/parser.
...
Bug: webrtc:14801
Change-Id: I7013c42765e81d147bf8284f8c29666e67fdb91f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296765
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39929}
2023-04-24 10:35:22 +00:00
Tommi
94e5817759
Guard FakeDataChannelController state with the network thread.
...
Tsan bots detected races since callbacks are being made on the network
thread but tests checked the state from the signaling thread.
Bug: none
Change-Id: If854e44159c56c0d12616e0b62ad92018291ed30
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302281
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39928}
2023-04-24 10:18:27 +00:00
Victor Boivie
daaa6ab5a8
dcsctp: Add handover state for zero checksum
...
This CL can prepare downstream projects for being aware of
this new handover state.
This was extracted from change 299076.
Bug: webrtc:14997
Change-Id: I35bfbe040ffbaa5d7266eb67d58078b66083337a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302980
Reviewed-by: Sergey Sukhanov <sergeysu@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39927}
2023-04-24 10:06:40 +00:00
Tommi
683f3165f9
Add slightly more constness to SourceFrame and the embedded AudioFrame
...
This makes it a bit more clear that values of member variables of
SourceFrame are never directly changed and that doing so is not an
intentional part of the design. Also made use of `SourceFrame` vs
`const SourceFrame` more consistent since the audio frame of a
`const SourceFrame` was being modified in some places.
Accessing the embedded AudioFrame can be done via the const
audio_frame() accessor or via the mutable_audio_frame() accessor when
modifying the frame is needed. This helps with clarifying later on
when downstream code paths such as ones that access the `packet_infos_`
data, can know that it won't be modified for the rest of the frame's
lifetime (thus avoiding having to make copies).
Bug: none
Change-Id: I175cec8fcdb85063239a5f9c299b7878c639f00e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302383
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39926}
2023-04-24 10:05:35 +00:00
Jeremy Leconte
4e0bdf550b
iOS64 Perf bot build15-a7 is replaced by mac-254-e504.
...
Change-Id: I65a0065bee7dad345668541eddcc7a53fec2dab3
Bug: b/278663917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302402
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39925}
2023-04-24 07:44:12 +00:00
webrtc-version-updater
b810a64db1
Update WebRTC code version (2023-04-24T04:05:22).
...
Bug: None
Change-Id: I51a2a0a8aaaffc8ff147d9055b081029776b666b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302940
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39924}
2023-04-24 06:02:33 +00:00
Victor Boivie
014cbed9d2
Revert "dcsctp: Negotiate zero checksum"
...
This reverts commit a736f30a5fddfa9a6af02a0a916da09bcac49d0d.
Due to a downstream project not supporting this
new handover state, it fails. Handover state needs
to be submitted first, then downstream project needs
to be updated, and finally the code changes can be
submitted.
Bug: webrtc:14997
Change-Id: I8551e349408d9bf4eb593cb948279d659467fe20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302821
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39923}
2023-04-23 22:25:44 +00:00
Artem Titov
e91c76875a
Complete move of TestADM into its own target
...
Bug: b/272350185, webrtc:15081
Change-Id: I1a7ffedae34790ed08c0205c713a650efd36273d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302340
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39922}
2023-04-21 18:33:33 +00:00
Sergey Silkin
0421294df0
Enable RTC mode in Google HW AV1 encoder
...
Bug: b/274179852
Change-Id: Id987fa8b73468532304f856bc97d40238f93b266
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302180
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39921}
2023-04-21 16:38:06 +00:00
Victor Boivie
a736f30a5f
dcsctp: Negotiate zero checksum
...
If configured, attempt to negotiate "zero checksum
acceptable" capability, which will make the outgoing
packets have a fixed checksum of zero. Received
packets will not be verified for a correct checksum
if it's zero.
Also includes some boilerplate:
- Setting capability in state cookie
- Adding capability to handover state
- Adding metric to know if the feature is used
This feature is not enabled by default, as it will be
first evaluated with an A/B experiment before making
it the default.
When the feature is enabled, lower CPU consumption for
both receiving and sending packets is expected. How
much depends on the architecture, as some architectures
have better support for generating CRC32 in hardware
than others.
Bug: webrtc:14997
Change-Id: If23f73e87220c7d42bd4f9a92772cda16bc18fcb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299076
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39920}
2023-04-21 15:31:35 +00:00
chromium-webrtc-autoroll
325b3caac6
Roll chromium_revision 2598ff6c3a..1cc6fa230c (1133653:1133778)
...
Change log: 2598ff6c3a..1cc6fa230c2598ff6c3a..1cc6fa230c827c543161..a7ef445859f78fc195a7..8e40aaeb1ba64df6cce2..64d1adcc5748d230ebc1..49f40887aada88a644b4..75567f45462a07492c50..6b423834d74f9f0278b3..26b0877163206447d5cb..2a1c696af92598ff6c3a..1cc6fa230chttps://webrtc-review.googlesource.com/c/src/+/302362
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39919}
2023-04-21 14:45:42 +00:00
Tommi
51c632c13b
Use GlobalSimulatedTimeController in more webrtc video engine unittests
...
This removes all "_WAIT" operations in the tests and all uses
of kTimeout for loop+poll check for values.
On my linux box, this also reduces the time it takes to run all
./rtc_media_unittests (in parallel) from about 3500ms, to ~50ms.
(longest running test was WebRtcVideoChannelBaseTest.GetStats)
Bug: none
Change-Id: If544aa10cb0281cb5e5e51fb654db5f45de871da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302343
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39918}
2023-04-21 14:41:27 +00:00
Sergey Silkin
691b447c53
Fix returns from IsSameSettings and IsSameRate in codec tests
...
Swap true/false.
Bug: webrtc:14852
Change-Id: Id82c0180d33bfc4e5237f4800c3e89fe8d17693f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302381
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39917}
2023-04-21 11:29:32 +00:00
Philipp Hancke
ff6cd53303
Reject stun urls with query parameters
...
for consistency with Chromium behavior, in particular
stun:host?transport=udp
gets rejected.
BUG=chromium:1385735
Change-Id: I85a141ecf72480bfa09d8354d6dcaef8ca0cdcff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299943
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39916}
2023-04-21 11:19:37 +00:00
chromium-webrtc-autoroll
7aa6a72dc6
Roll chromium_revision e0f3c7ef30..2598ff6c3a (1133548:1133653)
...
Change log: e0f3c7ef30..2598ff6c3ae0f3c7ef30..2598ff6c3a09a9fa99c1..827c5431614a2a31a17b..f78fc195a7b8ae314430..48d230ebc1592b965c70..da88a644b496a84a37ab..2a07492c5034f62b4af7..dec6fddc864d46c527b1..4f9f0278b3069e2f6512..206447d5cbe0f3c7ef30..2598ff6c3ahttps://webrtc-review.googlesource.com/c/src/+/302320
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39915}
2023-04-21 08:39:26 +00:00
Jared Siskin
802e8e5fdb
Format /rtc_base
...
git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^rtc_base/" | xargs clang-format -i ; git cl format
after landing: add to .git-blame-ignore-revs
Bug: webrtc:15082
Change-Id: I152228f7c7926adf95d2f3fbbe4178556fd75d0d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302061
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39914}
2023-04-21 06:17:42 +00:00
Jared Siskin
6f86f6af00
Format /sdk
...
git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^sdk/" | xargs clang-format -i ; git cl format
after landing: add to .git-blame-ignore-revs
Bug: webrtc:15082
Change-Id: If05d3c7555c4f2bf25e387249932787a93aa39c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302060
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39913}
2023-04-21 04:30:57 +00:00
chromium-webrtc-autoroll
7c0525b98b
Roll chromium_revision 5e503f835a..e0f3c7ef30 (1133404:1133548)
...
Change log: 5e503f835a..e0f3c7ef305e503f835a..e0f3c7ef30c9aac49040..09a9fa99c155ca141f6a..4a2a31a17b18366a135f..b8ae314430261cb0af7c..592b965c705793455d7e..96a84a37abhttps://chromium.googlesource.com/catapult.git/+log/843ad30cc3..f7a8b55f34
* src/third_party/depot_tools: 6b62f42578..34f62b4af7008a684110..4d46c527b1d0ffb2262f..069e2f65125e503f835a..e0f3c7ef30https://webrtc-review.googlesource.com/c/src/+/302168
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39912}
2023-04-21 03:05:54 +00:00
chromium-webrtc-autoroll
049b0dc7dd
Roll chromium_revision e4fe9c3c8c..5e503f835a (1133238:1133404)
...
Change log: e4fe9c3c8c..5e503f835ae4fe9c3c8c..5e503f835afa99d8341a..c9aac4904028e0d1b145..55ca141f6a374f57046c..18366a135fd30ecccc94..261cb0af7cef342ca072..5793455d7e464c51a035..77c2121f7ed6fa3d4969..008a6841108d2b7544dd..d0ffb2262fe4fe9c3c8c..5e503f835ahttps://webrtc-review.googlesource.com/c/src/+/302220
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39911}
2023-04-20 22:58:29 +00:00
Victor Boivie
3c6b46fc16
Reland "dcsctp: Support zero checksum packets"
...
This reverts commit 45eae346930aedbf4624d054e0633c94b397b8ec.
It was found not to be the root cause of the performance
regression, so it's safe to reland.
Bug: webrtc:14997
Change-Id: I67c90752875bf4071cbdd5adfa462a37f4d4ceab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302162
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39910}
2023-04-20 20:32:01 +00:00
chromium-webrtc-autoroll
4ae238770b
Roll chromium_revision cbece1e6d2..e4fe9c3c8c (1133058:1133238)
...
Change log: cbece1e6d2..e4fe9c3c8ccbece1e6d2..e4fe9c3c8cea16e6a0fc..fa99d8341a1c568faad1..28e0d1b145559b8716f3..a64df6cce2ff7a0efd85..374f57046cc208a52e42..d30ecccc94976dfa81bb..ef342ca072607284d719..6b62f4257842f0ad2275..d6fa3d49691e4bc72b8c..8d2b7544ddcbece1e6d2..e4fe9c3c8chttps://webrtc-review.googlesource.com/c/src/+/302164
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39909}
2023-04-20 18:19:44 +00:00
chromium-webrtc-autoroll
e2e70e5474
Roll chromium_revision 936fdee09e..cbece1e6d2 (1132874:1133058)
...
Change log: 936fdee09e..cbece1e6d2936fdee09e..cbece1e6d2181ecd1f50..ea16e6a0fcff99a858e2..1c568faad161e07bbba2..ff7a0efd859ab3d6e6a9..c208a52e423262d59a8f..976dfa81bb0d6cb8fa70..607284d7194da2dec19e..42f0ad22752e892d60b7..1e4bc72b8c936fdee09e..cbece1e6d2https://webrtc-review.googlesource.com/c/src/+/302160
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39908}
2023-04-20 13:14:44 +00:00
yingyingma
d3416972dd
Video: add new metric for VP9/AV1 hw encoding with softwareBRC
...
Record the RMSE of encoding bitrate diff from output stream to target
bitrate set by WebRTC when the AV1/VP9 stream is removed.
Design doc: https://docs.google.com/document/d/1tE7Fquj1U6CwZ01QxxjoCaJS2o0LFYyIxvstLDx0qB0/edit#heading=h.c11ebhaja9tg
Bug: chromium:1358750
Change-Id: Ifa6f5aacfa8f6b0835f4609f102ae3ae1ee2897e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298684
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39907}
2023-04-20 12:54:06 +00:00
Artem Titov
eba7cee1da
Extract TestADM into a separate target
...
Bug: b/272350185, webrtc:15104
Change-Id: I091b81d81506e0caad665522e872c5cccf45d8d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301980
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39906}
2023-04-20 10:45:37 +00:00
Danil Chapovalov
9e734a660b
Delete ReportBlock::cumulative_lost_signed accessor
...
cumulative lost is always signed now.
Bug: webrtc:9598
Change-Id: I7cf9f87c01a60fafc3fa6a9bdb84950343697193
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301940
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39905}
2023-04-20 10:39:37 +00:00
Markus Handell
527701a8f2
Increase tracing fidelity for investigation.
...
This CL adds tracing for investigating issues reported by
Intel when testing out VSyncDecoding.
Bug: chromium:1434747
Change-Id: If2f62fa4ac9fd2fba4e34daabcb5933a4cc395cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301982
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Auto-Submit: Markus Handell <handellm@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39904}
2023-04-20 09:42:10 +00:00
Jeremy Leconte
67f2109544
Revert "For AV1, disable error resilience on upper temporal layers. Error resilience is no longer required for upper temporal layers. Disabling error resilience on the upper layers leads to a ~2% PSNR BD-rate gain."
...
This reverts commit 2080dacfb7946daf79ecd3f69efbd0c9e08b9be2.
Reason for revert: This CL is causing a lot of flakiness on iOS bots
https://ci.chromium.org/p/webrtc/builders/ci/iOS%20Debug%20%28simulator%29
Original change's description:
> For AV1, disable error resilience on upper temporal layers. Error resilience is no longer required for upper temporal layers. Disabling error resilience on the upper layers leads to a ~2% PSNR BD-rate gain.
>
> Bug: webrtc:15106
> Change-Id: Id92d51defbd26c1a77e3c9fe19607e9db4a3e7c1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302001
> Reviewed-by: Marco Paniconi <marpan@webrtc.org>
> Commit-Queue: Michael Horowitz <mhoro@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#39900}
Bug: webrtc:15106
Change-Id: I24515280113ed6681c9766026ec24d689035c031
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301983
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Owners-Override: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39903}
2023-04-20 09:24:52 +00:00
chromium-webrtc-autoroll
c2c057480e
Roll chromium_revision 5a75056b63..936fdee09e (1132724:1132874)
...
Change log: 5a75056b63..936fdee09e5a75056b63..936fdee09e2b96884a37..181ecd1f5046b7561cc2..665c2e5429004e1cafbd..61e07bbba2d58ec188b8..9ab3d6e6a974e8addb2b..3262d59a8fhttps://chromium.googlesource.com/catapult.git/+log/c3a1432bec..843ad30cc3
* src/third_party/depot_tools: 20ca4c37b7..0d6cb8fa70ea9fca0add..8154d8e2bed32d008dfa..4da2dec19e800fe064b9..2e892d60b75a75056b63..936fdee09ehttps://webrtc-review.googlesource.com/c/src/+/302080
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39902}
2023-04-20 02:33:10 +00:00
Jared Siskin
c018bae807
Format /modules
...
git ls-files | grep -e "\(\.h\|\.cc\)$" | grep -e "^modules/" | xargs clang-format -i ; git cl format
after landing: add to .git-blame-ignore-revs
Bug: webrtc:15082
Change-Id: I2c3cd28740062794f8c10e39d8406aadb9e9a35a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301620
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Jared Siskin <jtsiskin@meta.com>
Cr-Commit-Position: refs/heads/main@{#39901}
2023-04-20 02:02:45 +00:00
Michael Horowitz
2080dacfb7
For AV1, disable error resilience on upper temporal layers. Error resilience is no longer required for upper temporal layers. Disabling error resilience on the upper layers leads to a ~2% PSNR BD-rate gain.
...
Bug: webrtc:15106
Change-Id: Id92d51defbd26c1a77e3c9fe19607e9db4a3e7c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/302001
Reviewed-by: Marco Paniconi <marpan@webrtc.org>
Commit-Queue: Michael Horowitz <mhoro@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39900}
2023-04-20 00:17:45 +00:00
chromium-webrtc-autoroll
ef86a0fee9
Roll chromium_revision d3519761e9..5a75056b63 (1132586:1132724)
...
Change log: d3519761e9..5a75056b63d3519761e9..5a75056b631e7ad05480..2b96884a370769821d3f..ff99a858e2814f705a5a..8d06fc2ffa8551b86d1c..bff81b702ff003e37b41..004e1cafbd48251cd5ec..d58ec188b82808e55c59..74e8addb2bhttps://boringssl.googlesource.com/boringssl.git/+log/c466222feb..6776d5cd8f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/16c787686d..c3a1432bec
* src/third_party/depot_tools: e4ff80f5cf..20ca4c37b7https://aomedia.googlesource.com/aom.git/+log/61fa302827..5a09038240
* src/third_party/perfetto: 045679ede7..d32d008dfa2763935b33..800fe064b9d3519761e9..5a75056b63https://webrtc-review.googlesource.com/c/src/+/302002
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39899}
2023-04-19 22:39:11 +00:00
Michael Horowitz
8a10dca8ff
Set AV1 default bitrate limits.
...
Bug: webrtc:15097
Change-Id: I9106665ccb9e980e9c28f56c8f376c6c0a3c9d35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301802
Commit-Queue: Michael Horowitz <mhoro@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39898}
2023-04-19 18:45:33 +00:00
chromium-webrtc-autoroll
adbd9e939b
Roll chromium_revision 4b1c4e0f93..d3519761e9 (1132473:1132586)
...
Change log: 4b1c4e0f93..d3519761e94b1c4e0f93..d3519761e9195fba17ce..1e7ad05480b95116a984..0769821d3f3b7484dfd4..f003e37b413d55f02029..48251cd5ecc03da605f1..2808e55c5907e96adfc3..045679ede737a3e1f214..2763935b334b1c4e0f93..d3519761e9https://webrtc-review.googlesource.com/c/src/+/302000
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39897}
2023-04-19 18:30:46 +00:00
chromium-webrtc-autoroll
1fdb40c00f
Roll chromium_revision f75b7d9681..4b1c4e0f93 (1132372:1132473)
...
Change log: f75b7d9681..4b1c4e0f93f75b7d9681..4b1c4e0f930b703288d3..195fba17ce8274e8356c..b95116a98452f3977ecb..559b8716f305bc2b06c4..3b7484dfd4d41e4601cd..c03da605f154762c2217..e4ff80f5cfef2774e07c..07e96adfc3732be6f342..37a3e1f214f75b7d9681..4b1c4e0f93https://webrtc-review.googlesource.com/c/src/+/301960
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39896}
2023-04-19 14:37:03 +00:00
Sergey Silkin
88429d572b
Account for stride when calculating buffer size
...
https://webrtc-review.googlesource.com/c/src/+/240680 made encoder aware of stride and slice height of input buffer but calculation of buffer size passed to queueInputBuffer() was not updated.
Bug: webrtc:13427
Change-Id: Iba8687f56eda148ac67b331d35c45317a4ec5c59
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301321
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39895}
2023-04-19 10:10:32 +00:00
Henrik Boström
f9ffd68d8e
Migrate PostTask+Wait to BlockingCall to avoid deadlock in DegradedCall.
...
The deadlock happens when the WebRtcCombinedNetworkAndWorkerThread
experiment is running because the worker thread doing the PostTask is
the same thread as the network thread. When using BlockingCall instead
this method will avoid the PostTask and just execute in-line instead
if the experiment is running and otherwise do what the old path did.
As per webrtc:15099, we do not want to increase uses of rtc::Thread in
general, and adding more block-invokes in is also discouraged
(webrtc:12649) so instead of adding new methods to TaskQueueBase we
simply do a static_cast<rtc::Thread*>.
When WebRtcCombinedNetworkAndWorkerThread has launched the blocking
call can be removed because then we're on a single thread always.
Bug: webrtc:15098
Change-Id: I6dcc09bcf6ee0ad12e4beffef3b206989265540b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301880
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39894}
2023-04-19 09:40:33 +00:00
chromium-webrtc-autoroll
2c0689ffad
Roll chromium_revision 421628df87..f75b7d9681 (1132248:1132372)
...
Change log: 421628df87..f75b7d9681421628df87..f75b7d968160d5d53e84..0b703288d3bf9ef55ba8..8274e8356cedb60d9b96..05bc2b06c4d836814524..3d55f0202939fc3a0c85..d41e4601cd9e36ef60d0..54762c22175b0479ae0b..732be6f342421628df87..f75b7d9681https://webrtc-review.googlesource.com/c/src/+/301841
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#39893}
2023-04-19 08:21:13 +00:00
