admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete ReportBlock::cumulative_lost_signed accessor

Browse Source 
cumulative lost is always signed now.

Bug: webrtc:9598
Change-Id: I7cf9f87c01a60fafc3fa6a9bdb84950343697193
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301940
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39905}
This commit is contained in:
Danil Chapovalov 2023-04-19 14:18:10 +02:00 committed by WebRTC LUCI CQ
parent 527701a8f2
commit 9e734a660b
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/rtp_rtcp/source/rtcp_packet/report_block.h
View File

@ -49,9 +49,6 @@ class ReportBlock {
uint32_t source_ssrc() const { return source_ssrc_; }
uint8_t fraction_lost() const { return fraction_lost_; }
[[deprecated]] int32_t cumulative_lost_signed() const {
return cumulative_lost_;
}
int32_t cumulative_lost() const { return cumulative_lost_; }
uint32_t extended_high_seq_num() const { return extended_high_seq_num_; }
uint32_t jitter() const { return jitter_; }

2
rtc_tools/rtc_event_log_visualizer/main.cc
View File

@ -399,7 +399,7 @@ int main(int argc, char* argv[]) {
"Fraction lost (outgoing RTCP)", "Loss rate (percent)", plot);
});
auto GetCumulativeLost = [](const webrtc::rtcp::ReportBlock& block) -> float {
return block.cumulative_lost_signed();
return block.cumulative_lost();
};
plots.RegisterPlot("incoming_rtcp_cumulative_lost", [&](Plot* plot) {
analyzer.CreateSenderAndReceiverReportPlot(