From 9e734a660bf530394952e96a347bdea0465f5204 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Wed, 19 Apr 2023 14:18:10 +0200 Subject: [PATCH] Delete ReportBlock::cumulative_lost_signed accessor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cumulative lost is always signed now. Bug: webrtc:9598 Change-Id: I7cf9f87c01a60fafc3fa6a9bdb84950343697193 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/301940 Auto-Submit: Danil Chapovalov Reviewed-by: Björn Terelius Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#39905} --- modules/rtp_rtcp/source/rtcp_packet/report_block.h | 3 --- rtc_tools/rtc_event_log_visualizer/main.cc | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/modules/rtp_rtcp/source/rtcp_packet/report_block.h b/modules/rtp_rtcp/source/rtcp_packet/report_block.h index 6ed4f65c0b..b49219eceb 100644 --- a/modules/rtp_rtcp/source/rtcp_packet/report_block.h +++ b/modules/rtp_rtcp/source/rtcp_packet/report_block.h @@ -49,9 +49,6 @@ class ReportBlock { uint32_t source_ssrc() const { return source_ssrc_; } uint8_t fraction_lost() const { return fraction_lost_; } - [[deprecated]] int32_t cumulative_lost_signed() const { - return cumulative_lost_; - } int32_t cumulative_lost() const { return cumulative_lost_; } uint32_t extended_high_seq_num() const { return extended_high_seq_num_; } uint32_t jitter() const { return jitter_; } diff --git a/rtc_tools/rtc_event_log_visualizer/main.cc b/rtc_tools/rtc_event_log_visualizer/main.cc index 4988808cab..9fdc554cb5 100644 --- a/rtc_tools/rtc_event_log_visualizer/main.cc +++ b/rtc_tools/rtc_event_log_visualizer/main.cc @@ -399,7 +399,7 @@ int main(int argc, char* argv[]) { "Fraction lost (outgoing RTCP)", "Loss rate (percent)", plot); }); auto GetCumulativeLost = [](const webrtc::rtcp::ReportBlock& block) -> float { - return block.cumulative_lost_signed(); + return block.cumulative_lost(); }; plots.RegisterPlot("incoming_rtcp_cumulative_lost", [&](Plot* plot) { analyzer.CreateSenderAndReceiverReportPlot(