fbd0ddb32e
As requested by a CEF hosted application (https://crbug.com/1406331) who want to be able to limit the number of threads in a controlled environment, this CL adds a flag to control the max limit per encoder. For plumbing-reasons, this is placed in VideoEncoder::Settings but with a note that this is considered an experimental API with limited support. For now only LibvpxVp8Encoder uses it and there are no plans to roll this out. I have manually confirmed this is working with printf debugging, --force-fieldtrials=WebRTC-VideoEncoderSettings/encoder_thread_limit:2 and https://jsfiddle.net/henbos/2bd6m7Lt/ Bug: chromium:1406331 Change-Id: Ib02bd83e2071034874843d3aaa0d3b0adc5bbf46 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293960 Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39349}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.