f8b5bfeaf2
"warning: control reaches end of non-void function [-Wreturn-type]" Reported by gcc (8.3) In all the reported cases, the end of function is never actually reached. Add RTC_CHECK(false) to ensure the compiler is aware that this path is a dead-end. Bug: webrtc:12008 Change-Id: I7f816fde3d1897ed2774057c7e05da66e1895e60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189784 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Fabien VALLÉE <fabien.vallee@netgem.com> Cr-Commit-Position: refs/heads/master@{#32503}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.