admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix "control reaches end of non-void function" warnings

Browse Source 
"warning: control reaches end of non-void function [-Wreturn-type]"
Reported by gcc (8.3)

In all the reported cases, the end of function is never actually
reached. Add RTC_CHECK(false) to ensure the compiler is aware that
this path is a dead-end.

Bug: webrtc:12008
Change-Id: I7f816fde3d1897ed2774057c7e05da66e1895e60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189784
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Fabien VALLÉE <fabien.vallee@netgem.com>
Cr-Commit-Position: refs/heads/master@{#32503}
This commit is contained in:
Fabien Vallée 2020-10-22 10:08:50 +02:00 committed by Commit Bot
parent aa83cc7fda
commit f8b5bfeaf2
23 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -122,6 +122,7 @@ Life On Air Inc. <*@lifeonair.com>
Microsoft Corporation <*@microsoft.com>
MIPS Technologies <*@mips.com>
Mozilla Foundation <*@mozilla.com>
Netgem S.A. <*@netgem.com>
NVIDIA Corporation <*@nvidia.com>
Opera Software ASA <*@opera.com>
Optical Tone Ltd <*@opticaltone.com>

1
api/adaptation/BUILD.gn
View File

@ -16,6 +16,7 @@ rtc_source_set("resource_adaptation_api") {
]
deps = [
"../../api:scoped_refptr",
"../../rtc_base:checks",
"../../rtc_base:refcount",
"../../rtc_base:rtc_base_approved",
"../../rtc_base/system:rtc_export",

3
api/adaptation/resource.cc
View File

@ -10,6 +10,8 @@
#include "api/adaptation/resource.h"
#include "rtc_base/checks.h"
namespace webrtc {
const char* ResourceUsageStateToString(ResourceUsageState usage_state) {
@ -19,6 +21,7 @@ const char* ResourceUsageStateToString(ResourceUsageState usage_state) {
case ResourceUsageState::kUnderuse:
return "kUnderuse";
}
RTC_CHECK(false);
}
ResourceListener::~ResourceListener() {}

1
api/rtp_parameters.cc
View File

@ -30,6 +30,7 @@ const char* DegradationPreferenceToString(
case DegradationPreference::BALANCED:
return "balanced";
}
RTC_CHECK(false);
}
const double kDefaultBitratePriority = 1.0;

1
api/video_codecs/video_codec.cc
View File

@ -120,6 +120,7 @@ const char* CodecTypeToPayloadString(VideoCodecType type) {
case kVideoCodecGeneric:
return kPayloadNameGeneric;
}
RTC_CHECK(false);
}
VideoCodecType PayloadStringToCodecType(const std::string& name) {

3
api/video_codecs/video_encoder_software_fallback_wrapper.cc
View File

@ -162,6 +162,7 @@ class VideoEncoderSoftwareFallbackWrapper final : public VideoEncoder {
case EncoderState::kForcedFallback:
return fallback_encoder_.get();
}
RTC_CHECK(false);
}
// Updates encoder with last observed parameters, such as callbacks, rates,
@ -345,7 +346,9 @@ int32_t VideoEncoderSoftwareFallbackWrapper::Encode(
case EncoderState::kForcedFallback:
return fallback_encoder_->Encode(frame, frame_types);
}
RTC_CHECK(false);
}
int32_t VideoEncoderSoftwareFallbackWrapper::EncodeWithMainEncoder(
const VideoFrame& frame,
const std::vector<VideoFrameType>* frame_types) {

6
call/adaptation/video_stream_adapter.cc
View File

@ -162,6 +162,7 @@ const char* Adaptation::StatusToString(Adaptation::Status status) {
case Status::kRejectedByConstraint:
return "kRejectedByConstraint";
}
RTC_CHECK(false);
}
Adaptation::Adaptation(int validation_id,
@ -381,6 +382,7 @@ VideoStreamAdapter::RestrictionsOrState VideoStreamAdapter::GetAdaptationUpStep(
case DegradationPreference::DISABLED:
return Adaptation::Status::kAdaptationDisabled;
}
RTC_CHECK(false);
}
Adaptation VideoStreamAdapter::GetAdaptationDown() {
@ -460,6 +462,7 @@ VideoStreamAdapter::GetAdaptationDownStep(
case DegradationPreference::DISABLED:
return Adaptation::Status::kAdaptationDisabled;
}
RTC_CHECK(false);
}
VideoStreamAdapter::RestrictionsOrState VideoStreamAdapter::DecreaseResolution(
@ -597,9 +600,8 @@ Adaptation VideoStreamAdapter::GetAdaptDownResolution() {
return RestrictionsOrStateToAdaptation(
GetAdaptDownResolutionStepForBalanced(input_state), input_state);
}
default:
RTC_NOTREACHED();
}
RTC_CHECK(false);
}
VideoStreamAdapter::RestrictionsOrState

1
call/simulated_network.cc
View File

@ -77,6 +77,7 @@ bool CoDelSimulation::DropDequeuedPacket(Timestamp now,
}
return false;
}
RTC_CHECK(false);
}
SimulatedNetwork::SimulatedNetwork(Config config, uint64_t random_seed)

1
call/video_send_stream.cc
View File

@ -28,6 +28,7 @@ const char* StreamTypeToString(VideoSendStream::StreamStats::StreamType type) {
case VideoSendStream::StreamStats::StreamType::kFlexfec:
return "flexfec";
}
RTC_CHECK(false);
}
} // namespace

1
media/base/rtp_utils.cc
View File

@ -323,6 +323,7 @@ absl::string_view RtpPacketTypeToString(RtpPacketType packet_type) {
case RtpPacketType::kUnknown:
return "Unknown";
}
RTC_CHECK(false);
}
RtpPacketType InferRtpPacketType(rtc::ArrayView<const char> packet) {

1
modules/audio_processing/agc2/adaptive_mode_level_estimator.cc
View File

@ -42,6 +42,7 @@ float GetLevel(const VadLevelAnalyzer::Result& vad_level,
return vad_level.peak_dbfs;
break;
}
RTC_CHECK(false);
}
} // namespace

4
modules/audio_processing/audio_processing_impl.cc
View File

@ -114,6 +114,7 @@ GainControl::Mode Agc1ConfigModeToInterfaceMode(
case Agc1Config::kFixedDigital:
return GainControl::kFixedDigital;
}
RTC_CHECK(false);
}
// Maximum lengths that frame of samples being passed from the render side to
@ -1825,9 +1826,8 @@ void AudioProcessingImpl::InitializeNoiseSuppressor() {
return NsConfig::SuppressionLevel::k18dB;
case NoiseSuppresionConfig::kVeryHigh:
return NsConfig::SuppressionLevel::k21dB;
default:
RTC_NOTREACHED();
}
RTC_CHECK(false);
};
NsConfig cfg;

3
modules/audio_processing/include/audio_processing.cc
View File

@ -31,6 +31,7 @@ std::string NoiseSuppressionLevelToString(
case AudioProcessing::Config::NoiseSuppression::Level::kVeryHigh:
return "VeryHigh";
}
RTC_CHECK(false);
}
std::string GainController1ModeToString(const Agc1Config::Mode& mode) {
@ -42,6 +43,7 @@ std::string GainController1ModeToString(const Agc1Config::Mode& mode) {
case Agc1Config::Mode::kFixedDigital:
return "FixedDigital";
}
RTC_CHECK(false);
}
std::string GainController2LevelEstimatorToString(
@ -52,6 +54,7 @@ std::string GainController2LevelEstimatorToString(
case Agc2Config::LevelEstimator::kPeak:
return "Peak";
}
RTC_CHECK(false);
}
int GetDefaultMaxInternalRate() {

1
modules/pacing/pacing_controller.cc
View File

@ -84,6 +84,7 @@ int GetPriorityForType(RtpPacketMediaType type) {
// BWE high.
return kFirstPriority + 4;
}
RTC_CHECK(false);
}
} // namespace

1
modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc
View File

@ -37,6 +37,7 @@ std::unique_ptr<VideoRtpDepacketizer> CreateVideoRtpDepacketizer(
case kVideoCodecMultiplex:
return std::make_unique<VideoRtpDepacketizerGeneric>();
}
RTC_CHECK(false);
}
} // namespace webrtc

1
modules/rtp_rtcp/source/rtp_sender.cc
View File

@ -128,6 +128,7 @@ bool IsNonVolatile(RTPExtensionType type) {
RTC_NOTREACHED();
return false;
}
RTC_CHECK(false);
}
bool HasBweExtension(const RtpHeaderExtensionMap& extensions_map) {

1
modules/rtp_rtcp/source/rtp_sender_audio.cc
View File

@ -46,6 +46,7 @@ const char* FrameTypeToString(AudioFrameType frame_type) {
case AudioFrameType::kAudioFrameCN:
return "audio_cn";
}
RTC_CHECK(false);
}
#endif

1
modules/video_coding/codecs/vp8/temporal_layers_checker.cc
View File

@ -29,6 +29,7 @@ TemporalLayersChecker::CreateTemporalLayersChecker(Vp8TemporalLayersType type,
// Conference mode temporal layering for screen content in base stream.
return std::make_unique<TemporalLayersChecker>(num_temporal_layers);
}
RTC_CHECK(false);
}
TemporalLayersChecker::TemporalLayersChecker(int num_temporal_layers)

1
pc/dtls_transport.cc
View File

@ -31,6 +31,7 @@ DtlsTransportState TranslateState(cricket::DtlsTransportState internal_state) {
case cricket::DTLS_TRANSPORT_FAILED:
return DtlsTransportState::kFailed;
}
RTC_CHECK(false);
}
} // namespace

4
pc/media_session.cc
View File

@ -1818,6 +1818,7 @@ const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForOffer(
case RtpTransceiverDirection::kRecvOnly:
return audio_recv_codecs_;
}
RTC_CHECK(false);
}
const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForAnswer(
@ -1836,6 +1837,7 @@ const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForAnswer(
case RtpTransceiverDirection::kRecvOnly:
return audio_recv_codecs_;
}
RTC_CHECK(false);
}
const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForOffer(
@ -1851,6 +1853,7 @@ const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForOffer(
case RtpTransceiverDirection::kRecvOnly:
return video_recv_codecs_;
}
RTC_CHECK(false);
}
const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForAnswer(
@ -1869,6 +1872,7 @@ const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForAnswer(
case RtpTransceiverDirection::kRecvOnly:
return video_recv_codecs_;
}
RTC_CHECK(false);
}
void MergeCodecsFromDescription(

1
pc/rtc_stats_collector.cc
View File

@ -216,6 +216,7 @@ const char* QualityLimitationReasonToRTCQualityLimitationReason(
case QualityLimitationReason::kOther:
return RTCQualityLimitationReason::kOther;
}
RTC_CHECK(false);
}
double DoubleAudioLevelFromIntAudioLevel(int audio_level) {

3
rtc_base/network_monitor.cc
View File

@ -10,6 +10,8 @@
#include "rtc_base/network_monitor.h"
#include "rtc_base/checks.h"
namespace rtc {
const char* NetworkPreferenceToString(NetworkPreference preference) {
@ -19,6 +21,7 @@ const char* NetworkPreferenceToString(NetworkPreference preference) {
case NetworkPreference::NOT_PREFERRED:
return "NOT_PREFERRED";
}
RTC_CHECK(false);
}
NetworkMonitorInterface::NetworkMonitorInterface() {}

1
video/adaptation/video_stream_encoder_resource_manager.cc
View File

@ -55,6 +55,7 @@ std::string ToString(VideoAdaptationReason reason) {
case VideoAdaptationReason::kCpu:
return "cpu";
}
RTC_CHECK(false);
}
} // namespace