diff --git a/AUTHORS b/AUTHORS index c37a03a307..74b1faef35 100644 --- a/AUTHORS +++ b/AUTHORS @@ -122,6 +122,7 @@ Life On Air Inc. <*@lifeonair.com> Microsoft Corporation <*@microsoft.com> MIPS Technologies <*@mips.com> Mozilla Foundation <*@mozilla.com> +Netgem S.A. <*@netgem.com> NVIDIA Corporation <*@nvidia.com> Opera Software ASA <*@opera.com> Optical Tone Ltd <*@opticaltone.com> diff --git a/api/adaptation/BUILD.gn b/api/adaptation/BUILD.gn index dc4c73711e..2cba5f407e 100644 --- a/api/adaptation/BUILD.gn +++ b/api/adaptation/BUILD.gn @@ -16,6 +16,7 @@ rtc_source_set("resource_adaptation_api") { ] deps = [ "../../api:scoped_refptr", + "../../rtc_base:checks", "../../rtc_base:refcount", "../../rtc_base:rtc_base_approved", "../../rtc_base/system:rtc_export", diff --git a/api/adaptation/resource.cc b/api/adaptation/resource.cc index 0a9c83a311..c6a7e327b3 100644 --- a/api/adaptation/resource.cc +++ b/api/adaptation/resource.cc @@ -10,6 +10,8 @@ #include "api/adaptation/resource.h" +#include "rtc_base/checks.h" + namespace webrtc { const char* ResourceUsageStateToString(ResourceUsageState usage_state) { @@ -19,6 +21,7 @@ const char* ResourceUsageStateToString(ResourceUsageState usage_state) { case ResourceUsageState::kUnderuse: return "kUnderuse"; } + RTC_CHECK(false); } ResourceListener::~ResourceListener() {} diff --git a/api/rtp_parameters.cc b/api/rtp_parameters.cc index 57aa784098..f22ed67402 100644 --- a/api/rtp_parameters.cc +++ b/api/rtp_parameters.cc @@ -30,6 +30,7 @@ const char* DegradationPreferenceToString( case DegradationPreference::BALANCED: return "balanced"; } + RTC_CHECK(false); } const double kDefaultBitratePriority = 1.0; diff --git a/api/video_codecs/video_codec.cc b/api/video_codecs/video_codec.cc index 490eced4e0..ecc569978b 100644 --- a/api/video_codecs/video_codec.cc +++ b/api/video_codecs/video_codec.cc @@ -120,6 +120,7 @@ const char* CodecTypeToPayloadString(VideoCodecType type) { case kVideoCodecGeneric: return kPayloadNameGeneric; } + RTC_CHECK(false); } VideoCodecType PayloadStringToCodecType(const std::string& name) { diff --git a/api/video_codecs/video_encoder_software_fallback_wrapper.cc b/api/video_codecs/video_encoder_software_fallback_wrapper.cc index 54f4731e8d..bb97d3087b 100644 --- a/api/video_codecs/video_encoder_software_fallback_wrapper.cc +++ b/api/video_codecs/video_encoder_software_fallback_wrapper.cc @@ -162,6 +162,7 @@ class VideoEncoderSoftwareFallbackWrapper final : public VideoEncoder { case EncoderState::kForcedFallback: return fallback_encoder_.get(); } + RTC_CHECK(false); } // Updates encoder with last observed parameters, such as callbacks, rates, @@ -345,7 +346,9 @@ int32_t VideoEncoderSoftwareFallbackWrapper::Encode( case EncoderState::kForcedFallback: return fallback_encoder_->Encode(frame, frame_types); } + RTC_CHECK(false); } + int32_t VideoEncoderSoftwareFallbackWrapper::EncodeWithMainEncoder( const VideoFrame& frame, const std::vector* frame_types) { diff --git a/call/adaptation/video_stream_adapter.cc b/call/adaptation/video_stream_adapter.cc index 272fb6d85b..b79d217e3f 100644 --- a/call/adaptation/video_stream_adapter.cc +++ b/call/adaptation/video_stream_adapter.cc @@ -162,6 +162,7 @@ const char* Adaptation::StatusToString(Adaptation::Status status) { case Status::kRejectedByConstraint: return "kRejectedByConstraint"; } + RTC_CHECK(false); } Adaptation::Adaptation(int validation_id, @@ -381,6 +382,7 @@ VideoStreamAdapter::RestrictionsOrState VideoStreamAdapter::GetAdaptationUpStep( case DegradationPreference::DISABLED: return Adaptation::Status::kAdaptationDisabled; } + RTC_CHECK(false); } Adaptation VideoStreamAdapter::GetAdaptationDown() { @@ -460,6 +462,7 @@ VideoStreamAdapter::GetAdaptationDownStep( case DegradationPreference::DISABLED: return Adaptation::Status::kAdaptationDisabled; } + RTC_CHECK(false); } VideoStreamAdapter::RestrictionsOrState VideoStreamAdapter::DecreaseResolution( @@ -597,9 +600,8 @@ Adaptation VideoStreamAdapter::GetAdaptDownResolution() { return RestrictionsOrStateToAdaptation( GetAdaptDownResolutionStepForBalanced(input_state), input_state); } - default: - RTC_NOTREACHED(); } + RTC_CHECK(false); } VideoStreamAdapter::RestrictionsOrState diff --git a/call/simulated_network.cc b/call/simulated_network.cc index 2ed9140fa5..86e27122fe 100644 --- a/call/simulated_network.cc +++ b/call/simulated_network.cc @@ -77,6 +77,7 @@ bool CoDelSimulation::DropDequeuedPacket(Timestamp now, } return false; } + RTC_CHECK(false); } SimulatedNetwork::SimulatedNetwork(Config config, uint64_t random_seed) diff --git a/call/video_send_stream.cc b/call/video_send_stream.cc index a4b6744918..d3e36949a9 100644 --- a/call/video_send_stream.cc +++ b/call/video_send_stream.cc @@ -28,6 +28,7 @@ const char* StreamTypeToString(VideoSendStream::StreamStats::StreamType type) { case VideoSendStream::StreamStats::StreamType::kFlexfec: return "flexfec"; } + RTC_CHECK(false); } } // namespace diff --git a/media/base/rtp_utils.cc b/media/base/rtp_utils.cc index 4a2b3267cc..0d18c1e9e8 100644 --- a/media/base/rtp_utils.cc +++ b/media/base/rtp_utils.cc @@ -323,6 +323,7 @@ absl::string_view RtpPacketTypeToString(RtpPacketType packet_type) { case RtpPacketType::kUnknown: return "Unknown"; } + RTC_CHECK(false); } RtpPacketType InferRtpPacketType(rtc::ArrayView packet) { diff --git a/modules/audio_processing/agc2/adaptive_mode_level_estimator.cc b/modules/audio_processing/agc2/adaptive_mode_level_estimator.cc index f09f63bf2f..2d9c3e1f8f 100644 --- a/modules/audio_processing/agc2/adaptive_mode_level_estimator.cc +++ b/modules/audio_processing/agc2/adaptive_mode_level_estimator.cc @@ -42,6 +42,7 @@ float GetLevel(const VadLevelAnalyzer::Result& vad_level, return vad_level.peak_dbfs; break; } + RTC_CHECK(false); } } // namespace diff --git a/modules/audio_processing/audio_processing_impl.cc b/modules/audio_processing/audio_processing_impl.cc index 849a0febdc..33f21882a6 100644 --- a/modules/audio_processing/audio_processing_impl.cc +++ b/modules/audio_processing/audio_processing_impl.cc @@ -114,6 +114,7 @@ GainControl::Mode Agc1ConfigModeToInterfaceMode( case Agc1Config::kFixedDigital: return GainControl::kFixedDigital; } + RTC_CHECK(false); } // Maximum lengths that frame of samples being passed from the render side to @@ -1825,9 +1826,8 @@ void AudioProcessingImpl::InitializeNoiseSuppressor() { return NsConfig::SuppressionLevel::k18dB; case NoiseSuppresionConfig::kVeryHigh: return NsConfig::SuppressionLevel::k21dB; - default: - RTC_NOTREACHED(); } + RTC_CHECK(false); }; NsConfig cfg; diff --git a/modules/audio_processing/include/audio_processing.cc b/modules/audio_processing/include/audio_processing.cc index 3e5f6ed46c..105364270e 100644 --- a/modules/audio_processing/include/audio_processing.cc +++ b/modules/audio_processing/include/audio_processing.cc @@ -31,6 +31,7 @@ std::string NoiseSuppressionLevelToString( case AudioProcessing::Config::NoiseSuppression::Level::kVeryHigh: return "VeryHigh"; } + RTC_CHECK(false); } std::string GainController1ModeToString(const Agc1Config::Mode& mode) { @@ -42,6 +43,7 @@ std::string GainController1ModeToString(const Agc1Config::Mode& mode) { case Agc1Config::Mode::kFixedDigital: return "FixedDigital"; } + RTC_CHECK(false); } std::string GainController2LevelEstimatorToString( @@ -52,6 +54,7 @@ std::string GainController2LevelEstimatorToString( case Agc2Config::LevelEstimator::kPeak: return "Peak"; } + RTC_CHECK(false); } int GetDefaultMaxInternalRate() { diff --git a/modules/pacing/pacing_controller.cc b/modules/pacing/pacing_controller.cc index 133c97fe83..bef0d2f93d 100644 --- a/modules/pacing/pacing_controller.cc +++ b/modules/pacing/pacing_controller.cc @@ -84,6 +84,7 @@ int GetPriorityForType(RtpPacketMediaType type) { // BWE high. return kFirstPriority + 4; } + RTC_CHECK(false); } } // namespace diff --git a/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc b/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc index 724ad8c42e..b44322baa5 100644 --- a/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc +++ b/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc @@ -37,6 +37,7 @@ std::unique_ptr CreateVideoRtpDepacketizer( case kVideoCodecMultiplex: return std::make_unique(); } + RTC_CHECK(false); } } // namespace webrtc diff --git a/modules/rtp_rtcp/source/rtp_sender.cc b/modules/rtp_rtcp/source/rtp_sender.cc index b72110e4f2..3d1b381675 100644 --- a/modules/rtp_rtcp/source/rtp_sender.cc +++ b/modules/rtp_rtcp/source/rtp_sender.cc @@ -128,6 +128,7 @@ bool IsNonVolatile(RTPExtensionType type) { RTC_NOTREACHED(); return false; } + RTC_CHECK(false); } bool HasBweExtension(const RtpHeaderExtensionMap& extensions_map) { diff --git a/modules/rtp_rtcp/source/rtp_sender_audio.cc b/modules/rtp_rtcp/source/rtp_sender_audio.cc index 2ff1df6d4f..16a1130334 100644 --- a/modules/rtp_rtcp/source/rtp_sender_audio.cc +++ b/modules/rtp_rtcp/source/rtp_sender_audio.cc @@ -46,6 +46,7 @@ const char* FrameTypeToString(AudioFrameType frame_type) { case AudioFrameType::kAudioFrameCN: return "audio_cn"; } + RTC_CHECK(false); } #endif diff --git a/modules/video_coding/codecs/vp8/temporal_layers_checker.cc b/modules/video_coding/codecs/vp8/temporal_layers_checker.cc index 53a68bd5e8..540cfa354a 100644 --- a/modules/video_coding/codecs/vp8/temporal_layers_checker.cc +++ b/modules/video_coding/codecs/vp8/temporal_layers_checker.cc @@ -29,6 +29,7 @@ TemporalLayersChecker::CreateTemporalLayersChecker(Vp8TemporalLayersType type, // Conference mode temporal layering for screen content in base stream. return std::make_unique(num_temporal_layers); } + RTC_CHECK(false); } TemporalLayersChecker::TemporalLayersChecker(int num_temporal_layers) diff --git a/pc/dtls_transport.cc b/pc/dtls_transport.cc index f0882de3be..844063d00d 100644 --- a/pc/dtls_transport.cc +++ b/pc/dtls_transport.cc @@ -31,6 +31,7 @@ DtlsTransportState TranslateState(cricket::DtlsTransportState internal_state) { case cricket::DTLS_TRANSPORT_FAILED: return DtlsTransportState::kFailed; } + RTC_CHECK(false); } } // namespace diff --git a/pc/media_session.cc b/pc/media_session.cc index 558cf32f19..6e9a7c147c 100644 --- a/pc/media_session.cc +++ b/pc/media_session.cc @@ -1818,6 +1818,7 @@ const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForOffer( case RtpTransceiverDirection::kRecvOnly: return audio_recv_codecs_; } + RTC_CHECK(false); } const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForAnswer( @@ -1836,6 +1837,7 @@ const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForAnswer( case RtpTransceiverDirection::kRecvOnly: return audio_recv_codecs_; } + RTC_CHECK(false); } const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForOffer( @@ -1851,6 +1853,7 @@ const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForOffer( case RtpTransceiverDirection::kRecvOnly: return video_recv_codecs_; } + RTC_CHECK(false); } const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForAnswer( @@ -1869,6 +1872,7 @@ const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForAnswer( case RtpTransceiverDirection::kRecvOnly: return video_recv_codecs_; } + RTC_CHECK(false); } void MergeCodecsFromDescription( diff --git a/pc/rtc_stats_collector.cc b/pc/rtc_stats_collector.cc index 159ae7f1b9..6f14e1eb40 100644 --- a/pc/rtc_stats_collector.cc +++ b/pc/rtc_stats_collector.cc @@ -216,6 +216,7 @@ const char* QualityLimitationReasonToRTCQualityLimitationReason( case QualityLimitationReason::kOther: return RTCQualityLimitationReason::kOther; } + RTC_CHECK(false); } double DoubleAudioLevelFromIntAudioLevel(int audio_level) { diff --git a/rtc_base/network_monitor.cc b/rtc_base/network_monitor.cc index b22618a46e..ba6b1b495a 100644 --- a/rtc_base/network_monitor.cc +++ b/rtc_base/network_monitor.cc @@ -10,6 +10,8 @@ #include "rtc_base/network_monitor.h" +#include "rtc_base/checks.h" + namespace rtc { const char* NetworkPreferenceToString(NetworkPreference preference) { @@ -19,6 +21,7 @@ const char* NetworkPreferenceToString(NetworkPreference preference) { case NetworkPreference::NOT_PREFERRED: return "NOT_PREFERRED"; } + RTC_CHECK(false); } NetworkMonitorInterface::NetworkMonitorInterface() {} diff --git a/video/adaptation/video_stream_encoder_resource_manager.cc b/video/adaptation/video_stream_encoder_resource_manager.cc index b0b6488954..f7cf155cd8 100644 --- a/video/adaptation/video_stream_encoder_resource_manager.cc +++ b/video/adaptation/video_stream_encoder_resource_manager.cc @@ -55,6 +55,7 @@ std::string ToString(VideoAdaptationReason reason) { case VideoAdaptationReason::kCpu: return "cpu"; } + RTC_CHECK(false); } } // namespace