cfaba8fd2d
by storing [[LastCreatedOffer]] / [[LastCreatedAnswer]] which are similar to the W3C equivalent but as description objects instead of serialized SDP strings. While rejecting all SDP munging is not feasible, this lets us measure and reject certain modifications gradually. Chromium metrics CL: https://chromium-review.googlesource.com/c/chromium/src/+/6089633 This is measured at three points during the lifetime of a peerconnection: * for the first SLD call * when the connection is first established * when the connection was established and is being closed Note that the "first" SDP munging detected is returned which may hide that something uses more than one modification. BUG=chromium:40567530 Change-Id: I964e3ee6e75f73b777d90556fac8691a6f3dc27f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370680 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Johannes Kron <kron@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43741}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particular challenging as it is designed to be used in other code bases and thus needs to be updated independetly from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve existent struct in api, prefer first to convert it into a class.