admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make PC capability APIs pure virtual

Browse Source 
Bug: None
Change-Id: I22fdc44d5e164cab025c9d7884881eebd5160816
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370123
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43493}
This commit is contained in:
Harald Alvestrand 2024-12-03 13:30:46 +00:00 committed by WebRTC LUCI CQ
parent 6c7ac74e8b
commit fac1bafd44
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
api/peer_connection_interface.cc
View File

@ -114,14 +114,4 @@ PeerConnectionFactoryInterface::CreatePeerConnectionOrError(
return RTCError(RTCErrorType::INTERNAL_ERROR);
}
RtpCapabilities PeerConnectionFactoryInterface::GetRtpSenderCapabilities(
cricket::MediaType /* kind */) const {
return {};
}
RtpCapabilities PeerConnectionFactoryInterface::GetRtpReceiverCapabilities(
cricket::MediaType /* kind */) const {
return {};
}
} // namespace webrtc

6
api/peer_connection_interface.h
View File

@ -1570,15 +1570,13 @@ class RTC_EXPORT PeerConnectionFactoryInterface
// Returns the capabilities of an RTP sender of type `kind`.
// If for some reason you pass in MEDIA_TYPE_DATA, returns an empty structure.
// TODO(orphis): Make pure virtual when all subclasses implement it.
virtual RtpCapabilities GetRtpSenderCapabilities(
cricket::MediaType kind) const;
cricket::MediaType kind) const = 0;
// Returns the capabilities of an RTP receiver of type `kind`.
// If for some reason you pass in MEDIA_TYPE_DATA, returns an empty structure.
// TODO(orphis): Make pure virtual when all subclasses implement it.
virtual RtpCapabilities GetRtpReceiverCapabilities(
cricket::MediaType kind) const;
cricket::MediaType kind) const = 0;
virtual rtc::scoped_refptr<MediaStreamInterface> CreateLocalMediaStream(
const std::string& stream_id) = 0;