429b67db1f
This reverts commit efa72a1312e9871c9b33b7a1fec208b379608898. Reason for revert: It seems to break come chromium.webrtc.fyi bots: They are all release. https://ci.chromium.org/p/chromium/builders/luci.chromium.webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/2167 https://ci.chromium.org/p/chromium/builders/luci.chromium.webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Tester/1833 https://ci.chromium.org/p/chromium/builders/luci.chromium.webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/1835 Original change's description: > Propagate VideoFrame::UpdateRect to encoder > > Accumulate it in all places where frames can be dropped before they reach > the encoder. > > Reset UpdateRect in VideoBroadcaster if frame the previous frame is dropped. > No accumulation is done here since it's supposed to be a brief occusion then > configuration have changed. > > Bug: webrtc:10310 > Change-Id: I2813ecd009eb730bd99ffa0a02f979091b56bf80 > Reviewed-on: https://webrtc-review.googlesource.com/c/123102 > Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26711} TBR=ilnik@webrtc.org,nisse@webrtc.org,sprang@webrtc.org Change-Id: If34b5440393fffba6c37cd80c02e2b419b7ec601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10310 Reviewed-on: https://webrtc-review.googlesource.com/c/123224 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26719}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.