Jonas Oreland
61dbcd115a
Rewrite "Reset all maps in AndroidNetworkMonitor Start()/Stop()"
...
This reverts commit 8cd7b0a7babf3f58f6beab70fcabeb75e66c1bed.
The assumption in AndroidNetworkMonitor that an interface name
is unique has turned out to be incorrect :( for some (weird) devices,
i.e ccmni0.
It is unclear if it is a permanent setup or a transient state.
This cl/ changes the impl. to cope with that, the last
OnNetworkConnected_n "owns" the interface name, and when
OnNetworkDisconnected_n runs, we check if we're "owner"
and maybe set a new "owner" (if we're not "owner" we do nothing).
New testcases added.
I also
1) change NetworkMonitorInterface to return a struct
with all the information that is requested with interface name
as key.
2) Change Network.cc adding (debug) assertions that network
properties can't change inside a loop (in one thread).
Original change's description:
> Revert "Reset all maps in AndroidNetworkMonitor Start()/Stop()"
>
> This reverts commit 02293096f9689fee3d32defa77dca227cc1eee90.
>
> Reason for revert: mysterious crashes in android_network_monitor.cc
>
> Original change's description:
> > Reset all maps in AndroidNetworkMonitor Start()/Stop()
> >
> > This cl/ fixes another race condition with the recent additions
> > to NetworkMonitorAutoDetect (getAllNetworksFromCache).
> >
> > The getAllNetworksFromCache-feature uses the by the Android team
> > preferred way of enumerating networks, i.e to register network listeners.
> >
> > Th recent fix to add IsAdapterAvailable, https://webrtc-review.googlesource.com/c/src/+/257400
> > contained a bug in that the adapter_type_by_name_ map was not
> > reset either on disconnect or Start/Stop.
> >
> > This cl/ addresses that including unit test.
> > It also de-obfuscates NetworkMonitor so that it always
> > calls NotifyOfActiveNetworkList on startMonitoring even
> > if list.size() == 0. This should not matter but makes
> > code easier to understand.
> >
> > Bug: webrtc:13741
> > Change-Id: I438b877eebf769a8b2e7292b697ef1c0a349b24f
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258721
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#36530}
>
> Bug: webrtc:13741
> Change-Id: I36fbf63f658d3e8048e13959cbebfbd14df12b14
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264146
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37016}
Bug: webrtc:13741
Change-Id: Ib4eb072b775e493b564528f0be94c685b70ec20f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264421
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37056}
2022-05-31 10:49:55 +00:00
..
2021-08-10 10:40:03 +00:00
2022-01-13 20:42:15 +00:00
2022-05-05 09:43:31 +00:00
2021-01-15 17:00:05 +00:00
2021-08-24 16:02:17 +00:00
2022-05-31 09:22:24 +00:00
2020-06-08 12:59:40 +00:00
2022-01-13 20:42:15 +00:00
2022-05-08 09:13:53 +00:00
2022-04-19 21:57:48 +00:00
2022-05-05 17:15:58 +00:00
2022-05-05 17:15:58 +00:00
2022-04-20 16:13:13 +00:00
2022-03-29 12:46:51 +00:00
2022-05-10 07:41:30 +00:00
2022-05-05 06:47:49 +00:00
2021-11-17 13:37:06 +00:00
2021-11-18 09:08:55 +00:00
2022-01-13 20:42:15 +00:00
2022-04-13 14:56:58 +00:00
2022-04-13 14:56:58 +00:00
2019-02-20 16:02:59 +00:00
2021-07-28 13:51:47 +00:00
2022-04-17 12:11:56 +00:00
2021-04-22 06:30:11 +00:00
2021-08-17 15:39:25 +00:00
2021-08-17 15:39:25 +00:00
2021-08-17 15:39:25 +00:00
2022-04-13 14:56:58 +00:00
2022-01-13 20:42:15 +00:00
2021-08-17 15:39:25 +00:00
2021-08-17 15:39:25 +00:00
2021-08-17 15:39:25 +00:00
2019-07-08 13:45:15 +00:00
2021-09-21 16:28:38 +00:00
2021-09-21 16:28:38 +00:00
2022-01-13 20:42:15 +00:00
2021-09-20 19:37:49 +00:00
2021-09-20 19:37:49 +00:00
2021-09-15 17:20:50 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2020-03-02 20:55:28 +00:00
2020-03-02 20:55:28 +00:00
2020-03-02 20:55:28 +00:00
2020-09-29 12:57:20 +00:00
2022-01-13 20:42:15 +00:00
2022-04-04 12:30:56 +00:00
2022-04-04 12:30:56 +00:00
2022-05-10 10:32:41 +00:00
2019-11-15 11:48:42 +00:00
2019-11-15 11:48:42 +00:00
2022-03-17 15:39:26 +00:00
2019-07-08 13:45:15 +00:00
2019-03-31 11:55:09 +00:00
2022-04-11 08:42:46 +00:00
2022-04-11 08:42:46 +00:00
2022-04-11 08:56:51 +00:00
2020-11-18 20:49:08 +00:00
2022-03-17 15:39:26 +00:00
2022-04-28 12:58:56 +00:00
2021-09-20 14:02:05 +00:00
2022-05-10 10:32:41 +00:00
2022-05-10 10:32:41 +00:00
2021-05-07 14:14:43 +00:00
2021-08-20 16:19:19 +00:00
2019-05-15 23:54:07 +00:00
2022-03-17 15:39:26 +00:00
2019-05-10 07:07:19 +00:00
2019-05-10 07:07:19 +00:00
2019-10-15 09:07:44 +00:00
2021-07-25 11:46:59 +00:00
2020-07-08 20:38:54 +00:00
2022-05-23 09:10:36 +00:00
2022-05-23 09:10:36 +00:00
2021-05-07 14:14:43 +00:00
2019-04-11 16:35:18 +00:00
2019-04-11 16:35:18 +00:00
2020-02-10 12:21:17 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2022-04-29 15:33:12 +00:00
2022-04-29 15:33:12 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-04-17 12:11:56 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2021-08-17 15:39:25 +00:00
2021-08-17 15:39:25 +00:00
2022-03-17 15:39:26 +00:00
2022-04-28 12:58:56 +00:00
2019-07-08 13:45:15 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-04-17 12:11:56 +00:00
2022-04-17 12:11:56 +00:00
2022-02-16 12:37:35 +00:00
2019-07-08 13:45:15 +00:00
2022-03-17 15:39:26 +00:00
2022-04-17 12:11:56 +00:00
2022-03-17 15:39:26 +00:00
2019-12-03 19:43:12 +00:00
2021-07-28 13:51:47 +00:00
2022-05-02 08:15:05 +00:00
2022-05-02 08:15:05 +00:00
2022-04-25 16:01:40 +00:00
2022-04-17 12:11:56 +00:00
2022-04-25 16:01:40 +00:00
2019-07-08 13:45:15 +00:00
2022-03-17 15:39:26 +00:00
2019-10-25 12:07:32 +00:00
2019-10-25 12:07:32 +00:00
2019-07-08 13:45:15 +00:00
2022-04-04 12:30:56 +00:00
2022-04-04 12:30:56 +00:00
2022-03-17 15:39:26 +00:00
2020-09-25 11:44:02 +00:00
2022-01-13 20:42:15 +00:00
2021-08-17 15:39:25 +00:00
2022-01-13 20:42:15 +00:00
2021-08-17 15:39:25 +00:00
2022-01-13 20:42:15 +00:00
2021-11-15 21:44:59 +00:00
2022-05-20 15:21:21 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-04-17 12:11:56 +00:00
2022-04-17 12:11:56 +00:00
2021-11-15 21:44:59 +00:00
2022-01-28 15:13:45 +00:00
2020-08-13 20:50:23 +00:00
2022-03-29 10:14:00 +00:00
2020-11-09 10:47:55 +00:00
2022-05-31 10:49:55 +00:00
2020-03-24 11:48:42 +00:00
2020-03-24 11:48:42 +00:00
2020-03-30 13:02:46 +00:00
2022-05-31 10:49:55 +00:00
2022-05-31 10:49:55 +00:00
2022-05-31 10:49:55 +00:00
2020-09-07 12:57:15 +00:00
2021-11-15 21:44:59 +00:00
2021-08-17 15:39:25 +00:00
2020-07-08 20:38:54 +00:00
2022-05-20 15:21:21 +00:00
2022-05-11 14:37:04 +00:00
2022-05-11 14:37:04 +00:00
2022-03-25 08:11:17 +00:00
2022-03-25 08:11:17 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-03-25 08:11:17 +00:00
2022-03-25 08:11:17 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2020-12-11 09:58:40 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-04-29 05:44:42 +00:00
2022-04-17 12:11:56 +00:00
2020-12-11 09:58:40 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-05-20 15:21:21 +00:00
2022-01-13 12:01:30 +00:00
2022-01-13 20:42:15 +00:00
2021-08-31 14:27:49 +00:00
2021-09-08 12:41:39 +00:00
2021-11-27 22:21:54 +00:00
2021-08-17 15:39:25 +00:00
2020-05-17 17:22:01 +00:00
2019-03-04 12:42:10 +00:00
2021-06-28 09:09:47 +00:00
2021-05-07 14:14:43 +00:00
2022-04-08 12:03:04 +00:00
2019-02-16 11:11:45 +00:00
2019-07-08 13:45:15 +00:00
2021-08-17 15:39:25 +00:00
2022-01-13 20:42:15 +00:00
2021-08-17 15:39:25 +00:00
2022-05-05 17:15:58 +00:00
2020-09-18 17:42:53 +00:00
2021-06-25 22:25:22 +00:00
2021-01-07 16:40:50 +00:00
2021-05-07 14:14:43 +00:00
2020-07-08 20:38:54 +00:00
2020-09-29 10:19:20 +00:00
2021-11-30 23:57:40 +00:00
2021-11-30 23:57:40 +00:00
2020-05-25 12:14:44 +00:00
2020-01-15 13:46:38 +00:00
2020-12-15 12:17:12 +00:00
2021-07-28 13:51:47 +00:00
2022-03-17 15:39:26 +00:00
2022-03-21 16:31:21 +00:00
2019-11-26 14:05:20 +00:00
2021-07-28 13:51:47 +00:00
2022-01-13 20:42:15 +00:00
2022-05-20 15:21:21 +00:00
2022-01-20 12:59:27 +00:00
2021-08-10 10:40:03 +00:00
2021-07-28 13:51:47 +00:00
2022-01-13 12:01:30 +00:00
2022-03-17 15:39:26 +00:00
2021-08-17 15:39:25 +00:00
2022-01-13 20:42:15 +00:00
2022-01-13 20:42:15 +00:00
2019-04-09 17:18:20 +00:00
2022-01-27 12:55:44 +00:00
2022-04-17 12:11:56 +00:00
2022-03-17 15:39:26 +00:00
2021-04-21 12:31:14 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2021-09-07 10:52:57 +00:00
2021-04-22 13:04:53 +00:00
2021-08-17 15:39:25 +00:00
2022-01-13 20:42:15 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2019-07-08 13:45:15 +00:00
2022-01-13 20:42:15 +00:00
2022-04-17 12:11:56 +00:00
2021-10-21 12:08:30 +00:00
2022-04-17 12:11:56 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-04-04 12:30:56 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2020-10-29 21:08:10 +00:00
2022-05-20 15:21:21 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2021-04-16 08:47:17 +00:00
2022-01-13 20:42:15 +00:00
2022-04-04 12:30:56 +00:00
2022-05-11 14:37:04 +00:00
2022-05-11 14:37:04 +00:00
2022-04-08 11:04:34 +00:00
2022-05-30 13:05:03 +00:00
2022-03-25 14:32:05 +00:00
2022-03-17 12:53:14 +00:00
2022-03-25 08:12:36 +00:00
2022-05-30 13:05:03 +00:00
2021-09-21 15:17:26 +00:00
2021-09-21 15:17:26 +00:00
2021-10-28 12:53:49 +00:00
2021-01-15 17:59:05 +00:00
2021-11-15 21:44:59 +00:00
2021-02-15 22:38:46 +00:00
2019-03-19 18:11:52 +00:00
2021-07-28 13:51:47 +00:00
2021-10-19 11:45:12 +00:00
2021-10-19 11:45:12 +00:00
2021-11-15 21:44:59 +00:00
2019-02-12 10:58:36 +00:00
2022-04-27 22:42:16 +00:00
2019-02-21 14:36:07 +00:00
2021-01-29 08:24:43 +00:00
2022-01-27 12:55:44 +00:00
2019-02-21 09:33:42 +00:00
2022-03-14 15:24:17 +00:00
2022-03-14 15:24:17 +00:00
2022-05-20 15:21:21 +00:00
2020-07-08 20:38:54 +00:00
2022-01-13 20:42:15 +00:00
2021-08-17 15:39:25 +00:00
2022-04-13 14:56:58 +00:00
2021-08-17 15:39:25 +00:00
2019-07-08 13:45:15 +00:00
2021-07-27 07:46:32 +00:00
2021-07-29 06:58:05 +00:00
2022-05-20 15:21:21 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2020-02-10 12:21:17 +00:00
2021-07-28 13:51:47 +00:00
2022-01-25 15:39:53 +00:00
2021-08-10 10:40:03 +00:00
2021-07-28 13:51:47 +00:00
2022-01-13 20:42:15 +00:00
2021-07-28 13:51:47 +00:00
2021-11-15 09:39:10 +00:00
2022-03-17 15:39:26 +00:00
2022-03-17 15:39:26 +00:00
2020-10-07 01:26:06 +00:00
2020-10-07 01:26:06 +00:00
2022-03-24 08:18:43 +00:00
2022-01-13 20:42:15 +00:00
2021-09-01 14:27:29 +00:00
2019-10-15 09:17:36 +00:00
2019-04-09 12:28:04 +00:00
2021-02-10 15:04:55 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-10-22 16:15:56 +00:00
2021-10-13 19:26:10 +00:00
2021-10-05 22:13:37 +00:00
2019-07-08 13:45:15 +00:00