5f96daa8a5
It seems like this got confused when initially added [1,2]. The confusion affects the lag check [3], which only send an email in the past, but will raise a builder failure after [4] landed if there is a gap for more than 4 commits. [1] https://crsrc.org/i/infra/services/lkgr_finder/config/default_cfg.pyl?q=allowed_gap [2] https://crsrc.org/i/infra/services/lkgr_finder/test/lkgr_lib_test.py?q=allowed_gap [3] https://crsrc.org/i/infra/services/lkgr_finder/lkgr_lib.py;l=500?q=allowed_lag [4] https://crrev.com/c/3599253 Bug: chromium:1317669 Change-Id: I23726957439b03dced0fc0038ee65a3108f88fea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259874 Auto-Submit: Alex Schulze <alexschulze@google.com> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36642}
infra/config folder
This folder contains WebRTC project-wide configurations for Chrome infra services, mainly the CI system (console).
*.cfg files are the actual configuration that LUCI looks at.
They are in protocol buffer text format. For example,
cr-buildbucket.cfg defines builders.
However, they are all automatically generated from the Starlark script config.star that defines a unified config using lucicfg. The main body of the config is at the bottom of the file, following all the helper definitions.
lucicfg should be available as part of depot_tools. After editing
config.star you should run lucicfg generate config.star to
re-generate *.cfg files. Check the diffs in generated files to confirm that
your change worked as expected. Both the code change and the generated changes
need to be committed together.
Uploading changes
It is recommended to have a separate checkout for this branch, so switching to/from it does not populate/delete all files in the master branch.
Initial setup:
git clone https://webrtc.googlesource.com/src/
Now you can create a new branch to make changes:
git new-branch add-new-builder
# edit/generate files
git commit -a
git cl upload
Changes can be reviewed on Gerrit and submitted with commit queue as usual.
Activating the changes
Any changes to this directory go live soon after landing, without any additional steps. You can see the status or force a refresh of the config at luci-config.