admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lkgr_finder] Toggle allowed_lag and allowed_gap

Browse Source 
It seems like this got confused when initially added [1,2]. The confusion affects the lag check [3], which only send an email in the past, but will raise a builder failure after [4] landed if there is a gap for more than 4 commits.

[1] https://crsrc.org/i/infra/services/lkgr_finder/config/default_cfg.pyl?q=allowed_gap
[2] https://crsrc.org/i/infra/services/lkgr_finder/test/lkgr_lib_test.py?q=allowed_gap
[3] https://crsrc.org/i/infra/services/lkgr_finder/lkgr_lib.py;l=500?q=allowed_lag
[4] https://crrev.com/c/3599253

Bug: chromium:1317669
Change-Id: I23726957439b03dced0fc0038ee65a3108f88fea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259874
Auto-Submit: Alex Schulze <alexschulze@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36642}
This commit is contained in:
Alexander Schulze 2022-04-25 13:17:10 +02:00 committed by WebRTC LUCI CQ
parent e65d05da25
commit 5f96daa8a5
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
infra/config/config.star
View File

@ -821,8 +821,8 @@ lkgr_config = {
"project": "webrtc",
"source_url": WEBRTC_GIT,
"status_url": "https://webrtc-status.appspot.com",
"allowed_lag": 150, # hours
"allowed_gap": 4, # commits behind
"allowed_lag": 4, # hours (up to 10x during low commit volume periods)
"allowed_gap": 150, # commits behind
"error_recipients": WEBRTC_TROOPER_EMAIL,
"buckets": {
"webrtc/ci": {

4
infra/config/cr-buildbucket.cfg
View File

@ -2002,8 +2002,8 @@ buckets {
' ]'
' },'
' "config": {'
' "allowed_gap": 4,'
' "allowed_lag": 150,'
' "allowed_gap": 150,'
' "allowed_lag": 4,'
' "buckets": {'
' "chromium/webrtc.fyi": {'
' "builders": ['