b206ab1f81
Before this change, the heartbeat timer was restarted every time a packet was sent on the socket. On an idle connection, if the peer is sending heartbeats, just responding to those heartbeats (with a HEARTBEAT-ACK) would restart the timer, and then this socket wouldn't do any heartbeating itself because the next hearbeat by the peer would be received before the timer expires. This is not according to the specification, where https://datatracker.ietf.org/doc/html/rfc9260#section-8.3 states that "A destination transport address is considered "idle" if no new chunk that can be used for updating path RTT (usually including first transmission DATA, INIT, COOKIE ECHO, or HEARTBEAT chunks, etc.)" There are already timers running when INIT, and COOKIE-ECHO are sent and not acked, so the heartbeat shouldn't be sent then. This is further confirmed in the same section in the RFC which says that "The sending of HEARTBEAT chunks MAY begin upon reaching the ESTABLISHED state". And when INIT and COOKIE-ECHO are sent, the connection is not yet established. This CL changes so that the heartbeat timer is only restarted when any DATA or I-DATA chunk is sent. This will make both sides send heartbeats on an idle connection. Bug: webrtc:343600379 Change-Id: I5ab159b7901e2ec9d37b24aaf845891b60a53c13 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352841 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42409}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation