admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated Port constructor

Browse Source 
BUG=webrtc:42224914

Change-Id: Idc1a86d109c0a8d0d2a295d00b0963f226e9374e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352542
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42407}
This commit is contained in:
Philipp Hancke 2024-05-28 14:58:43 -07:00 committed by WebRTC LUCI CQ
parent 6ba729cd34
commit 9e78e26535
2 changed files with 0 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
p2p/base/port.cc
View File

@ -139,42 +139,6 @@ Port::Port(const PortParametersRef& args,
<< network_cost_;
}
Port::Port(TaskQueueBase* thread,
webrtc::IceCandidateType type,
rtc::PacketSocketFactory* factory,
const rtc::Network* network,
absl::string_view username_fragment,
absl::string_view password,
const webrtc::FieldTrialsView* field_trials)
: Port({.network_thread = thread,
.socket_factory = factory,
.network = network,
.ice_username_fragment = username_fragment,
.ice_password = password,
.field_trials = field_trials},
type) {}
Port::Port(TaskQueueBase* thread,
webrtc::IceCandidateType type,
rtc::PacketSocketFactory* factory,
const rtc::Network* network,
uint16_t min_port,
uint16_t max_port,
absl::string_view username_fragment,
absl::string_view password,
const webrtc::FieldTrialsView* field_trials,
bool shared_socket /*= false*/)
: Port({.network_thread = thread,
.socket_factory = factory,
.network = network,
.ice_username_fragment = username_fragment,
.ice_password = password,
.field_trials = field_trials},
type,
min_port,
max_port,
shared_socket) {}
Port::~Port() {
RTC_DCHECK_RUN_ON(thread_);
DestroyAllConnections();

19
p2p/base/port.h
View File

@ -190,25 +190,6 @@ class RTC_EXPORT Port : public PortInterface, public sigslot::has_slots<> {
uint16_t min_port,
uint16_t max_port,
bool shared_socket = false);
[[deprecated("Pass arguments using PortParametersRef")]] Port(
webrtc::TaskQueueBase* thread,
webrtc::IceCandidateType type,
rtc::PacketSocketFactory* factory,
const rtc::Network* network,
absl::string_view username_fragment,
absl::string_view password,
const webrtc::FieldTrialsView* field_trials = nullptr);
[[deprecated("Pass arguments using PortParametersRef")]] Port(
webrtc::TaskQueueBase* thread,
webrtc::IceCandidateType type,
rtc::PacketSocketFactory* factory,
const rtc::Network* network,
uint16_t min_port,
uint16_t max_port,
absl::string_view username_fragment,
absl::string_view password,
const webrtc::FieldTrialsView* field_trials = nullptr,
bool shared_socket = false);
public:
~Port() override;