From 9e78e2653522411af73affe7e4cd884766c3e9f9 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Tue, 28 May 2024 14:58:43 -0700 Subject: [PATCH] Remove deprecated Port constructor BUG=webrtc:42224914 Change-Id: Idc1a86d109c0a8d0d2a295d00b0963f226e9374e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352542 Reviewed-by: Tomas Gunnarsson Reviewed-by: Harald Alvestrand Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/main@{#42407} --- p2p/base/port.cc | 36 ------------------------------------ p2p/base/port.h | 19 ------------------- 2 files changed, 55 deletions(-) diff --git a/p2p/base/port.cc b/p2p/base/port.cc index 272214c458..d9bacf3a5a 100644 --- a/p2p/base/port.cc +++ b/p2p/base/port.cc @@ -139,42 +139,6 @@ Port::Port(const PortParametersRef& args, << network_cost_; } -Port::Port(TaskQueueBase* thread, - webrtc::IceCandidateType type, - rtc::PacketSocketFactory* factory, - const rtc::Network* network, - absl::string_view username_fragment, - absl::string_view password, - const webrtc::FieldTrialsView* field_trials) - : Port({.network_thread = thread, - .socket_factory = factory, - .network = network, - .ice_username_fragment = username_fragment, - .ice_password = password, - .field_trials = field_trials}, - type) {} - -Port::Port(TaskQueueBase* thread, - webrtc::IceCandidateType type, - rtc::PacketSocketFactory* factory, - const rtc::Network* network, - uint16_t min_port, - uint16_t max_port, - absl::string_view username_fragment, - absl::string_view password, - const webrtc::FieldTrialsView* field_trials, - bool shared_socket /*= false*/) - : Port({.network_thread = thread, - .socket_factory = factory, - .network = network, - .ice_username_fragment = username_fragment, - .ice_password = password, - .field_trials = field_trials}, - type, - min_port, - max_port, - shared_socket) {} - Port::~Port() { RTC_DCHECK_RUN_ON(thread_); DestroyAllConnections(); diff --git a/p2p/base/port.h b/p2p/base/port.h index ff55035a6e..2df1d35b8e 100644 --- a/p2p/base/port.h +++ b/p2p/base/port.h @@ -190,25 +190,6 @@ class RTC_EXPORT Port : public PortInterface, public sigslot::has_slots<> { uint16_t min_port, uint16_t max_port, bool shared_socket = false); - [[deprecated("Pass arguments using PortParametersRef")]] Port( - webrtc::TaskQueueBase* thread, - webrtc::IceCandidateType type, - rtc::PacketSocketFactory* factory, - const rtc::Network* network, - absl::string_view username_fragment, - absl::string_view password, - const webrtc::FieldTrialsView* field_trials = nullptr); - [[deprecated("Pass arguments using PortParametersRef")]] Port( - webrtc::TaskQueueBase* thread, - webrtc::IceCandidateType type, - rtc::PacketSocketFactory* factory, - const rtc::Network* network, - uint16_t min_port, - uint16_t max_port, - absl::string_view username_fragment, - absl::string_view password, - const webrtc::FieldTrialsView* field_trials = nullptr, - bool shared_socket = false); public: ~Port() override;