ac7577854f
This reverts commit 3d992bf47f8253788c76f76b4e5087d7e9b66783. Reason for revert: Added counter reset at the right place. Original change's description: > Revert "Add test for StunMessage::ValidateMessageIntegrity" > > This reverts commit 1f4f672687861cae29259dd0c652d58de373dcac. > > Reason for revert: Breaks downstream test. > > Original change's description: > > Add test for StunMessage::ValidateMessageIntegrity > > > > This also tests the UMA stats newly added to it. > > > > Bug: chromium:1177125 > > Change-Id: I89bb17c1897565cd91ea5bbd92062018317738ca > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278600 > > Reviewed-by: Johannes Kron <kron@webrtc.org> > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#38345} > > Bug: chromium:1177125 > Change-Id: I2490f2f740db8282ab293583013a50d03ead9141 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278801 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38349} Bug: chromium:1177125 Change-Id: I38212aeff3a366d4b8beb9c822f709b9fcbb7146 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278802 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38353}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.