admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/audio_processing/aec3
History
Mirko Bonadei b2b627701c Revert "AEC3: clarify render delay controller metrics" 
This reverts commit fd745d3e3c7083cfa52307b9e4fc908930ddf2d2.

Reason for revert: Breaks downstream projects.

Original change's description:
> AEC3: clarify render delay controller metrics
>
> This CL:
> - makes it easier to understand the (nontrivial) metric interpretation
> - corrects the computation of BufferDelay to use 0 for absent delay
> - deletes metric MaxSkewShiftCount, unused since https://webrtc-review.googlesource.com/c/src/+/119701
> - updates the unit test to directly test metric reporting
>
> Corresponding update to histograms.xml:
> https://crrev.com/c/3944909
>
> Bug: webrtc:8671, chromium:1349051
> Change-Id: If73b6fca4de7343bff2c53f72cedda458d36c599
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278782
> Commit-Queue: Sam Zackrisson <saza@webrtc.org>
> Reviewed-by: Per Åhgren <peah@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38362}

Bug: webrtc:8671, chromium:1349051
Change-Id: I1e2bd0f91acb67532e21f5d2f8526a398711a413
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279040
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38367}
2022-10-12 13:42:31 +00:00
..
mock
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
adaptive_fir_filter_avx2.cc
Optimize ComputeFrequencyResponse().
2021-11-18 08:49:25 +00:00
adaptive_fir_filter_erl_avx2.cc
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00
adaptive_fir_filter_erl_unittest.cc
Refactor cpu_features_wrapper.h functions from C to C++.
2020-09-07 08:44:24 +00:00
adaptive_fir_filter_erl.cc
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00
adaptive_fir_filter_erl.h
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00
adaptive_fir_filter_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
adaptive_fir_filter.cc
Optimize ComputeFrequencyResponse().
2021-11-18 08:49:25 +00:00
adaptive_fir_filter.h
Adopt absl::string_view in modules/audio_processing/
2022-08-16 13:49:14 +00:00
aec3_common.cc
Fix some -Wunreachable-code-aggressive warnings
2021-08-16 11:09:16 +00:00
aec3_common.h
Remove top-level const from parameters in function declarations.
2022-01-26 11:05:25 +00:00
aec3_fft_unittest.cc
Rename several more tests that use EXPECT_DEATH to *DeathTest.
2020-05-18 16:10:04 +00:00
aec3_fft.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
aec3_fft.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
aec_state_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
aec_state.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
aec_state.h
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
alignment_mixer_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
alignment_mixer.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
alignment_mixer.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
api_call_jitter_metrics_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
api_call_jitter_metrics.cc
…
api_call_jitter_metrics.h
…
block_buffer.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
block_buffer.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
block_delay_buffer_unittest.cc
AEC3: Added multi-channel support for the capture delay functionality
2020-01-28 15:39:26 +00:00
block_delay_buffer.cc
Optimize block_delay_buffer.
2021-11-24 12:20:28 +00:00
block_delay_buffer.h
AEC3: Added multi-channel support for the capture delay functionality
2020-01-28 15:39:26 +00:00
block_framer_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
block_framer.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
block_framer.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
block_processor_metrics_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
block_processor_metrics.cc
…
block_processor_metrics.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
block_processor_unittest.cc
GCC: Avoid symbol clash in RenderBuffer
2022-05-24 10:47:56 +00:00
block_processor.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
block_processor.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
block.h
Use a one-dimensional vector for Block data
2022-05-24 11:12:46 +00:00
BUILD.gn
Adopt absl::string_view in modules/audio_processing/
2022-08-16 13:49:14 +00:00
clockdrift_detector_unittest.cc
…
clockdrift_detector.cc
…
clockdrift_detector.h
IWYU: size_t is defined in stddef.h
2020-06-03 08:43:50 +00:00
coarse_filter_update_gain_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
coarse_filter_update_gain.cc
AEC3: Rename shadow filter
2020-03-20 15:26:14 +00:00
coarse_filter_update_gain.h
AEC3: Rename shadow filter
2020-03-20 15:26:14 +00:00
comfort_noise_generator_unittest.cc
AEC3: Added parametrization of the comfort noise floor
2020-03-25 08:56:17 +00:00
comfort_noise_generator.cc
AEC3: Added parametrization of the comfort noise floor
2020-03-25 08:56:17 +00:00
comfort_noise_generator.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
config_selector_unittest.cc
AEC3: Add multichannel configuration and multichannel detection
2022-04-07 14:58:02 +00:00
config_selector.cc
AEC3: Add fallback to mono processing if no stereo is detected for some time
2022-04-08 16:43:14 +00:00
config_selector.h
AEC3: Add multichannel configuration and multichannel detection
2022-04-07 14:58:02 +00:00
decimator_unittest.cc
Rename more death test to *DeathTest
2020-05-26 20:27:34 +00:00
decimator.cc
AEC3: Add signal dependent mixing before alignment
2019-12-03 11:30:48 +00:00
decimator.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
delay_estimate.h
Make header files self contained.
2022-10-08 08:38:36 +00:00
dominant_nearend_detector.cc
AEC3: Sub-band nearend detector
2019-11-25 16:26:49 +00:00
dominant_nearend_detector.h
AEC3: Sub-band nearend detector
2019-11-25 16:26:49 +00:00
downsampled_render_buffer.cc
…
downsampled_render_buffer.h
Format almost everything.
2019-07-08 13:45:15 +00:00
echo_audibility.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
echo_audibility.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
echo_canceller3_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
echo_canceller3.cc
Adopt absl::string_view in modules/audio_processing/
2022-08-16 13:49:14 +00:00
echo_canceller3.h
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
echo_path_delay_estimator_unittest.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
echo_path_delay_estimator.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
echo_path_delay_estimator.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
echo_path_variability_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
echo_path_variability.cc
…
echo_path_variability.h
Remove unused enums and members
2020-09-30 14:34:44 +00:00
echo_remover_metrics_unittest.cc
Rename more death test to *DeathTest
2020-05-26 20:27:34 +00:00
echo_remover_metrics.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
echo_remover_metrics.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
echo_remover_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
echo_remover.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
echo_remover.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
erl_estimator_unittest.cc
Add parameterization for three multi channel AEC3 unit tests
2020-01-24 12:26:46 +00:00
erl_estimator.cc
AEC3: Multi channel ERL estimator
2019-10-18 16:03:46 +00:00
erl_estimator.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
erle_estimator_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
erle_estimator.cc
AEC3: Avoid overcompensating for render onsets during dominant nearend
2021-04-20 12:33:02 +00:00
erle_estimator.h
AEC3: Unbounded echo spectrum for dominant nearend detection.
2021-06-11 13:30:00 +00:00
fft_buffer.cc
Add multi-channel to FftBuffer
2019-09-05 14:10:04 +00:00
fft_buffer.h
Add multi-channel to FftBuffer
2019-09-05 14:10:04 +00:00
fft_data_avx2.cc
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00
fft_data_unittest.cc
Refactor cpu_features_wrapper.h functions from C to C++.
2020-09-07 08:44:24 +00:00
fft_data.h
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00
filter_analyzer_unittest.cc
AEC3: General cleanup after multichannel changes
2019-10-18 07:43:49 +00:00
filter_analyzer.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
filter_analyzer.h
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
frame_blocker_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
frame_blocker.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
frame_blocker.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
fullband_erle_estimator.cc
Fixing the bounds for the max and min erle in the erle instantaneous estimation.
2020-12-15 14:29:52 +00:00
fullband_erle_estimator.h
Remove top-level const from parameters in function declarations.
2022-01-26 11:05:25 +00:00
matched_filter_avx2.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
matched_filter_lag_aggregator_unittest.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
matched_filter_lag_aggregator.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
matched_filter_lag_aggregator.h
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
matched_filter_unittest.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
matched_filter.cc
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
matched_filter.h
delay estimator: Look for early reverberation
2022-06-28 15:16:03 +00:00
moving_average_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
moving_average.cc
…
moving_average.h
Format almost everything.
2019-07-08 13:45:15 +00:00
multi_channel_content_detector_unittest.cc
AEC3: Add metrics for stereo detection code
2022-04-13 10:16:48 +00:00
multi_channel_content_detector.cc
AEC3: Add metrics for stereo detection code
2022-04-13 10:16:48 +00:00
multi_channel_content_detector.h
Add missing header to fix build error when using linux system libraries
2022-07-19 12:25:42 +00:00
nearend_detector.h
AEC3: Sub-band nearend detector
2019-11-25 16:26:49 +00:00
refined_filter_update_gain_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
refined_filter_update_gain.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
refined_filter_update_gain.h
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
render_buffer_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
render_buffer.cc
Optimize RenderBuffer.
2021-12-01 14:52:21 +00:00
render_buffer.h
GCC: Avoid symbol clash in RenderBuffer
2022-05-24 10:47:56 +00:00
render_delay_buffer_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
render_delay_buffer.cc
libstdc++: add missing atomic include for std::atomic
2022-07-12 09:23:26 +00:00
render_delay_buffer.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
render_delay_controller_metrics_unittest.cc
Revert "AEC3: clarify render delay controller metrics"
2022-10-12 13:42:31 +00:00
render_delay_controller_metrics.cc
Revert "AEC3: clarify render delay controller metrics"
2022-10-12 13:42:31 +00:00
render_delay_controller_metrics.h
Revert "AEC3: clarify render delay controller metrics"
2022-10-12 13:42:31 +00:00
render_delay_controller_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
render_delay_controller.cc
Revert "AEC3: clarify render delay controller metrics"
2022-10-12 13:42:31 +00:00
render_delay_controller.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
render_signal_analyzer_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
render_signal_analyzer.cc
GCC: Avoid symbol clash in RenderBuffer
2022-05-24 10:47:56 +00:00
render_signal_analyzer.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
residual_echo_estimator_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
residual_echo_estimator.cc
AEC3: adding a milder exponential decay parameter that is used for dominant nearend regions when enabled.
2021-09-08 11:36:50 +00:00
residual_echo_estimator.h
AEC3: adding a milder exponential decay parameter that is used for dominant nearend regions when enabled.
2021-09-08 11:36:50 +00:00
reverb_decay_estimator.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
reverb_decay_estimator.h
AEC3: adding a milder exponential decay parameter that is used for dominant nearend regions when enabled.
2021-09-08 11:36:50 +00:00
reverb_frequency_response.cc
AEC3: Using a more conservative frequency response representation of the tails.
2021-09-10 13:20:35 +00:00
reverb_frequency_response.h
AEC3: Using a more conservative frequency response representation of the tails.
2021-09-10 13:20:35 +00:00
reverb_model_estimator_unittest.cc
AEC3: adding a milder exponential decay parameter that is used for dominant nearend regions when enabled.
2021-09-08 11:36:50 +00:00
reverb_model_estimator.cc
AEC3: Using a more conservative frequency response representation of the tails.
2021-09-10 13:20:35 +00:00
reverb_model_estimator.h
AEC3: adding a milder exponential decay parameter that is used for dominant nearend regions when enabled.
2021-09-08 11:36:50 +00:00
reverb_model.cc
AEC3: Add multichannel support to the residual echo estimator
2019-10-08 11:18:35 +00:00
reverb_model.h
AEC3: Add multichannel support to the residual echo estimator
2019-10-08 11:18:35 +00:00
signal_dependent_erle_estimator_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
signal_dependent_erle_estimator.cc
AEC3: Avoid overcompensating for render onsets during dominant nearend
2021-04-20 12:33:02 +00:00
signal_dependent_erle_estimator.h
AEC3: Avoid overcompensating for render onsets during dominant nearend
2021-04-20 12:33:02 +00:00
spectrum_buffer.cc
AEC3: Update SpectrumBuffer API
2019-10-18 07:01:42 +00:00
spectrum_buffer.h
AEC3: Update SpectrumBuffer API
2019-10-18 07:01:42 +00:00
stationarity_estimator.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
stationarity_estimator.h
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
subband_erle_estimator.cc
AEC3: Unbounded echo spectrum for dominant nearend detection.
2021-06-11 13:30:00 +00:00
subband_erle_estimator.h
AEC3: Unbounded echo spectrum for dominant nearend detection.
2021-06-11 13:30:00 +00:00
subband_nearend_detector.cc
AEC3: Sub-band nearend detector
2019-11-25 16:26:49 +00:00
subband_nearend_detector.h
AEC3: Sub-band nearend detector
2019-11-25 16:26:49 +00:00
subtractor_output_analyzer.cc
AEC3: Prevent transparent mode from leaking low volume echo
2020-10-21 11:19:55 +00:00
subtractor_output_analyzer.h
AEC3: Prevent transparent mode from leaking low volume echo
2020-10-21 11:19:55 +00:00
subtractor_output.cc
AEC3: Rename shadow filter
2020-03-20 15:26:14 +00:00
subtractor_output.h
AEC3: Rename shadow filter
2020-03-20 15:26:14 +00:00
subtractor_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
subtractor.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
subtractor.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
suppression_filter_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
suppression_filter.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
suppression_filter.h
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
suppression_gain_unittest.cc
AEC3: 'Block' class
2022-05-23 09:53:46 +00:00
suppression_gain.cc
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
suppression_gain.h
Delete rtc_base/atomic_ops.h
2022-06-28 08:32:13 +00:00
transparent_mode.cc
Improvements to AEC3 logging to simplify debugging
2021-05-19 14:28:44 +00:00
transparent_mode.h
AEC3: Prevent transparent mode from leaking low volume echo
2020-10-21 11:19:55 +00:00
vector_math_avx2.cc
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00
vector_math_unittest.cc
Refactor cpu_features_wrapper.h functions from C to C++.
2020-09-07 08:44:24 +00:00
vector_math.h
aec3: Support AVX2/FMA intrinsics in AEC3
2020-09-01 11:58:16 +00:00