47faf32287
When built for chromium, some webrtc implementations are overridden and are implemented by chrome's "//base". For instance webrtc::Location is implemented by base::Location. So far so good, the affected targets are correctly defined in GN to depend on base. The problem: Most targets in webrtc do not declare correctly their public_deps. When a public header of a target includes one from its dependency, the dependency must be a public_deps. The public_deps instruct GN to forward the capability to use code from the dependency toward the dependent. Unfortunately, it is not possible to fix the `public_deps` in webrtc, because its is disallowed via a presubmit. See: https://webrtc-review.googlesource.com/c/src/+/30262 WebRTC developers decided not to use `public_deps`, because GN config are "translated" toward different kind of downstream build system who do not really support the `public` dependencies concept. Instead WebRTC is using some "common" configuration applied to all of its targets. This patch add `rtc_common_public_deps` argument, to let embedders add the dependencies WebRTC depends on. Bug: chromium:1467773 Change-Id: I7de43372414a09886fcb07905451e6339c8ecc64 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316660 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40595}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.