88290ae358
This is a reland of fa79081dca9faa8322943641352d9d2fd1b1b445 It crashed due to inability to handle small timestamps in probe estimator. This was fixed by moving history window check to avoid subtracting from the timestamp. Original change's description: > Cleanup of RTP references in GoogCC implementation. > > As the send time congestion controller now has been removed, > we don't need the RTP related constructs anymore. > > Bug: webrtc:9510 > Change-Id: I02c059ed8ae907ab4672d183c5639ad459b581aa > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142221 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28330} Bug: webrtc:9510 Change-Id: I3bf91222068e4fbb6aa159bfeb7a73e00bb6a0d7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143165 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28347}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.