admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase TaskQueueTest.PostALot timeouts

Browse Source 
recent changed decreased timeout from forever to 1s which is not enough on some platforms
Increase timeout to forever for posting 65k tasks.
Also increase timeout for eventual destruction of the tasks to reduce change it would flake.

Bug: chromium:972917
Change-Id: I4948d49c1514833ab190856fdd25a47a5bad91eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141410
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28235}
This commit is contained in:
Danil Chapovalov 2019-06-11 13:49:20 +02:00 committed by Commit Bot
parent 5b2eda4895
commit 95e0a607f6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/task_queue/task_queue_test.cc
View File

@ -225,14 +225,14 @@ TEST_P(TaskQueueTest, PostALot) {
}));
// Before destroying the task queue wait until all child tasks are posted.
EXPECT_TRUE(posting_done.Wait(1000));
posting_done.Wait(rtc::Event::kForever);
// Destroy the task queue.
task_queue = nullptr;
// Expect all tasks are destroyed eventually. In some task queue
// implementations that might happen on a different thread after task queue is
// destroyed.
EXPECT_TRUE(all_destroyed.Wait(1000));
EXPECT_TRUE(all_destroyed.Wait(60000));
EXPECT_LE(tasks_executed, kTaskCount);
}