eladalon d6e9466e7e No compliation-flag-dependent members in CriticalSection
Having members in a class which only exist when certain compliation flags are turned on (unless relating to the target platform) means that those flags must be the same when compiling the module as when including its headers from other modules. This means that code outside of WebRTC runs the risk of misjudging the size of an rtc::CriticalSection, or any class which has an rtc::CriticalSection as a member. (This rule is applied recursively.) If a mismatch occurs, memory corruption is likely.

Having discussed this a bit, we have decided that the simplest solution is probably the best - always define those members, even when compilation flags (namely, CS_DEBUG_CHECKS) render it unused.

BUG=webrtc:7867

Review-Url: https://codereview.webrtc.org/2957753002
Cr-Commit-Position: refs/heads/master@{#18811}
2017-06-28 14:31:30 +00:00
..
2017-06-28 13:59:40 +00:00
2017-06-16 07:57:21 +00:00
2016-12-14 23:03:11 +00:00
2016-12-14 23:03:11 +00:00
2015-12-28 22:07:05 +00:00
2015-12-28 22:07:05 +00:00
2016-08-16 13:38:23 +00:00
2017-03-27 11:37:14 +00:00
2016-07-01 10:45:29 +00:00
2016-02-02 16:34:16 +00:00
2017-05-13 05:52:51 +00:00
2017-03-15 11:36:29 +00:00
2017-03-15 11:36:29 +00:00
2017-04-10 13:56:58 +00:00
2016-10-03 07:30:08 +00:00