705ecc5dda
During GN vs GYP auditing it was discovered that some GN targets that had public_configs were not exposing them to dependents where the dependent depended on a group, which in turn included that target as a dependency. Instead of changing those public_configs to all_dependent_configs (which would be a change from GYP), it's better to just change those group targets to use public_deps instead. BUG=webrtc:6323 NOTRY=True TESTED=Generated GYP and GN project files on Mac and ran the tools/gyp_flag_compare.py script before and after this patch was applied. The file in question used for inspection was the webrtc/api/webrtcsessiondescriptionfactory.cc which is a part of the libjingle_peerconnection target. Review-Url: https://codereview.webrtc.org/2344623002 Cr-Commit-Position: refs/heads/master@{#14222}
65 lines
1.6 KiB
Plaintext
65 lines
1.6 KiB
Plaintext
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import("../build/webrtc.gni")
|
|
|
|
group("stats") {
|
|
public_deps = [
|
|
":rtc_stats",
|
|
]
|
|
}
|
|
|
|
# GYP version: webrtc/stats/stats.gyp:rtc_stats
|
|
rtc_source_set("rtc_stats") {
|
|
cflags = []
|
|
sources = [
|
|
"rtcstats.cc",
|
|
"rtcstats_objects.cc",
|
|
"rtcstatscollector.cc",
|
|
"rtcstatscollector.h",
|
|
"rtcstatsreport.cc",
|
|
]
|
|
|
|
if (is_clang) {
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
}
|
|
|
|
deps = [
|
|
"../api:libjingle_peerconnection",
|
|
]
|
|
}
|
|
|
|
if (rtc_include_tests) {
|
|
# GYP version: webrtc/stats/stats.gyp:rtc_stats_unittests
|
|
rtc_test("rtc_stats_unittests") {
|
|
testonly = true
|
|
sources = [
|
|
"rtcstats_unittest.cc",
|
|
"rtcstatscollector_unittest.cc",
|
|
"rtcstatsreport_unittest.cc",
|
|
]
|
|
|
|
if (is_clang) {
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
}
|
|
|
|
deps = [
|
|
":rtc_stats",
|
|
"../base:rtc_base_tests_utils",
|
|
"../system_wrappers:metrics_default",
|
|
"//testing/gmock",
|
|
]
|
|
|
|
if (is_android) {
|
|
deps += [ "//testing/android/native_test:native_test_native_code" ]
|
|
}
|
|
}
|
|
}
|