GN: Change group deps to public_deps.
During GN vs GYP auditing it was discovered that some GN targets that had public_configs were not exposing them to dependents where the dependent depended on a group, which in turn included that target as a dependency. Instead of changing those public_configs to all_dependent_configs (which would be a change from GYP), it's better to just change those group targets to use public_deps instead. BUG=webrtc:6323 NOTRY=True TESTED=Generated GYP and GN project files on Mac and ran the tools/gyp_flag_compare.py script before and after this patch was applied. The file in question used for inspection was the webrtc/api/webrtcsessiondescriptionfactory.cc which is a part of the libjingle_peerconnection target. Review-Url: https://codereview.webrtc.org/2344623002 Cr-Commit-Position: refs/heads/master@{#14222}
This commit is contained in:
parent
c26f77f5a6
commit
705ecc5dda
@ -13,7 +13,7 @@ if (is_android) {
|
||||
}
|
||||
|
||||
group("api") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":libjingle_peerconnection",
|
||||
]
|
||||
}
|
||||
|
||||
@ -20,13 +20,13 @@ if (is_linux) {
|
||||
}
|
||||
|
||||
group("examples") {
|
||||
deps = []
|
||||
public_deps = []
|
||||
|
||||
if (is_android) {
|
||||
deps += [ ":AppRTCDemo" ]
|
||||
public_deps += [ ":AppRTCDemo" ]
|
||||
}
|
||||
if (is_linux) {
|
||||
deps += [
|
||||
public_deps += [
|
||||
":peerconnection_client",
|
||||
":peerconnection_server",
|
||||
":relayserver",
|
||||
|
||||
@ -9,7 +9,7 @@
|
||||
import("../../build/webrtc.gni")
|
||||
|
||||
group("xmllite") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":rtc_xmllite",
|
||||
]
|
||||
}
|
||||
|
||||
@ -9,7 +9,7 @@
|
||||
import("../../build/webrtc.gni")
|
||||
|
||||
group("xmpp") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":rtc_xmpp",
|
||||
]
|
||||
}
|
||||
|
||||
@ -10,7 +10,7 @@ import("//build/config/linux/pkg_config.gni")
|
||||
import("../build/webrtc.gni")
|
||||
|
||||
group("media") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":rtc_media",
|
||||
]
|
||||
}
|
||||
|
||||
@ -15,7 +15,7 @@ declare_args() {
|
||||
}
|
||||
|
||||
group("modules") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
"audio_coding",
|
||||
"audio_conference_mixer",
|
||||
"audio_device",
|
||||
|
||||
@ -9,7 +9,7 @@
|
||||
import("../build/webrtc.gni")
|
||||
|
||||
group("p2p") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":rtc_p2p",
|
||||
]
|
||||
}
|
||||
|
||||
@ -9,7 +9,7 @@
|
||||
import("../build/webrtc.gni")
|
||||
|
||||
group("pc") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":rtc_pc",
|
||||
]
|
||||
}
|
||||
|
||||
@ -9,7 +9,7 @@
|
||||
import("../build/webrtc.gni")
|
||||
|
||||
group("stats") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":rtc_stats",
|
||||
]
|
||||
}
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user