6d262c504a
Add a method to TransformableVideoFrameInterface which returns a new instance of VideoFrameMetadata which the caller can move and use as they like. This will replace the existing GetMetadata which returns a dangerous const ref to a field which might change if someone calls SetMetadata etc. That method will be deprecated as soon as we've migrated Chromium usages. Bug: webrtc:14708 Change-Id: Id7c15f33d6ec28c4a975ce250cdc791d7a3087bc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/292940 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Tony Herre <herre@google.com> Reviewed-by: Tove Petersson <tovep@google.com> Cr-Commit-Position: refs/heads/main@{#39403}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.